Only show call button in Concierge and assistance page for eligible users #14499

francoisl · 2023-01-24T00:05:46Z

~~Hold until https://github.com/Expensify/Web-Expensify/pull/36149 is deployed to production~~

Changes

Only show the Call button in Concierge and the Get Assistance page for people eligible for Guide calls (i.e. have a guide assigned)
When clicking the button/option, open the Guide's calendar appointment booking link instead of the call modal

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/255964

Tests

For Expensify internal engineers:

If you haven't set up any guides locally yet, follow this SO post
Make sure your guide accounts all have a expensify_googleCalendarLink NVP set. If not, set it with anything as the value (doesn't necessarily need to be a valid Google Calendar link)
Follow the QA steps below

Verify that no errors appear in the JS console

Offline tests

Receiving the updated assigned guide's calendar link after creating or deleting a workspace requires being online. While offline, a workspace can be optimistically created or deleted, but the client won't receive the updated Guide's calendar link value until coming back online.

QA Steps

Create a new account
Open the chat with Concierge
Make sure you don't see the Phone 📞 icon in the top bar
Create a workspace
Close the left-hand panel, make sure the phone icon appears in the top bar of the Concierge chat (it can take a few seconds)
Click the button, make sure it opens a new tab on a Google calendar appointment booking page (if not, make sure your popup blocker didn't get triggered). Close that page without booking an appointment
Open your Workspace
Click the "Get Assistance from our team" question mark icon in the top
Make sure you see a "Schedule a setup call" option on the page
Click the option, make sure it opens a new tab on a Google calendar appointment booking page
Delete your workspace
Go back to the Concierge chat, make sure the phone icon is no longer present

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

New account without guide + creation of a workspace showing a guide being assigned (for test purposes, the Guide's appointment booking page is simply google.com)

Screen.Recording.2023-01-23.at.12.05.57.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-01-23.at.5.01.38.PM.mov

Mobile Web - Safari

Screen.Recording.2023-01-23.at.4.32.10.PM.mov

Screen.Recording.2023-01-23.at.4.32.44.PM.mov

Desktop

Screen.Recording.2023-01-23.at.4.55.35.PM.mov

iOS

Screen.Recording.2023-01-23.at.4.50.31.PM.mov

Android

Screen.Recording.2023-01-23.at.5.07.15.PM.mov

- Only show the Call button in the chat with Concierge for people eligible for Guide calls (i.e. have an guide assigned) - When clicking the button, open the Guide's calendar appointment booking link instead of the call modal

melvin-bot · 2023-01-24T18:47:22Z

@sobitneupane @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

Followed QA steps and following are the results:

Screenshots/Videos

Web

Screen.Recording.2023-01-25.at.14.01.36.mov

Mobile Web - Chrome

Screen.Recording.2023-01-25.at.14.26.33.mov

Mobile Web - Safari

Screen.Recording.2023-01-25.at.14.19.08.mov

Desktop

desktop_test.mov

iOS

Screen.Recording.2023-01-25.at.14.14.53.mov

Android

Screen.Recording.2023-01-25.at.14.23.02.mov

sobitneupane · 2023-01-25T09:24:43Z

When user is offline, even after deleting the workspace, phone icon is present in Concierge Chat. May be we can get rid of phone icon being optimistic. Just putting my thoughts to make sure it is an expected behavior.

francoisl · 2023-01-25T19:49:28Z

When user is offline, even after deleting the workspace, phone icon is present in Concierge Chat. May be we can get rid of phone icon being optimistic. Just putting my thoughts to make sure it is an expected behavior.

Good point and thanks for bringing this up, but to clarify, if the user deletes a workspace, they might still be eligible to phone calls with their guide. All of that is determined in the backend based on whether the user is on a private domain with a guide assigned, or still admin on any other workspace/policy that have a guide. So to be safe, we should not optimistically get rid of the phone icon.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

francoisl · 2023-01-27T21:27:05Z

Ok looks like we have all approvals, going to merge. Thanks for the review.

OSBotify · 2023-01-27T21:32:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-01-30T19:39:49Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.2.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-01-31T00:33:25Z

@francoisl we are randomly seeing not seeing call option. How do we define if it's expected or potentially an issue?

francoisl · 2023-01-31T01:03:09Z

I'll double-check. Can you let me know what account you were using please? If it was an expensifail.com or applause.expensifail.com, it's probably normal. It would be easiest to try with a new gmail account.

francoisl · 2023-01-31T01:09:53Z

QAed internally with a new account on a Gmail address.

New account, call button is not present in the Concierge chat

After creating a Workspace and a Guide being invited, the call button appears

The "Schedule a setup call" option is visible in the Get Assistance menu

After deleting the workspace, the phone option disappears from the Concierge chat

OSBotify · 2023-01-31T19:49:02Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.62-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2023-02-16T03:42:25Z

@marcochavezf @francoisl Payment for C+ review is due.

francoisl · 2023-02-17T00:21:19Z

Working on it, thanks for your patience. (cc @arielgreen)

sobitneupane · 2023-03-02T13:48:35Z

@francoisl @arielgreen Payment for C+ review is still due.

francoisl · 2023-03-02T18:45:02Z

Hm sorry about that, let me check internally what's up.

arielgreen · 2023-03-02T19:10:16Z

@sobitneupane just sent an offer in Upwork -- once accepted, I'll issue payment.

arielgreen · 2023-03-02T19:15:27Z

Paid.

francoisl added 3 commits January 23, 2023 11:54

Only show call button in Concierge for eligible leads

ad2abbb

- Only show the Call button in the chat with Concierge for people eligible for Guide calls (i.e. have an guide assigned) - When clicking the button, open the Guide's calendar appointment booking link instead of the call modal

Update GetAssistancePage component with Guide's calendar link

25802ae

Remove unused imports

eec8823

francoisl changed the title ~~Only show call button in Concierge for eligible leads~~ [HOLD Internal Web-E #36149] Only show call button in Concierge for eligible leads Jan 24, 2023

francoisl changed the title ~~[HOLD Internal Web-E #36149] Only show call button in Concierge for eligible leads~~ [HOLD Internal Web-E #36149] Only show call button in Concierge and assistance page for eligible users Jan 24, 2023

francoisl changed the title ~~[HOLD Internal Web-E #36149] Only show call button in Concierge and assistance page for eligible users~~ Only show call button in Concierge and assistance page for eligible users Jan 24, 2023

francoisl marked this pull request as ready for review January 24, 2023 18:46

francoisl requested a review from a team as a code owner January 24, 2023 18:46

melvin-bot bot requested review from marcochavezf and sobitneupane and removed request for a team January 24, 2023 18:47

sobitneupane reviewed Jan 25, 2023

View reviewed changes

sobitneupane approved these changes Jan 26, 2023

View reviewed changes

marcochavezf approved these changes Jan 26, 2023

View reviewed changes

francoisl merged commit ff9e01a into main Jan 27, 2023

francoisl deleted the francois-guideCallButton branch January 27, 2023 21:27

OSBotify mentioned this pull request Jan 30, 2023

Deploy Checklist: New Expensify 2023-01-30 #14661

Closed

13 tasks

trjExpensify mentioned this pull request Feb 14, 2023

Error doesn't disappear in Request a call page when user try to type new information #14673

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only show call button in Concierge and assistance page for eligible users #14499

Only show call button in Concierge and assistance page for eligible users #14499

francoisl commented Jan 24, 2023 •

edited

Loading

melvin-bot bot commented Jan 24, 2023

sobitneupane left a comment •

edited

Loading

sobitneupane commented Jan 25, 2023

francoisl commented Jan 25, 2023

sobitneupane left a comment

francoisl commented Jan 27, 2023

OSBotify commented Jan 27, 2023

OSBotify commented Jan 30, 2023

mvtglobally commented Jan 31, 2023

francoisl commented Jan 31, 2023

francoisl commented Jan 31, 2023

OSBotify commented Jan 31, 2023

sobitneupane commented Feb 16, 2023

francoisl commented Feb 17, 2023

sobitneupane commented Mar 2, 2023

francoisl commented Mar 2, 2023

arielgreen commented Mar 2, 2023

arielgreen commented Mar 2, 2023

Only show call button in Concierge and assistance page for eligible users #14499

Only show call button in Concierge and assistance page for eligible users #14499

Conversation

francoisl commented Jan 24, 2023 • edited Loading

Changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 24, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Jan 25, 2023

francoisl commented Jan 25, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

francoisl commented Jan 27, 2023

OSBotify commented Jan 27, 2023

OSBotify commented Jan 30, 2023

mvtglobally commented Jan 31, 2023

francoisl commented Jan 31, 2023

francoisl commented Jan 31, 2023

OSBotify commented Jan 31, 2023

sobitneupane commented Feb 16, 2023

francoisl commented Feb 17, 2023

sobitneupane commented Mar 2, 2023

francoisl commented Mar 2, 2023

arielgreen commented Mar 2, 2023

arielgreen commented Mar 2, 2023

francoisl commented Jan 24, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading