[HOLD for payment 2023-04-03] Invite member in workspace passes default message to email in 'They also added a message:' part when no message is passed

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open settings
3. Open Workspaces
4. Open any Workspace
5. Open 'Manage members'
6. Click on invite
7. Select user B, remove personal message and click on Invite
8. Open user B email to observe invite email

Expected Result:

Email should not have 'They also added a message:' part in it.

Actual Result:

Email has 'They also added a message:' part with default message (The one we removed while sending the invite)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.2.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

email.adding.default.message.issue.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674637561870409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011a0955c8ca823f3a
• Upwork Job ID: 1620771101080711168
• Last Price Increase: 2023-02-01

[MitchExpensify]

I reproduced this. If no personal message has been added, I agree we should take the "You have been invited.." sentence out of the inviters voice by removing "They also added a message:"

To that end, I'd also remove the quotations around "You have been invited.." if no personal message has bee added.

I am unsure if this issue can be can be handled by contributors, and based on the Bug Zero SO, I'm going to label Engineering to help decide if it should be labelled External or Internal

[MitchExpensify]

Lil bump @nkuoch just to help me understand if this is suitable for internal or external labelling, thank you!

[nkuoch]

Could be external, but I already know the fix, it's super easy, so I can do it myself

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011a0955c8ca823f3a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[nkuoch]

I feel that if the user removes the default message, we shouldn't send it at all, and only keep the email short:

Maybe just adding a link on "in Expensify" redirecting to https://use.expensify.com/ ?

[MitchExpensify]

I feel that if the user removes the default message, we shouldn't send it at all, and only keep the email short:

I agree. Although as I tried to think of the simplest messaging its not that different to the existing default message.

[nkuoch]

So do we agree we can just keep the email simple like in the screenshot above if the user removes the default message from the form?

And do we want to add a link on "In Expensify"?

[MitchExpensify]

So do we agree we can just keep the email simple like in the screenshot above if the user removes the default message from the form?

Agree! And I think a link makes sense

[MelvinBot]

@nkuoch, @sobitneupane, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

This issue has not been updated in over 15 days. @nkuoch, @sobitneupane, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MitchExpensify]

The PR is on production so I thiink we're good to close this, right @nkuoch ?

Also I don't believe any payment to be due to @sobitneupane because this was handled internally without their review. But please correct me if I'm wrong!

Remaining steps for me are to pay @dhanashree-sawant

[MitchExpensify]

Offer sent @dhanashree-sawant

[dhanashree-sawant]

Hi @MitchExpensify , thanks I have accepted the offer.

[MitchExpensify]

Paid! Thanks everybody :)

[sobitneupane]

@MitchExpensify I reviewed the internal pr #14800. Payment is due.

[MitchExpensify]

Thanks so much for correcting me @sobitneupane! I'll get that sorted now.

[MitchExpensify]

Ok I've made a note to revisit your payment once #14800 has been on production for 7 days. Thanks again @sobitneupane!

[sobitneupane]

Thanks @MitchExpensify

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Dont add default message on invite if user removed it #14800

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane / @nkuoch] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane / @nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane / @nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MitchExpensify] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/272236

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

The PR that introduced the bug has been identified. Link to the PR:

I don't think it's a bug. It is an improvement.

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

Since, it's not a bug, no offending PR.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not required.

@nkuoch Do you agree?

[sobitneupane]

Regression Test Proposal

• Open the app and login with user A
• Open any workspace
• Open 'Manage members'
• Invite user B by removing default personal message
• Open user B email to observe invite email
• Verify that the user B receives an email that doesn't contain the default message.

Do we agree 👍 or 👎

[MitchExpensify]

Regression step addition requested here https://github.com/Expensify/Expensify/issues/272236

[MitchExpensify]

@sobitneupane I issued the payment as a bonus on an old contract(#14228 for the record), I hope thats fine! Thanks again