[$1000] Email address is being displayed on the IOU preview instead of the last name #14228

kavimuru · 2023-01-11T23:14:52Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open chat of a user that has set only last name (empty first name)
Click on the + icon
Click on Send Money
Enter any amount
Click Next
Click I'll settle up elsewhere

Expected Result:

Last name is displayed on the IOU preview like it is displayed everywhere else

Actual Result:

Email address is being displayed instead of the last name on IOU preview
In LHN it appears with Last name

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.52-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

last.name.mov

Recording.1264.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673426920016829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e0d43c6a348fa48c
Upwork Job ID: 1613588503429910528
Last Price Increase: 2023-01-12

melvin-bot · 2023-01-11T23:14:57Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MitchExpensify · 2023-01-12T01:33:03Z

Not a bug because the profile is incomplete so its reasonable to display the email of the user instead of surname - Discussion here https://expensify.slack.com/archives/C049HHMV9SM/p1673487138834609?thread_ts=1673426920.016829&cid=C049HHMV9SM

MitchExpensify · 2023-01-12T17:08:46Z

We're actually going to fix this in favor of the consistent pattern that exists today. Namely, showing the last name regardless of not having a first name saved

MitchExpensify · 2023-01-12T17:27:11Z

My mistake! This is indeed reproducible (I was looking at LHN versus the preview, my bad):

Web:

Desktop app:

melvin-bot · 2023-01-12T17:27:36Z

Job added to Upwork: https://www.upwork.com/jobs/~01e0d43c6a348fa48c

melvin-bot · 2023-01-12T17:27:39Z

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-01-12T17:27:48Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

melvin-bot · 2023-01-12T17:27:55Z

Triggered auto assignment to @robertjchen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

bernhardoj · 2023-01-12T17:38:29Z

Proposal

We can add another or condition to get the last name in case the first name is empty.

diff --git a/src/components/ReportActionItem/IOUPreview.js b/src/components/ReportActionItem/IOUPreview.js
index 1c997119d..cb3115602 100644
--- a/src/components/ReportActionItem/IOUPreview.js
+++ b/src/components/ReportActionItem/IOUPreview.js
@@ -119,8 +119,11 @@ const IOUPreview = (props) => {
     const isCurrentUserManager = managerEmail === sessionEmail;
 
     const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '')
+                        || lodashGet(props.personalDetails, [ownerEmail, 'lastName'], '') 
                         || Str.removeSMSDomain(managerEmail);
-    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);
+    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') 
+                        || lodashGet(props.personalDetails, [ownerEmail, 'lastName'], '') 
+                        || Str.removeSMSDomain(ownerEmail);
     const managerAvatar = lodashGet(props.personalDetails, [managerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(managerEmail);
     const ownerAvatar = lodashGet(props.personalDetails, [ownerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(ownerEmail);
     const cachedTotal = props.iouReport.total && props.iouReport.currency

Ollyws · 2023-01-12T17:44:14Z

Proposal

We just need to change firstName to displayName:

diff --git a/src/components/ReportActionItem/IOUPreview.js b/src/components/ReportActionItem/IOUPreview.js
index 1c997119d..d1ea9faad 100644
--- a/src/components/ReportActionItem/IOUPreview.js
+++ b/src/components/ReportActionItem/IOUPreview.js
@@ -118,9 +118,9 @@ const IOUPreview = (props) => {
     // Pay button should only be visible to the manager of the report.
     const isCurrentUserManager = managerEmail === sessionEmail;
 
-    const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '')
+    const managerName = lodashGet(props.personalDetails, [managerEmail, 'displayName'], '')
                         || Str.removeSMSDomain(managerEmail);
-    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);
+    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'displayName'], '') || Str.removeSMSDomain(ownerEmail);
     const managerAvatar = lodashGet(props.personalDetails, [managerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(managerEmail);
     const ownerAvatar = lodashGet(props.personalDetails, [ownerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(ownerEmail);
     const cachedTotal = props.iouReport.total && props.iouReport.currency

daraksha-dk · 2023-01-12T17:55:17Z

Proposal

Display name is enough it will also handle email/phone

App/src/components/ReportActionItem/IOUPreview.js

Lines 121 to 123 in 9a7b027

    
           const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '') 
        
                               || Str.removeSMSDomain(managerEmail); 
        
           const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);

Make the suggested changes -

-   const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '')
-                        || Str.removeSMSDomain(managerEmail);

+    const managerName = lodashGet(props.personalDetails, [managerEmail, 'displayName'], '')
-    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);
+    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'displayName'], '')

bernhardoj · 2023-01-12T18:04:52Z

Using display name will show both first name and last name, but I think we only want to show either the first or the last name (or email if both empty).

sobitneupane · 2023-01-12T18:29:02Z

Using display name will show both first name and last name, but I think we only want to show either the first or the last name (or email if both empty).

@bernhardoj I think so.

But IOU Quote must also be updated accordingly.

I am not sure if it is possible to change IOUQuote message from front end.

bernhardoj · 2023-01-13T02:02:12Z

Yeah, I think the IOU quote message is composed on the backend. Here is the params example when we send money through SendMoneyElsewhere api.

{"chatReportID": "1989942874938753", "clientID": 83, "iouReportID": "6320334089970635", "newIOUReportDetails": "{\"amount\":100,\"currency\":\"IDR\",\"requestorEmail\":\"bernhard.josephus+0000@gmail.com\",\"comment\":\"\",\"idempotencyKey\":\"2302bd1b-fb87-4bf9-9530-ef9fc36fe019\"}", "paymentMethodType": "Elsewhere", "reportActionID": "8939369918308593365", "transactionID": "2870947001874360238"}

Anyway, I have an updated proposal which I will post on the next comment.

bernhardoj · 2023-01-13T02:06:21Z

Updated Proposal

We can simplify the condition with just firstName and displayName

diff --git a/src/components/ReportActionItem/IOUPreview.js b/src/components/ReportActionItem/IOUPreview.js
index 1c997119d..b90d9ce42 100644
--- a/src/components/ReportActionItem/IOUPreview.js
+++ b/src/components/ReportActionItem/IOUPreview.js
@@ -119,8 +119,9 @@ const IOUPreview = (props) => {
     const isCurrentUserManager = managerEmail === sessionEmail;
 
     const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '')
-                        || Str.removeSMSDomain(managerEmail);
-    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);
+                        || lodashGet(props.personalDetails, [managerEmail, 'displayName'], '');
+    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') 
+                        || lodashGet(props.personalDetails, [ownerEmail, 'displayName'], '');
     const managerAvatar = lodashGet(props.personalDetails, [managerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(managerEmail);
     const ownerAvatar = lodashGet(props.personalDetails, [ownerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(ownerEmail);
     const cachedTotal = props.iouReport.total && props.iouReport.currency

If first name is empty, then display name will only contains either last name or email.

Or,

we can use an existing function to get the name which basically do the same as above.

diff --git a/src/components/ReportActionItem/IOUPreview.js b/src/components/ReportActionItem/IOUPreview.js
index 1c997119d..7f9844de7 100644
--- a/src/components/ReportActionItem/IOUPreview.js
+++ b/src/components/ReportActionItem/IOUPreview.js
@@ -118,9 +118,8 @@ const IOUPreview = (props) => {
     // Pay button should only be visible to the manager of the report.
     const isCurrentUserManager = managerEmail === sessionEmail;
 
-    const managerName = lodashGet(props.personalDetails, [managerEmail, 'firstName'], '')
-                        || Str.removeSMSDomain(managerEmail);
-    const ownerName = lodashGet(props.personalDetails, [ownerEmail, 'firstName'], '') || Str.removeSMSDomain(ownerEmail);
+    const managerName = ReportUtils.getDisplayNameForParticipant(managerEmail, true)
+    const ownerName = ReportUtils.getDisplayNameForParticipant(ownerEmail, true)
     const managerAvatar = lodashGet(props.personalDetails, [managerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(managerEmail);
     const ownerAvatar = lodashGet(props.personalDetails, [ownerEmail, 'avatar']) || ReportUtils.getDefaultAvatar(ownerEmail);
     const cachedTotal = props.iouReport.total && props.iouReport.currency

sobitneupane · 2023-01-13T02:33:38Z

@robertjchen We might need to handle it backend (at least partially) since change in IOUQuote message might not be possible at the front.

robertjchen · 2023-01-16T08:47:11Z

@sobitneupane Got it! That makes sense, I can look into the backend changes- appreciate the discussion here. @bernhardoj 's updated proposal looks good to me 👍

sobitneupane · 2023-01-17T08:16:43Z

Yes, for the frontend change we can go with @bernhardoj's proposal of using existing ReportUtils.getDisplayNameForParticipant() function.

MitchExpensify · 2023-01-17T17:01:28Z

@sobitneupane @adeel0202 @bernhardoj invited to Upwork here! Thanks

bernhardoj · 2023-01-18T15:49:31Z

Should I open the PR now?

@sobitneupane @robertjchen

MitchExpensify · 2023-01-18T19:56:57Z

Yes @bernhardoj

bernhardoj · 2023-01-19T03:50:02Z

Okay. I thought I need to wait for the assignment first 😅. PR is ready.

melvin-bot · 2023-01-20T00:58:38Z

📣 @bernhardoj You have been assigned to this job by @MitchExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

robertjchen · 2023-02-02T10:18:38Z

Looks like the change went out to prod last week, going to remove the Reviewing label to move this forward to the next step of the process.

robertjchen · 2023-02-02T10:21:33Z

It seems like we may be past the 7-day regression period as I don't see the checklist? cc: @MitchExpensify for clarification on next steps 🙏

MitchExpensify · 2023-02-03T17:32:50Z

All paid out! Thanks everyone

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 11, 2023

melvin-bot bot assigned MitchExpensify Jan 11, 2023

melvin-bot bot locked and limited conversation to collaborators Jan 11, 2023

MitchExpensify closed this as completed Jan 12, 2023

MitchExpensify reopened this Jan 12, 2023

MitchExpensify added the Needs Reproduction Reproducible steps needed label Jan 12, 2023

MitchExpensify added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Jan 12, 2023

melvin-bot bot unlocked this conversation Jan 12, 2023

melvin-bot bot changed the title ~~Email address is being displayed on the IOU preview instead of the last name~~ [$1000] Email address is being displayed on the IOU preview instead of the last name Jan 12, 2023

melvin-bot bot assigned sobitneupane Jan 12, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 12, 2023

melvin-bot bot assigned robertjchen Jan 12, 2023

melvin-bot bot added the Overdue label Jan 16, 2023

melvin-bot bot removed the Overdue label Jan 16, 2023

bernhardoj mentioned this issue Jan 19, 2023

fix iou preview display name #14408

Merged

54 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jan 19, 2023

MitchExpensify assigned bernhardoj Jan 20, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 20, 2023

robertjchen removed the Reviewing Has a PR in review label Feb 2, 2023

MitchExpensify closed this as completed Feb 3, 2023

MitchExpensify mentioned this issue Apr 3, 2023

[HOLD for payment 2023-04-03] Invite member in workspace passes default message to email in 'They also added a message:' part when no message is passed #14568

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$1000] Email address is being displayed on the IOU preview instead of the last name #14228

[$1000] Email address is being displayed on the IOU preview instead of the last name #14228

kavimuru commented Jan 11, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jan 11, 2023

MitchExpensify commented Jan 12, 2023 •

edited

Loading

MitchExpensify commented Jan 12, 2023

MitchExpensify commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

bernhardoj commented Jan 12, 2023 •

edited

Loading

Ollyws commented Jan 12, 2023

daraksha-dk commented Jan 12, 2023

bernhardoj commented Jan 12, 2023

sobitneupane commented Jan 12, 2023

bernhardoj commented Jan 13, 2023 •

edited

Loading

bernhardoj commented Jan 13, 2023

sobitneupane commented Jan 13, 2023

robertjchen commented Jan 16, 2023

sobitneupane commented Jan 17, 2023

MitchExpensify commented Jan 17, 2023

bernhardoj commented Jan 18, 2023

MitchExpensify commented Jan 18, 2023

bernhardoj commented Jan 19, 2023

melvin-bot bot commented Jan 20, 2023

robertjchen commented Feb 2, 2023

robertjchen commented Feb 2, 2023 •

edited

Loading

MitchExpensify commented Feb 3, 2023

[$1000] Email address is being displayed on the IOU preview instead of the last name #14228

[$1000] Email address is being displayed on the IOU preview instead of the last name #14228

Comments

kavimuru commented Jan 11, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jan 11, 2023

MitchExpensify commented Jan 12, 2023 • edited Loading

MitchExpensify commented Jan 12, 2023

MitchExpensify commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

melvin-bot bot commented Jan 12, 2023

bernhardoj commented Jan 12, 2023 • edited Loading

Proposal

Ollyws commented Jan 12, 2023

daraksha-dk commented Jan 12, 2023

Proposal

bernhardoj commented Jan 12, 2023

sobitneupane commented Jan 12, 2023

bernhardoj commented Jan 13, 2023 • edited Loading

bernhardoj commented Jan 13, 2023

Updated Proposal

sobitneupane commented Jan 13, 2023

robertjchen commented Jan 16, 2023

sobitneupane commented Jan 17, 2023

MitchExpensify commented Jan 17, 2023

bernhardoj commented Jan 18, 2023

MitchExpensify commented Jan 18, 2023

bernhardoj commented Jan 19, 2023

melvin-bot bot commented Jan 20, 2023

robertjchen commented Feb 2, 2023

robertjchen commented Feb 2, 2023 • edited Loading

MitchExpensify commented Feb 3, 2023

kavimuru commented Jan 11, 2023 •

edited by melvin-bot bot

Loading

MitchExpensify commented Jan 12, 2023 •

edited

Loading

bernhardoj commented Jan 12, 2023 •

edited

Loading

bernhardoj commented Jan 13, 2023 •

edited

Loading

robertjchen commented Feb 2, 2023 •

edited

Loading