-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAID] [$2000] Edit composer remains highlighted when emoji picker menu is opened. #14798
Comments
Triggered auto assignment to @strepanier03 ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~01a58ed48d7251320e |
Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Triggered auto assignment to @chiragsalian ( |
ProposalThis is due to we're preventing the execution of the diff --git a/src/pages/home/report/ReportActionItemMessageEdit.js b/src/pages/home/report/ReportActionItemMessageEdit.js
index 97fffebebc..ed42503ed3 100644
--- a/src/pages/home/report/ReportActionItemMessageEdit.js
+++ b/src/pages/home/report/ReportActionItemMessageEdit.js
@@ -243,10 +243,14 @@ class ReportActionItemMessageEdit extends React.Component {
}}
onBlur={(event) => {
// Return to prevent re-render when save/cancel button is pressed which cancels the onPress event by re-rendering
- if (_.contains([this.saveButtonID, this.cancelButtonID, this.emojiButtonID], lodashGet(event, 'nativeEvent.relatedTarget.id'))) {
+ if (_.contains([this.saveButtonID, this.cancelButtonID], lodashGet(event, 'nativeEvent.relatedTarget.id'))) {
return;
}
this.setState({isFocused: false});
+
+ if (this.emojiButtonID === lodashGet(event, 'nativeEvent.relatedTarget.id')) {
+ return;
+ }
toggleReportActionComposeView(true, this.props.isSmallScreenWidth);
}}
selection={this.state.selection} Pls note that we still need to prevent the I don't think we should move If some time in the future we don't want to close the composer when clicking |
Working well after the fix Screen.Recording.2023-02-04.at.09.33.57.mov |
Furthermore, I also found another issue on mweb (not related to the fix and the current PR, but related for the highlighting composer issue). You can check it out in this slack thread |
Root Case
Due to above condition isFocused not set to false and Input still look like as focused. We are using this condition for different purpose (to prevent calling of toggleReportActionComposeView in specific condition). Proposal We should always set isFocus false on blur, because if onBlur is called that's mean Input is no more focused now, in this case user cannot type anything in it so there is no reason to show input as focused. diff --git a/src/pages/home/report/ReportActionItemMessageEdit.js b/src/pages/home/report/ReportActionItemMessageEdit.js
index 97fffebebc..272392b941 100644
--- a/src/pages/home/report/ReportActionItemMessageEdit.js
+++ b/src/pages/home/report/ReportActionItemMessageEdit.js
@@ -242,11 +242,12 @@ class ReportActionItemMessageEdit extends React.Component {
toggleReportActionComposeView(false, this.props.isSmallScreenWidth);
}}
onBlur={(event) => {
+ this.setState({isFocused: false});
+
// Return to prevent re-render when save/cancel button is pressed which cancels the onPress event by re-rendering
if (_.contains([this.saveButtonID, this.cancelButtonID, this.emojiButtonID], lodashGet(event, 'nativeEvent.relatedTarget.id'))) {
return;
}
- this.setState({isFocused: false});
toggleReportActionComposeView(true, this.props.isSmallScreenWidth);
}}
selection={this.state.selection} |
@kavimuru Please mention my optional proposal from slack thread. As a bug reporter my optional solution should be evaluated first. Thanks |
@aneequeahmad if I'm not wrong, we don't have anything like that in our guidelines |
@rushatgabhane Please look at the guideline here it says I mentioned the issue creator @kavimuru in the slack thread to include a link to my proposal. It has happened for the 2nd or 3rd time that my optional solution is not included in the issue. Let me know if it makes sense or i'm missing something |
@aneequeahmad - I've reviewed the guidelines and it doesn't say that a solution proposed in Slack by the bug reporter is required to be considered before other proposals. It does say that you can optionally propose a solution in Slack but it's your responsibility to ensure it's added to the issue created for the bug. In this case, we'd already received proposals on the GH by the time you posted your proposal in Slack and commented on the GH about your proposal. I would recommend posting your proposal on the GH rather than in Slack and relying on a third party to post your solution. |
reviewing proposals |
@strepanier03 Please look at the slack thread here. I'm pretty sure that the bug reporter has the priority that their proposal is evaluated first.
I tagged the issue reporter(@kavimuru) in the slack thread here on Again, i asked the issue reporter on
I posted my proposal in slack on
Yes, you're right Github is the right place to post and evaluate proposals. But how can we make sure the bug reporter has the right to post proposal on Github when their is time difference and other factors. In my case When i woke up CC: @mallenexpensify |
@strepanier03 Oh yes, that's unusual. I'll wait for the new offer. Thanks |
@strepanier03 any update here ? |
@aneequeahmad I am still getting the error but I had some team members trying to help me. You will see an offer without a job connected that you can ignore. My team member also created an actual job for this and I just hired you for it. The job is https://www.upwork.com/jobs/~01a58b143d5995e2ff. The contract you can ignore is from Kadie Alexander. They are going to close it so you might never see it but just in case you do you can ignore it. |
@rushatgabhane - Once the BugZero checklist is complete I'll be able to handle your Upwork pay out. |
@strepanier03 accepted the offer. Also, reporting onus is missing in the offer. |
@aneequeahmad you should see a contract offer for the reporting bonus, can you take a look? |
Alright, just paid that out @aneequeahmad - you should be all set. @rushatgabhane I'll check back in Monday to see if the checklist is finished. |
Just waiting on the BZ checklist to be completed @rushatgabhane @chiragsalian, then we can wrap this one up. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi @strepanier03 I've completed the checklist above ^ because I can't edit the original message. Apologies for the delay 🙇 |
Downvote on the above post, because I disagree with the tagged issue for the root cause. I can confirm that this feature was working on that PR. See Video #12095 (comment). Maybe find the correct root cause. |
@rushatgabhane - I'll check back in tomorrow after you've had time to review @parasharrajat comment here. |
Yeah I was wrong. Thanks for the help @parasharrajat |
Thank you Rushat 🙌 , if you want to @ mention me when you do I can make the update in the BZ checklist and finish paying this out to you. |
@strepanier03, @chiragsalian, @rushatgabhane, @aneequeahmad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Please remove the invalid comment on the issue https://github.com/Expensify/App/pull/12095/files#r1148725844 and the invalid checklist #14798 (comment) from this issue. Thanks. It helps keep the right context and stats. Thanks. |
@strepanier03 im not able to find the commit that caused this bug |
I hid those comments from the incorrect PR and paid you out @rushatgabhane. Thank you all for the work you did here and for helping each other out with the final steps. Closing now! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Edit composer shouldn’t be highlighted
Actual Result:
Edit composer remains highlighted.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.64-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675165374280019
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: