[HOLD for payment 2023-03-13] [$1000] Group member orders keeps on changing randomly when it has more then 1 user with phone number as primaryLogin

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any group report with more then 1 user with phone number as primaryLogin or create a group with 2 or more users having phone number as primaryLogin
3. Click on profile Icons of members displayed on top of group report chat
4. Click on one of the phone number user and click on message
5. Navigate back to report archive page
6. Observe members order in name of group and open the group to observe the profile icons of members on top of group chat

Expected Result:

Members order should remain same as it was before

Actual Result:

Members order changes to phone number first and then email or name and when we open the group chat, it glitches and rectifies the members order as back to normal

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

group.name.glitch.mp4

DFDO9986.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675703922896249

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128253986dcc547e6
• Upwork Job ID: 1629147765832331264
• Last Price Increase: 2023-02-24

[MelvinBot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[slafortune]

Hey @kavimuru do you have more details to add to this GH?

[kavimuru]

@slafortune My bad, updated the steps

[slafortune]

Thanks, @kavimuru Is this happening on all platforms?

[slafortune]

@kavimuru just checking if you had a chance to verify if this is an issue on all platforms.

[kavimuru]

@slafortune Issue reproducible in all the platforms.

[slafortune]

Thanks, @kavimuru I think that was my misunderstanding. Are you listing all platforms affected rather than simply checking the ones that are affected? I remember another GH where there was only one listed (but not checked).

[kavimuru]

@slafortune I remove the platforms in which the issue is not reproduced instead of putting check mark.

[MelvinBot]

@slafortune this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@slafortune Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@slafortune 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[slafortune]

Sorry for my delay! I wonder what would be the expected order of listing members - alphabetical always regardless who is the last to reply/send/or be added?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0128253986dcc547e6

[MelvinBot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix group member order changing randomly when group members have phone numbers #15509

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Refactor Creating a Chat to be optimistic #11439
• [@sobitneupane / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor Creating a Chat to be optimistic #11439 (comment)
• [@sobitneupane / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@abdulrahuman5196] Propose regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

@luacmartins @miljakljajic #15644 is not dupe of this bug as mentioned here - #14886 (comment)

Unable to comment there due to limited access

[abdulrahuman5196]

Regression test:

1. Open the app
2. Open any group report with more then 1 user with phone number as primaryLogin
3. Click on profile Icons of members displayed on top of group report chat
4. Click on one of the phone number user and click on message
5. Navigate back to report archive page
6. Order of the group members shouldn't change.

[abdulrahuman5196]

Job added to Upwork: https://www.upwork.com/jobs/~0128253986dcc547e6

@slafortune I have applied for the upwork job here.

[dhanashree-sawant]

Hi @slafortune, I have also applied to that job for reporting bonus.

[MelvinBot]

@slafortune, @luacmartins, @sobitneupane, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

No updates yet because of ECX

[luacmartins]

@slafortune BZ checklist is complete on my end and @abdulrahuman5196 proposed test steps here.

[luacmartins]

Just waiting on payment

[slafortune]

@abdulrahuman5196 and @dhanashree-sawant are paid - once @sobitneupane accepts - payment will be done as well.

[slafortune]

regression test GH created and added 👍

[luacmartins]

@slafortune are we still waiting for @sobitneupane to accept the payment?

[sobitneupane]

I have accepted the offer.

[luacmartins]

Cool! Looks like we are all done here!