[HOLD] [$2000] single backtick message selection has some extra padding at the top

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any chat
2. Send text message wrapped in single backtick, e.g. Hello world
3. Long press the message
4. Observe the selected message

Expected Result:

The selected area should have the same padding from the top and the bottom from the border

Actual Result:

top has some extra margin than bottom space

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• iOS / native

Version Number: 1.2.69-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen_Recording_20230209_111746_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1675802761130049
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015c356c51bf928ca6
• Upwork Job ID: 1626148972311486464
• Last Price Increase: 2023-02-23

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

Came in over the weekend, will look into this tomorow.

[sophiepintoraetz]

Android

iOS

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sophiepintoraetz]

Seems similar to #15195

[danieldoglas]

Thanks @sophiepintoraetz . This one can be external, so adding the label.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015c356c51bf928ca6

[MelvinBot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Current assignee @danieldoglas is eligible for the External assigner, not assigning anyone new.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is an extra space above code text and it's noticeable when we highlight it.

What is the root cause of that problem?

On native, we are using WrappedText component to render code block. Inside of it, we wrap the text with 2 views.

App/src/components/InlineCodeBlock/index.native.js

Lines 6 to 24 in a5b9c9b

	const InlineCodeBlock = (props) => {
	const TDefaultRenderer = props.TDefaultRenderer;
	return (
	<TDefaultRenderer
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...props.defaultRendererProps}
	>
	<WrappedText
	textStyles={[props.textStyle]}
	wordStyles={[
	props.boxModelStyle,
	styles.codeWordStyle,
	]}
	>
	{props.defaultRendererProps.tnode.data}
	</WrappedText>
	</TDefaultRenderer>
	);
	};

App/src/components/InlineCodeBlock/WrappedText.js

Lines 55 to 70 in a5b9c9b

	// Outer View is important to vertically center the Text
	<View
	// eslint-disable-next-line react/no-array-index-key
	key={`${colText}-${colIndex}`}
	style={styles.codeWordWrapper}
	>
	<View
	style={[
	props.wordStyles,
	colIndex === 0 && styles.codeFirstWordStyle,
	colIndex === rowText.length - 1 && styles.codeLastWordStyle,
	]}
	>
	<Text style={props.textStyles}>{colText}</Text>
	</View>
	</View>

The outer view height is 20, while the inner view is 18 with top value is 4 (on iOS, the inner view height is 16). The height difference and the addition of the top is the culprit of this issue.

I think the reason we are doing that is to align the code block text well with other text. Here is the comparison.

With top	Without top

What changes do you think we should make in order to solve the problem?

To solve this, we can apply a bottom padding to InlineCodeBlock (native). 4 for iOS, 6 for Android. We need to apply different value because iOS codeWordStyle height is 16 while Android is 18. Or we can set both height to 18, so both padding will be 6.

[sophiepintoraetz]

Still holding on #4733

[sophiepintoraetz]

Bumped the CME for that issue. Still holding.

[sophiepintoraetz]

CME is back from holiday

[sophiepintoraetz]

Still holding.

[sophiepintoraetz]

Still holding.

[sophiepintoraetz]

Still holding.

[sophiepintoraetz]

Still holding

[danieldoglas]

Following the new guidelines for external issues, removing myself from this until we have approved proposals.

[sophiepintoraetz]

Still holding.

[sophiepintoraetz]

OG issue is in review!

[sophiepintoraetz]

Original linked issue has been closed to work on a more holistic solution - so will likely fold this issue into that one and pay out the reporting bonus here.

[sophiepintoraetz]

Thought on this, and this does not seem to be something we will fix for the mean time. If this does get resolved, we can reference this issue for the original reporter. But going to close for now.