Android/iOS - Code blocks are overflowing the app border

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue is failing #4624 (CC @parasharrajat)

Action Performed:

1. Navigate to a conversation in iOS or Android
2. Send a long message in a code block

Expected Result:

Code block should be displayed in the area of the conversation.

Actual Result:

Code block is partially visible because is overflowing the app border.

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.0.86-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ecab5a591272dd78
• Upwork Job ID: 1602379910299570176
• Last Price Increase: 2022-12-27

[MelvinBot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

@iwiznia even reverting #4624 PR does not fix this issue. This issue is caused by upgrading the react-native-render-html. And I am tracking multiple issues caused by that here meliorence/react-native-render-html#514.

[parasharrajat]

I am investigating it.

[iwiznia]

Oh sorry about that, I think that this PR caused this then #4047 cc @jsamr

[iwiznia]

Wait, I am confused, that PR was deployed a while ago, was this broken before and we did not notice?

[parasharrajat]

Yes. this is the list of issues that were caused by that upgrade.

1. Web - Chronos - Reply text for the commands "top" and "top help" are misaligned #4488.
2. [Hold for payment 2021-08-17] Code blocks renders to the end of the edge of the window #4377 . (What is wrong with Github? URLs for this issue and link pasted have the same id) notice 4377.
3. Links were clickable from empty space. Inline <a> tag taking full horizontal width on Web. meliorence/react-native-render-html#514
4. And this one.

It is just due to one reason that a wrapper node was removed in the new lib version for optimizations which I think should be reverted.

[parasharrajat]

Update, I have discussed this issue with the Lib owner and we are going to revert this change behind the flag which should fix the issue. It should be done by weekend.

[isagoico]

@johnmlee101 @parasharrajat Should this issue still be considered a deploy blocker?

Update: Just as a double check, I just retested this and it's still happening

[parasharrajat]

I think is happening on prod as well. so No deploy blocker.

Update:

1. After applying the latest patch from the lib, this specific issue is not fixed. The library has moved a long way from the earlier version.
2. I am still trying to find the best possible solution but currently, nothing seems to work.
3. Next planned thing is to check the diff between older and newer versions and find the root cause. If the fix is patchable, I will approach the lib maintainers otherwise try to solve it with combinations of settings.

[isagoico]

Confirmed this is also happening in prod too in iOS. Removing the deploy blocker label.

[parasharrajat]

Update:
This is really giving me nuts. I tried a lot of things but still no luck.

Planned:

I will revert the code to the old version before the upgrade of RNRH and try to observe why it was working. Hoping this will help.

[johnmlee101]

Did you have a revert PR to link @parasharrajat ? Or any update here?

[parasharrajat]

Sure, going to push this forward.

[parasharrajat]

IMO, POC looks good but it comes down to the RN team, what if they disapprove of the approach?

Meanwhile, I am discussing this internally https://expensify.slack.com/archives/C02NK2DQWUX/p1693327604262399 . You also have access to that so feel free to participate.

[zanyrenney]

hey @azimgd - in response to this question: Am I eligible for a compensation here?
Yes, we'll be sending over an offer for a fair amount considering the work done but the solution not being reached. Please look out for that on upwork.

[zanyrenney]

https://www.upwork.com/jobs/~0168597a8302cbc823 - job post here @azimgd

[azimgd]

Thanks Zanny, I won't accept the "offer for a fair amount" given the requirements change and will continue working on this. Thanks.

[zanyrenney]

After we spoke in DM @azimgd did agree to the payment offered.

We have discussed this issue internally

As this job has been open and unresolved for a really long time, we're exploring new ways to solve this. We really appreciate all the work on it so far but because this is really old and convoluted, we're going to open a new job as a clean slate.

[zanyrenney]

Payment summary

• @azimgd $8k for the effort on this issue. - to be paid via ND.
• No reporting bonus is due.
• @puneetlath @JmillsExpensify and I just figuring out the C+ payment / plan here, thanks for patience!

[parasharrajat]

I would be happy to be assigned to the new job till this issue is fixed. I don't expect any payment ad V+ until this is resolved.

[zanyrenney]

Thank you @parasharrajat. As discussed in DM with @azimgd - he will be paid for his effort via ND.

@JmillsExpensify I have sent you Azim's email, please can you confirm the payment has happened?

I am then going to close this issue as we will tackle this in a new issue as the current issue is very old and convoluted. Thank you.

[zanyrenney]

Closing this out in this issue and working on this in another issue to move ahead here. @azimgd we discussed this and your payment in DM.

If you're having any problems with the ND payment, please can you ping @JmillsExpensify who owns the payment of these in NewDot, please! Thank you.

[JmillsExpensify]

$8,000 payment approved for @azimgd based on BZ summary.

[parasharrajat]

I've been involved in this project for some time, reviewing several iterations and participating in many pull requests. While we haven't reached a final solution yet, my efforts have helped along the way.

Looks like the latest project went stale and it may not be a top priority at the moment. However, given the time and effort I've invested, I believe this is the appropriate time to request the C+ payment.

I will continue reviewing the new task #27913

@zanyrenney Could you please finalize the C+ payment and update the payment summary?

[mallenexpensify]

@zanyrenney , 👀 above plz
@parasharrajat , can you follow the exact process from the C+ doc for requesting payment plz? Thx

[parasharrajat]

@mallenexpensify @zanyrenney Thanks for the input. But there is no uncertainty about my contributions on this issue. I have been active C+ on this issue since the start and reviewed each PR linked to this issue. I believe that I don't have to suggest compensation here, it should same as the contributor as per the policy.

#4733 (comment) Here I requested to hold the payment as I wanted to continue reviewing the planned work by cubuspl42. Those PRs also have been reviewed so we are way past those steps now. Then I followed the new issue #27913 and also reviewed all things related to it. I am still active on this issue. But it has stalled now and I don't see any plan ahead. Thus I am requesting the payment now.

If you can help push forward the new issue and help us draw a timeline, I'm happy to wait for a couple of months.

[mallenexpensify]

I believe that I don't have to suggest compensation here, it should same as the contributor as per the policy.

Fair. Discussing internally.

[zanyrenney]

Hey @parasharrajat as you're working on the issue this morphed into here -- #27913 the compensation would come once that is wrapped up: Can you pleas to revisit once the linked/associated issue gets fixed? Thanks!

[parasharrajat]

@zanyrenney Can you please update the payment summary here?

[zanyrenney]

payment summary

$8,000 due to @parasharrajat paid via ND requests
$8,000 already paid @azimgd paid via ND requests.

[parasharrajat]

payment requested as per #4733 (comment)

[JmillsExpensify]

$8,000 approved for @parasharrajat