Deploy Checklist: New Expensify 2021-08-17

[OSBotify]

Release Version: 1.0.86-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fixed messages are repeated on page refresh & process queue only when client is leader #2703
• Andrew 3313 link context menu #3931
• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [CP Staging] Remove duplicate form fields #4117
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• Update expensify common with new logging methods and improve logging #4191
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• Fix staging due to undefined Onyx key #4286
• Fix broken list components on staging #4300
• Patch for PR #4190  #4322
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Fix User is able to upload a file larger than 50mb #4358
• Fix: Selecting a language does not update in real time #4366
• Remove unused propType for CollapsibleSection #4386
• Fix: Infinite loader on login #4397
• add autofocus #4402
• Change Expensify.cash to New Expensify #4408
• Ping ApplauseLeads when PRs get CPed #4414
• Attempt at fixing race #4416
• Handle VBA errors with red field outlines #4431
• Race fix attempt 2 #4436
• Wallet balance translation fix in Payments Page #4461
• don't allow invalid characters #4478
• Performance: use React Native Render HTML explicit composite architecture #4502
• fix: message alignment #4503
• Show Avatar image for Workspace List Item in Sidebar #4512
• Allow users to login with validate code and be redirected to Workspace/Card modal #4519
• Fix the text style in about page #4522
• Fix the text style for Payment Methods #4523
• Updated Add Phone/Email Style in Profile Page #4532
• Handle undefined IOU Report on IOUdetails page #4534
• Refactor ReportScreen to improve chat switching #4538
• [NO QA] Add sentence in CONTRIBUTING.md about requesting increased compensation #4540
• Deploy iOS to production when deploying other platforms #4567
• [No QA] Make a dummy change for a test PR #4568
• Remove unnecessary withOnyx from chat messages #4573
• [No QA] Update package.json name to fix conflict issues #4578
• Copy update #4586
• [No QA] Remove duplicate subscription in Report.js file #4590
• [No QA] Fix deploy comments for regular staging deploys #4591
• Fix ExpensiInput autoFocus & tab Focus #4593
• Centralize Onyx subscriptions in ReportScreen #4594
• [NoQA] Fix deployBlocker workflow #4598
• Updated propType for Avatar containerStyles in Workspace #4600
• Added new marker Badge for Report unread messages #4603
• Update onyx & Fix the enable-payments page #4604
• Update eslint #4605
• Hide Password mismatch incase both the passwords are empty #4607
• Update react-native-onyx to reduce setState() calls / renders in withOnyx #4610
• Check for value before checking length #4613
• Clear storage immediately on sign out #4614
• fix: Inline code block styling #4624
• Fix: autofill on the BaseExpensiInput #4632
• Update state picker component in VBA flow #4633
• Changed Personal and Company Address Labels #4636
• Add Guides call request flow to workspace card configuration screen #4637
• [No QA] Simplify capturing performance metrics on release builds #4640
• Change picker value color #4641
• update copy for login #4644
• don't show user while searching #4647
• Hide automated accounts from Recent sections of Split Money/Request Money #4648
• Multiline for ExpensiTextInput #4649
• fixed: Name overflowing the available area #4650
• Added tooltips to all Icon buttons #4661
• add autofocus & hoverstyle #4662
• Move deploy blocker notification to open source channel #4670
• [No QA] Testing issue autoclosing feature #4672
• [No QA] Testing issue autoclosing feature for Expensify repo issue #4674
• Update withOnyx to fix prop dependent key updates #4676
• Update Standard.md #4681
• [CP Staging] Use props not state in NewPasswordForm #4684
• Fix context-menu on native devices #4687
• Add capatilisation to translation & some margin for the input #4688
• Search label removed, added no results found instead #4689
• select default/local currency #4691
• [No QA] [TEST] Testing webhook funcitonality to autoclose issue linked in PR #4695
• [No QA] Make Firebase traces an opt-in feature of global Timing class #4697
• Bump Onyx version to fix recent regressions #4706
• Exclude cards that are not activated #4720
• Fix enable payments page with another Onyx update #4721
• [NO QA] Document why we pass the currentDate but we don't use it #4724
• [NO QA] Update the PR template to enforce issue linking formatting #4725
• Change UI view for Attachments in Chat #4736
• Increase to 5 seconds #4740
• Handle errorText in TextInputWithLabel #4741
• Display the /bank-account/requestor page #4742
• Bumped expensify-common(Supports nested markdown links) #4750
• Update CONTRIBUTING.md #4751
• Hide localtime for Expensify Emails (Automated Accounts) #4755
• [No QA] Post deploy announcements in slack #4757
• [No QA] Performance tracking with flipper-plugin-performance #4760
• Fix StagingDeployBlocker where chat draft message is kept in the test input while switching chats #4761
• Added translations for CompanyStep #4765
• [No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
• Fix MarkerBadge Count #4773
• Fix: marker is not clickable on android #4774
• call debounce only when it's required #4777
• Update height of default buttons to to match the text inputs #4792
• New breakpoint for tablet size #4793
• Fix: IOU - Final review modal design #4795
• Update StagingDeployCash for manual cherry-picks #4798
• [No QA] Fix regression on web due to #4760 #4800
• Update fastlane version #4804
• Add missing period to preferences page #4806
• Remove unnecessary style causing bug in android #4807

Deploy Blockers:

• [Network] Messages are sent twice  #4214
• [hold for payment 25 august] Onyx changes break Exisiting App architecture. #4500
• Chat Switcher - Content of the chat does not change to correct chat when using chat switcher #4705
• Profile - User status is always offline #4710
• mWeb - Request Money - Search box is not auto focused when changing currency #4711
• Chat - New Message badge always displays 1 new message even when multiple are received #4712
• mWeb - Chat - Unable to scroll the chat after tapping on New Message badge #4715
• Android - Left half of the new message badge is unresponsive  #4716
• Blank modal displayed when navigating to enable-payments #4719
• Red field outlines are not displayed when entering incorrect information #4730
• [NO QA] Await Apple test credentials update before next deployment #4732
• Android/iOS - Code blocks are overflowing the app border #4733
• iOS - No space between "New" and "Expensify" for the app name #4739
• Android - Chat - Inline code block texts are displayed very close to the edge of the screen #4753
• iOS / Android - Screen will scroll on new messages when they are out of view #4754
• [HOLD for payment 2021-12-15] $500 Chat Switcher - Draft message from previous conv is displayed after using chat switcher #4756
• [Network] Messages are sending twice on staging desktop app #4766

cc @Expensify/applauseleads

[mountiny]

I have checked of these PRs which were just for testing a webhook functionality for following issue: https://github.com/Expensify/Expensify/issues/173928

• [No QA] Testing issue autoclosing feature #4672
• [No QA] Testing issue autoclosing feature for Expensify repo issue #4674
• [No QA] [TEST] Testing webhook funcitonality to autoclose issue linked in PR #4695

[isagoico]

Starting QA 🚀

[isagoico]

Checked off PRs that were incorrectly added to the checklist:

1. Fix ExpensiInput autoFocus & tab Focus #4593
2. Hide Password mismatch incase both the passwords are empty #4607
3. Check for value before checking length #4613
4. Clear storage immediately on sign out #4614
5. Fix: autofill on the BaseExpensiInput #4632
6. Update state picker component in VBA flow #4633
7. Changed Personal and Company Address Labels #4636
8. Change picker value color #4641
9. [CP Staging] Use props not state in NewPasswordForm #4684

[isagoico]

#4710 not reproducible anymore in 1.0.86-1 🎉 Checking it off

[isagoico]

Checked off #4712 since it's being worked on here #4669

[isagoico]

Checking off several PRs that were added because of the CP bug (Checking them off bc if I removed them they just get re added after another CP)

1. [No QA] Make a dummy change for a test PR #4568
2. fix: message alignment #4503
3. Race fix attempt 2 #4436
4. add autofocus #4402
5. Attempt at fixing race #4416
6. Fix: Infinite loader on login #4397
7. Fix: Selecting a language does not update in real time #4366
8. Fix User is able to upload a file larger than 50mb #4358
9. Update XCode to fix iOS deploy #4339
10. Update getPullRequestsMergedBetween to run pre-set string command #4336
11. Patch for PR #4190  #4322
12. Add offline message to IOU and Split bill and allow currency selection while offline #4019
13. [CP Staging] Remove duplicate form fields #4117
14. Modify line height so text does not get cut off in LHN #4143
15. Make sure we get state/status from the right variable name when we get chat report name #4239
16. Web - Settings - Dropdown symbol overlaps with text in the box #4243
17. Fix staging due to undefined Onyx key #4286
18. Fix broken list components on staging #4300
19. Fix the text style in about page #4522

[isagoico]

Regression is finished!
Issues found:

1. iOS - No space between "New" and "Expensify" for the app name #4739
2. Blank page displayed when navigating to /bank-account/requestor #4728
3. Red field outlines are not displayed when entering incorrect information #4730
4. Android - Left half of the new message badge is unresponsive  #4716
5. Android/iOS - Code blocks are overflowing the app border #4733
6. mWeb - Request Money - Search box is not auto focused when changing currency #4711
7. Blank modal displayed when navigating to enable-payments #4719
8. Unread message indicator does not disappear after some time has passed #4718
9. iOS - Chat - High resolution picture won't render properly after zoom #4717
10. mWeb - Chat - Unable to scroll the chat after tapping on New Message badge #4715
11. Chat - New Message badge always displays 1 new message even when multiple are received #4712
12. Profile - User status is always offline #4710

Comments added in PRs:

1. Andrew 3313 link context menu #3931 (comment)

Thanks!

[isagoico]

Summary of the Progress with deploy blockers:

1. Looks like Red field outlines are not displayed when entering incorrect information #4730 was fixed here Handle errorText in TextInputWithLabel #4741 but it has not been CPd to staging. Should we check it off the list? CC @aldo-expensify @alex-mechler @jasperhuangg @nkuoch
2. iOS - No space between "New" and "Expensify" for the app name #4739 was not a deploy blocker - Checking off Change Expensify.cash to New Expensify #4408
3. Blank page displayed when navigating to /bank-account/requestor #4728 was fixed but the PR has not been CPd to staging. Are we good to check it off? CC @joelbettner
4. Android - Left half of the new message badge is unresponsive  #4716 @parasharrajat has a fix for this, he just needs approval to proceed CC @madmax330 @Beamanator
5. iOS / Android - Screen will scroll on new messages when they are out of view #4754 is still reproducible CC @bondydaa
6. Android/iOS - Code blocks are overflowing the app border #4733 is failing PR fix: Inline code block styling #4624 CC @johnmlee101

[marcaaron]

I think this issue is a deploy blocker -> #4766
But I am not sure what's causing it and haven't verified if it happens or not on production.

[Beamanator]

@Julesssss and I approved and merged @#4716 - but I forgot to add CP Staging :O - @roryabraham @AndrewGable can one of y'all manually CP this? Didn't see these instructions in this SO

[isagoico]

Checking off several PRs that were added due to the CP issue:

1. Ping ApplauseLeads when PRs get CPed #4414
2. Allow users to login with validate code and be redirected to Workspace/Card modal #4519
3. Add Guides call request flow to workspace card configuration screen #4637
4. don't show user while searching #4647
5. Add capatilisation to translation & some margin for the input #4688
6. Search label removed, added no results found instead #4689
7. select default/local currency #4691
8. Increase to 5 seconds #4740
9. Handle errorText in TextInputWithLabel #4741
10. Display the /bank-account/requestor page #4742
11. Bumped expensify-common(Supports nested markdown links) #4750
12. Update CONTRIBUTING.md #4751

[roryabraham]

@Julesssss and I approved and merged @#4716 - but I forgot to add CP Staging :O - @roryabraham @AndrewGable can one of y'all manually CP this? Didn't see these instructions in this SO

Yessir, manually CPing here.

[roryabraham]

Sorry, that was careless of me. #4716 is an issue, not a pull request, so it can't be CP'd. @Beamanator did you mean #4774 (the PR that resolved #4716)?

[roryabraham]

Feel pretty confident that's what you meant so I'm going to CP #4774

[Beamanator]

Yes sorry that's what I meant!

[roryabraham]

#4774 is being CP'd to staging here

[isagoico]

Update on deploy blockers:

1. Android - Left half of the new message badge is unresponsive  #4716 - Was a pass 🎉 (Fixed here Fix: marker is not clickable on android #4774)
2. Red field outlines are not displayed when entering incorrect information #4730 is still considered a deploy blocker (CC @marcaaron @aldo-expensify)
3. Android/iOS - Code blocks are overflowing the app border #4733 (comment) is still reproducible (left a question for @parasharrajat and @johnmlee101)
4. Re testing this atm [Network] Messages are sending twice on staging desktop app #4766

Checked off this issue since it was considered not a deploy blocker #4754

Checking off this PRs that were added to the list because of the CP issue:

1. update copy for login #4644
2. Multiline for ExpensiTextInput #4649
3. Added tooltips to all Icon buttons #4661
4. Fix context-menu on native devices #4687
5. [NO QA] Document why we pass the currentDate but we don't use it #4724
6. [NO QA] Update the PR template to enforce issue linking formatting #4725
7. Change UI view for Attachments in Chat #4736
8. Hide localtime for Expensify Emails (Automated Accounts) #4755
9. [No QA] Post deploy announcements in slack #4757
10. [No QA] Performance tracking with flipper-plugin-performance #4760
11. Added translations for CompanyStep #4765
12. [No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
13. Fix MarkerBadge Count #4773
14. call debounce only when it's required #4777
15. Update height of default buttons to to match the text inputs #4792
16. New breakpoint for tablet size #4793
17. Fix: IOU - Final review modal design #4795
18. Update StagingDeployCash for manual cherry-picks #4798
19. [No QA] Fix regression on web due to #4760 #4800
20. Add missing period to preferences page #4806

[isagoico]

Update on missing unchecked PRs:

1. fix: Inline code block styling #4624 is still failing because of Android/iOS - Code blocks are overflowing the app border #4733 (comment)
2. Handle VBA errors with red field outlines #4431 is still failing because of Blank page displayed when navigating to /bank-account/requestor #4728 since we can't navigate to the Requestor page. Issue was fixed but it has not been CPd to staging, can we check the PR off? CC @joelbettner
3. Handle VBA errors with red field outlines #4431 is a pass now with the fix pushed for this issue Red field outlines are not displayed when entering incorrect information #4730 (there's still this issue that it's going to be fixed internally here https://github.com/Expensify/Expensify/issues/174749)
4. add autofocus & hoverstyle #4662 Checking off this one since mWeb - Request Money - Search box is not auto focused when changing currency #4711 is not a deploy blocker
5. I think we can check off Update fastlane version #4804 I was able to download the latest build in Android so I guess it's a pass? can @roryabraham @aldo-expensify or @sketchydroide confirm just in case 😬
6. Checking off Added new marker Badge for Report unread messages #4603 since iOS / Android - Screen will scroll on new messages when they are out of view #4754 was considered not a deploy blocker

[TomatoToaster]

Handle VBA errors with red field outlines #4431 is still failing because of Blank page displayed when navigating to /bank-account/requestor #4728 since we can't navigate to the Requestor page. Issue was fixed but it has not been CPd to staging, can we check the PR off? CC @joelbettner

I think we can check this off, but it would be better to manually CP that PR (here) since it would also unblock us from testing the VBA flow for N6. Would it be possible to manually CP it @roryabraham @AndrewGable?

[roryabraham]

@TomatoToaster Yep, I can CP #4742

[roryabraham]

Something went wrong with that CP. Let me try to diagnose

[roryabraham]

Oh, nevermind. The error was unrelated. #4742 is being deployed here.

[isagoico]

I'm gonna go ahead and check off #4804 since Android and iOS deploys are working as expected now (@roryabraham @aldo-expensify @sketchydroide please stop me if I'm wrong).

Only things missing are:

1. [Network] Messages are sent twice  #4214 (CC @marcaaron, not sure if we can remove the deploy blocker here)
2. Remove unnecessary style causing bug in android #4807 (comment) (CC @aldo-expensify)

[roryabraham]

#4214 is demoted from deploy-blocker to regular-old-bug, and while the fix to #4807 (comment) is currently being CP'd to staging, the issue itself has also been demoted from deploy-blocker to regular-old-bug.

So I think we are good to run a prod deploy. It will include #4807 (comment)

[roryabraham]

[roryabraham]

OSBotify doesn't like me

[roryabraham]