Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Switcher - Content of the chat does not change to correct chat when using chat switcher #4705

Closed
isagoico opened this issue Aug 17, 2021 · 6 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Press ctrl+k
  2. Change to another chat

Expected Result:

User is navigated to chat and the correct chat content is displayed.

Actual Result:

LHN and header show the correct chat BUT chat content displayed is from previous chat.

Workaround:

Clickin the chat in search shows the correct conversation.

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.0.86-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Grabando.205.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub


From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1629232126472800

(staging web, most probably a huge deploy blocker): I can't switch to another conversation using CMD+K, the weird part is that the title changes, but not the contents. It does work if I click on the conversation.

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Aug 17, 2021
@MelvinBot
Copy link

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor

Looked at currently CP'd PR's but none seem to be causing it. Looking at PRs from the last full deploy now.

@luacmartins
Copy link
Contributor

@marcaaron It seems this was introduced in #4610. Changes in the staging branch here https://github.com/Expensify/App/blob/staging/package.json#L87

Let's CP #4676 to staging?

@marcaaron
Copy link
Contributor

Thanks @luacmartins I have been trying to get this fixed before it goes to staging but could not find anyone to help 🙃

@marcaaron
Copy link
Contributor

This is fixed now on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants