Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fix deploy comments for regular staging deploys #4591

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

roryabraham
Copy link
Contributor

Details

This hopefully fixes a regression introduced in #4274

Fixed Issues

n/a

Tests

  1. Merge this PR.
  2. Whenever a regular staging or production deploy completes, verify that the deployed PRs get a deploy comment including the actor who triggered that deploy.

QA Steps

None.

Tested On

GitHub only

@roryabraham roryabraham requested a review from a team as a code owner August 11, 2021 21:05
@roryabraham roryabraham self-assigned this Aug 11, 2021
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team August 11, 2021 21:05
@roryabraham roryabraham merged commit d56f974 into main Aug 11, 2021
@roryabraham roryabraham deleted the Rory-FixMarkPullRequestsAsDeployed branch August 11, 2021 21:52
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants