New breakpoint for tablet size #4793
Conversation
src/styles/styles.js
Outdated
| @@ -1880,6 +1880,12 @@ const styles = { | |||
| width: '150%', | |||
| }, | |||
|
|
|||
| fullscreenCardTablet: { | |||
There was a problem hiding this comment.
It seems like the "tablet" styles are triggered with isMediumScreenWidth. I would suggest we align the words to be consistent here and just use something like fullscreenCardMediumScreen
There was a problem hiding this comment.
Changed all
- workspaceCardTablet ➡️
workspaceCardMediumScreen - fullscreenCardTablet ➡️
fullscreenCardMediumScreen - workspaceCardContentTablet ➡️
workspaceCardContentMediumScreen
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Hello @kakajann, Any QA tests needed for this PR? |
|
Tested this by navigating to Workspace > Expensify Card and verifying the different breakpoints and it was a pass. @shawnborton @timszot can you confirm these were the QA tests needed for this PR? |
|
Sorry @isagoico, I'll add QA test steps in my next PR's |
|
Looks correct to me 👍 |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
|
@kakajann Great job with this one! I just wanted to raise awareness about a change we did in our issues/PR management process which helps us track the payment due date automatically. For that, we need the PR description to follow the PR template for this repository. Specifically, I am talking about the Fixed issues section. We need the issues to be linked without using the github keywords. Simply use dollar sign and copy/paste in the link of the issue. Like so:
Then the issue will be automatically updated on deployment and we will not miss paying you on Upwork 🎉 Thank you for keeping that in mind in your next PRs 😊 and keep them coming 🎉 |
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Fixed Issues
Fixes #4659
Tests
QA Steps
Tested On
Tablet 801px
Tablet 1024px