-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the text style in about page #4522
Conversation
To help get rid of the dangling orphan, maybe we can change the last line to "Help us build the next generation of Expensify." - thoughts? |
Looks great! |
merge conflicts |
@shawnborton : Wording was changed in this commit and it screwed up your nice alignment... What do you advise ? |
If we add "Come..." back to the front of the last sentence, does that give us at least two words on the third line? Or alternatively, we could just say "Help us build the future of Expensify." |
I have tried adding back the |
I think they roughly communicate the same thing, but you could ping #espanol if you want to update it. I think it will be fine though. |
# Conflicts: # src/languages/en.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm with @shawnborton I think we might need to fix this line as well
Line 218 in dc4dd81
description: 'El nuevo aplicación Expensify está creado por una comunidad de desarrolladores de código abierto de todo el mundo. Ven y ayúdanos a construir la próxima generación de Expensify.', |
Looks good to me, thanks Clem! |
... No ... 🏃♂️ |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
@shawnborton & @bondydaa
Details
The text in the about page wasn't using our regular font size.
Fixed Issues
$ N/A
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android