Changed Personal and Company Address Labels #4636
Conversation
MelvinBot
requested review from
tylerkaraszewski
and removed request for
a team
|
I'm assuming @shawnborton will want a little bit more space between the input and the text, but anything else Shawn? |
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {..._.omit(field, ['label', 'fieldName'])} | ||
| /> | ||
| <Fragment> |
There was a problem hiding this comment.
Looks like the linter caught this, but you can just use <> instead for this
|
Can we use our hint text styles for the text that goes under the input? It should be at 13pt (in our fontSizeLabel var), in our colorMuted text color, and have a margin between the label and the input of 8px (or |
|
+1 to @shawnborton |
|
Updated the code and the screenshot in the description. Lemme know what you think @shawnborton |
|
Looks good! I like it aligned to the left, I think that is consistent with other places as well. The only thing I am curious about is perhaps we want to make the gap between input and hint just 4px, this way it looks more like the hint is tied to the input above it? Otherwise right now it kinda floats perfectly in between inputs and doesn't look quite visually connected to what's above. Thoughts on that? |
|
Yea I think it looks better with 4px 👍 |
|
Looks good to me, thanks Luke! All yours @Jag96 and @tylerkaraszewski |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Going to CP this to staging to check it off the deploy checklist |
…nal-address-labels Changed Personal and Company Address Labels (cherry picked from commit a9814af)
|
🚀 Cherry-picked to staging by @Jag96 in version: 1.0.85-9 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Details
Fixed Issues
$ #4631
Tests / Web QA
Connect Manually123123123for both fieldsTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
cc @MitchExpensify