Update height of default buttons to to match the text inputs

[kakajann]

Details

Update height of default buttons to to match the text inputs

Fixed Issues

Fixes: #4762

Tests

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[shawnborton]

Now that the buttons are taller, perhaps we can update the font size on the buttons to be 15px as well?

…

On Mon, Aug 23, 2021 at 10:50 PM Kakajann Dortguly ***@***.***> wrote: Details Update height of default buttons to to match the text inputs Fixed Issues Fixes: #4762 <#4762> Tests QA Steps Tested On - Web - Mobile Web - Desktop - iOS - Android Screenshots Web [image: Screen Shot 2021-08-24 at 1 26 59 AM] <https://user-images.githubusercontent.com/11542415/130516719-6fc059be-df6f-4985-a9b2-52d0f61cb871.png> Mobile Web [image: Screen Shot 2021-08-24 at 1 27 34 AM] <https://user-images.githubusercontent.com/11542415/130516846-5770ef28-8267-4b20-bfdd-7e4d0328fc90.png> Desktop [image: Screen Shot 2021-08-24 at 1 40 02 AM] <https://user-images.githubusercontent.com/11542415/130517051-b013eb4c-d2e7-4ddc-8c80-2e3955ab2dbf.png> iOS [image: Screen Shot 2021-08-24 at 1 37 56 AM] <https://user-images.githubusercontent.com/11542415/130517379-ffeecbf5-2162-4508-b701-dd488d0e297c.png> Android [image: Screenshot_20210824-014719_New Expensify] <https://user-images.githubusercontent.com/11542415/130517533-b00695be-38f0-4ecd-9924-a9d67240f14f.png> ------------------------------ You can view, comment on, or merge this pull request online at: #4792 Commit Summary - change button height File Changes - *M* src/styles/styles.js <https://github.com/Expensify/App/pull/4792/files#diff-8ab8ba45ab927f1430b8d1209d187e003a9cdfe476f809e4483ef64cdba253eb> (2) Patch Links: - https://github.com/Expensify/App/pull/4792.patch - https://github.com/Expensify/App/pull/4792.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4792>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARWH5WMR7OIK2PZGS63LUDT6KYBHANCNFSM5CVMR4DA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[Jag96]

This LGTM, going to also tag @shawnborton for design review since he filed the initial issue

[shawnborton]

Looks good to me. Can you just quickly check other areas of the app and make sure things look good? For example, like Settings (where we have Save buttons at the bottom of a view) or the "Pay" button in an IOU, etc.

[Jag96]

Tested around the app, looks good. Merging.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[isagoico]

Hello @kakajann Any QA tests needed for this PR?

[Jag96]

@isagoico I can check this one off on the spreadsheet, looks like its working 👍

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

[kakajann]

There is no regression I think