Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - No space between "New" and "Expensify" for the app name #4739

Closed
isagoico opened this issue Aug 18, 2021 · 14 comments
Closed

iOS - No space between "New" and "Expensify" for the app name #4739

isagoico opened this issue Aug 18, 2021 · 14 comments
Assignees

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue is failing #4408 for iOS.

Action Performed:

  1. Download latest build in iOS
  2. Check the app name

Expected Result:

App name should be "New Expensify"

Actual Result:

App name is "NewExpensify"

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.0.86-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Aug 18, 2021
@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added the Hourly KSv2 label Aug 18, 2021
@parasharrajat
Copy link
Member

Not sure why this is the case. Name is correctly update to this

PRODUCT_NAME = "New Expensify";

@parasharrajat
Copy link
Member

@Jag96 Could you please investigate it?

@luacmartins
Copy link
Contributor

@isagoico what device is being used for testing? It seems that iOS might be shrinking characters width based on screen size. Here's an example of the app name in iPhone 8 (top) vs iPhone 12 Pro Max (bottom):

Screen Shot 2021-08-18 at 5 00 43 PM
Screen Shot 2021-08-18 at 5 03 35 PM

@isagoico
Copy link
Author

Oh interesting 🤔 I was able to reproduce on a iPhone 6S which has a smaller screen too.

@luacmartins
Copy link
Contributor

I believe iPhone 6S has an even smaller screen than an iPhone 8 and thus why it looks like the space is not there. Not really sure what the fix is here.

@parasharrajat
Copy link
Member

parasharrajat commented Aug 19, 2021

I got a solution of some kind https://stackoverflow.com/questions/46337691/bundle-display-name-missing-space-characters.
we can use the non-breaking space   char and thus IOS can't shrink it.

@Julesssss
Copy link
Contributor

Julesssss commented Aug 19, 2021

If this is the default OS behavior then I don't think we should override it. If we did the OS might decide to remove characters elsewhere which could be even worse (removing from the end New Expensif)

I vote that we do nothing. Even if we do decide to, this shouldn't block the release, so I'm removing the label.

@Julesssss
Copy link
Contributor

Julesssss commented Aug 19, 2021

I wish Android did this instead of truncating the end of the String 😞

@Julesssss Julesssss added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 19, 2021
@parasharrajat
Copy link
Member

parasharrajat commented Aug 19, 2021

I think it won't be truncated @Julesssss as the character limit is 30 for the App name.

@Julesssss
Copy link
Contributor

It's good to know that we won't see truncation, but I still don't think we need to add a workaround to the default OS behavior. If the user has three apps in their launcher with the same length/word count it would be odd to have different spacing applied.

@sketchydroide
Copy link
Contributor

sketchydroide commented Aug 19, 2021

I agree with Jules on this, I think there is a soace there, it just that Apple made the spacing between letters smaller, you can really see that on the example @luacmartins gives. Not sure if this is actually a bug

@parasharrajat
Copy link
Member

We are good to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants