-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - No space between "New" and "Expensify" for the app name #4739
Comments
Triggered auto assignment to @sketchydroide ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Not sure why this is the case. Name is correctly update to this
|
@Jag96 Could you please investigate it? |
@isagoico what device is being used for testing? It seems that iOS might be shrinking characters width based on screen size. Here's an example of the app name in iPhone 8 (top) vs iPhone 12 Pro Max (bottom): |
Oh interesting 🤔 I was able to reproduce on a iPhone 6S which has a smaller screen too. |
I believe iPhone 6S has an even smaller screen than an iPhone 8 and thus why it looks like the space is not there. Not really sure what the fix is here. |
I got a solution of some kind https://stackoverflow.com/questions/46337691/bundle-display-name-missing-space-characters. |
If this is the default OS behavior then I don't think we should override it. If we did the OS might decide to remove characters elsewhere which could be even worse (removing from the end I vote that we do nothing. Even if we do decide to, this shouldn't block the release, so I'm removing the label. |
I wish Android did this instead of truncating the end of the String 😞 |
I think it won't be truncated @Julesssss as the character limit is 30 for the App name. |
It's good to know that we won't see truncation, but I still don't think we need to add a workaround to the default OS behavior. If the user has three apps in their launcher with the same length/word count it would be odd to have different spacing applied. |
I agree with Jules on this, I think there is a soace there, it just that Apple made the spacing between letters smaller, you can really see that on the example @luacmartins gives. Not sure if this is actually a bug |
We are good to close this. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue is failing #4408 for iOS.
Action Performed:
Expected Result:
App name should be "New Expensify"
Actual Result:
App name is "NewExpensify"
Platform:
Where is this issue occurring?
Version Number: 1.0.86-2
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: