[HOLD for payment 2021-12-15] $500 Chat Switcher - Draft message from previous conv is displayed after using chat switcher

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~01e5dccfcff059ed0f

---

Action Performed:

Please, see this comment for further investigation and reproduction steps. Some of the hints might helps us find what is exactly going wrong.

1. Navigate to a conversation
2. Write something in compose box
3. Use ctrl+k command
4. Select another conversation

Expected Result:

Nothing should be displayed in compose box if the selected conversation didn't have a draft

Actual Result:

The draft from the previous conversation is displayed on the current conversation.

Workaround:

For chats with people which they have already chatted with, they can use the LHN chat switcher and the drafts are not transferred. Also when user sends a message to someone or composes a draft which is then deleted, they wont experience this bug for the given chat.

When this will prevail is in case user creates chat with new person using the Ctrl + k chat switcher.

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.0.86-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.206.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

---

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1629393716037000

BUG: (tested on web, staging, probably deploy blocker): draft is not working properly. Steps:
Write something in the chat but don't send it
Switch to another chat using CMD+K shortcut
See that draft message is carried over to the chat you switched, when it should not

[MelvinBot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

The only PR which might be related to this and could introduced it is #4538 @marcaaron but I am not completely sure. What do you think? I can't really dig into this one right now. I would in the morning if noone identifies what is causing it 🙇 Thank you in any case for having a look.

[luacmartins]

It seems that with #4538 ReportActionCompose no longer mounts and the input ref is lost in the update.

[marcaaron]

Why is the input not mounting? Which ref are you referring to?

[luacmartins]

When the chat is switch using the search bar didComponentMount is not triggered for ReportActionCompose and this inputRef does not seem to update.

[marcaaron]

The ReportActionCompose component should be mounting only once now. Is there some reason it needs to be unmounted and remounted? I'm not seeing it yet...

[luacmartins]

I agree that it should be mounted only once and we should keep it that way. What seems to be causing this issue is that this.setInputRef is not providing the correct ref to TextInputFocusable. Both this.props.comment and defaultValue are correct when switching chats with the Search Page, so I'm not sure why the value is not updated.

[mountiny]

Thank you both for looking into this! Following from what you have found @luacmartins, I have identified that when using the SearchBar, the ReportActionCompose does need to update couple of time (after selecting different chat from the search) before it gets the report data of the new report.

In comparison, when using sidebar chat switcher, the components gets the correct props immediately after switching as it mounts.

I haven't been able to easily revert that PR either because it seems there were some additional ONYX changes made after it, which make the ReportActionsView not render correctly.

Therefore, I have tried to find some possibly temporary workaround, before @marcaaron might be able to look into how to update the refactoring to prevent this problem.

[mountiny]

PR is ready for a review, but it still needs to be tested on Mobile to make sure the workaround does not cause any problems.

[isagoico]

Retest for this in Web was a pass 🎉

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[mallenexpensify]

Regression? Looks like it's happening again https://expensify.slack.com/archives/C01GTK53T8Q/p1634576408421600

[isagoico]

This is only happening with Chronos conversation at the moment. Other conversations are working as expected

Action performed:

1. Navigate to Chronos conversation
2. Draft a message
3. Hit ctrl + K
4. Change to another chat

Recording.228.mp4

[laurenreidexpensify]

hired 👍🏽

[marcaaron]

Obviously, I will refactor the code in a good way. I have already improved the navigation earlier.

👀

[parasharrajat]

Those eyes are frightening. Sorry, I forgot to append with help of the team during review.

[mountiny]

PR is up and in a review so added the label. This might take a while as we would like to make sure the changes are conceptual.

[laurenreidexpensify]

@mountiny assume this is still in review?

[mountiny]

@laurenreidexpensify Correct!

[MonilBhavsar]

I'm coming from this related issue - #6490
Looking at the investigation and proposal, I believe this PR will also fix the linked issue.
Can anyone please confirm, thanks!

[parasharrajat]

Yeah, I just checked that #6490 is not reproducible on the PR.

[MonilBhavsar]

Thanks! 🙌

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@trjExpensify i'm OOO quite a bit over next week moving house, so handing this one off while I"m away thanks!

[trjExpensify]

Cool, sounds good. Looks like we're waiting for a prod deploy to start the timer. 👍

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.18-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: navigation to report screen from the SideModals #6207

If no regressions arise, payment will be issued on 2021-12-15. 🎊

[parasharrajat]

Ping for

@trjExpensify

FYI, this qualifies for Company offsite bonus.

[mallenexpensify]

Paid @parasharrajat , wanted to get it issued before the weekend!
Thanks for inc. the 'company offsite hold' bonus info, I forgot to add the label and details to some of issues that were in progress