[NO QA] Update the PR template to enforce issue linking formatting #4725
Conversation
mountiny
requested review from
mallenexpensify and
a team
and removed request for
aldo-expensify
|
@aldo-expensify Puller bear chose you, it is not specifically on Hold, but let's wait for @mallenexpensify to make sure the copy sounds right to him as well (we did not decide on exact form of the copy yet) |
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| <!--- | ||
| Please replace GH_LINK with the link to the GitHub issue this Pull Request is fixing. | ||
| Do NOT add the special GH keywords like `fixed` etc, we have our own process of managing the flow. | ||
| It MUST be an entire link to the issue, otherwise the linking will not work as expected. |
There was a problem hiding this comment.
I'm not 100% sure, but I think usually there is a comma after 'otherwise'. Grammarly suggest putting it like:
It MUST be an entire link to the issue; otherwise, the linking will not work as expected.
I also found this sentence online that looks similar in structure: The sick woman needs to be given treatment; otherwise, her illness will become fatal.
There was a problem hiding this comment.
@mallenexpensify Could we please get your 👀 on this copy. More eyes will know better.
There was a problem hiding this comment.
That looks good to me 👍
Co-authored-by: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com>
|
@yuwenmemon Sorry for the ping, that was some weird Pullerbear bug. |
|
@aldo-expensify Thank you for looking over it, gonna wait for @mallenexpensify for his opinion. We should move forward with this along with other changes mentioned here. |
|
Looks good to me @mountiny, commented above too |
|
@aldo-expensify I have updated it with your suggestions and it is ready for a final review 🎉 |
|
This PR is no longer on hold and can be reviewed/merged 🎉 |
|
I approved, but didn't merge in case @mallenexpensify wants to have a last look before. |
|
🚢 it! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Details
We are automating a process to update issues solved by contributors so we can keep track of when to pay them and what the regression period is better. However, it works only if contributors link the PRs to the issues in a manner we expect. We are updating the PR template to make it more clear.
See the linked issue for more context.
Additionally, I am removing
test.mdfile which I have introduced during testing webhook functionality for this issue https://github.com/Expensify/Expensify/issues/173928Fixed Issues
$ https://github.com/Expensify/Expensify/issues/174103
Tests
No tests needed
QA Steps
❌
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android