[HOLD for payment 2023-05-16] [$2000] Workspace - When adding a new member, add another screen to invite users #15083

kbecciv · 2023-02-12T03:16:52Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Access staging.new.expensify.com
Login with any account
Go to Settings -> Workspaces -> Open any workspace -> Manage members
Invite a new user -> Tap in search field

Expected Result:

User can see the list of his contacts without interference.

Actual Result:

When adding a new member to the workspace (using search), the user and search box is overlaid with keyboard. And also when scrolling up, the "Invite" button is hidden, which hides users from the list completely.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.70.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230211_164621_Chrome.mp4

Bug5934127_Screen_Recording_20230212_0043181_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182c8f1bfbd7b65ae
Upwork Job ID: 1625285025069547520
Last Price Increase: 2023-02-21

MelvinBot · 2023-02-12T03:16:57Z

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-02-12T03:17:00Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

MelvinBot · 2023-02-14T00:05:23Z

Job added to Upwork: https://www.upwork.com/jobs/~0182c8f1bfbd7b65ae

MelvinBot · 2023-02-14T00:05:28Z

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-02-14T00:05:38Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

MelvinBot · 2023-02-14T00:05:46Z

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

mallenexpensify · 2023-02-14T00:06:43Z

Guessing this can be external. I did a quick-check to see if this bug might be occurring in other places on the app but wasn't able to find.

priyeshshah11 · 2023-02-14T00:18:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The screen is covered by the the personal message view thus the user cannot see the input box where they are typing.

What is the root cause of that problem?

the root cause is using the flexShrink0 styling which is causing the personal message view to move up along with the keyboard.
https://github.com/priyeshshah11/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js#L336

What changes do you think we should make in order to solve the problem?

We should remove the flexShrink0 styling for the personal message view to not bump up along with the keyboard & instead stay in it's position when the search box is focused.

hellohublot · 2023-02-14T07:39:23Z

Proposal

When the height of the screen is small and the height of the keyboard is large, the pop-up invitation message input box will cover the above search box

We'd better move this invitation message input box to another new page WorkspaceInviteMessagePage

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 263 to 274 in e31cb53

    
           inviteUser() { 
        
               if (!this.validate()) { 
        
                   return; 
        
               } 
        
               this.setState({shouldDisableButton: true}, () => { 
        
                   const logins = _.map(this.state.selectedOptions, option => option.login); 
        
                   const filteredLogins = _.uniq(_.compact(_.map(logins, login => login.toLowerCase().trim()))); 
        
                   Policy.addMembersToWorkspace(filteredLogins, this.state.welcomeNote || this.getWelcomeNote(), this.props.route.params.policyID); 
        
                   Navigation.goBack(); 
        
               }); 
        
           }

inviteUser() {
    ...
    this.setState({shouldDisableButton: true}, () => {
        const logins = _.map(this.state.selectedOptions, option => option.login);
        const filteredLogins = _.uniq(_.compact(_.map(logins, login => login.toLowerCase().trim())));
-       Policy.addMembersToWorkspace(filteredLogins, this.state.welcomeNote || this.getWelcomeNote(), this.props.route.params.policyID);
-       Navigation.goBack();
+       Navigation.navigate(ROUTES.getWorkspaceInviteMessageRoute(this.props.route.params.policyID, filteredLogins))
    });
 }

class WorkspaceInviteMessagePage extends React.Component {

    render() {
        return (
            ...
           <TextInput
		    label={this.props.translate('workspace.invite.personalMessagePrompt')}
		    autoCompleteType="off"
		    autoCorrect={false}
		    numberOfLines={4}
		    textAlignVertical="top"
		    multiline
		    containerStyles={[styles.workspaceInviteWelcome]}
		    value={this.state.welcomeNote}
		    onChangeText={text => this.setState({welcomeNote: text})}
		/>
            ...
        );
    }
}

_1.mp4

Waiting for your suggestions

MelvinBot · 2023-02-14T07:39:25Z

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

abdulrahuman5196 · 2023-02-14T08:27:44Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When keyboard is open on the new member invite page, the user list and search box is partially hidden.

What is the root cause of that problem?

We show invite button component, privacy message component, invite message component above the keyboard on user searching the user list. As keyboard takes considerable amount of screen space and other components mentioned above also takes considerable screens space, we are end up with only limited screen space to show the search and list component.

What changes do you think we should make in order to solve the problem?

There are multiple ways to solve this.

We can reduce the number of components we show above keyboard on search. For example we can move the invite message component from the showing above the keyboard by removing the component here and adding it next to the options list selector - https://github.com/priyeshshah11/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js#L337
We don't show any component above the keyboard
we can reduce the sizes of components which we show above the keyboard.

@mallenexpensify But regardless of any option, we would require answer from design team to let us know what is the expected behaviour and what components to show. I can make the required changes from the design team as well.

Optional:
We can make these changes only for small screen devices by check the screen size. Because for bigger screens we won't have these issues.

What alternative solutions did you explore? (Optional)

None

mallenexpensify · 2023-02-14T22:19:56Z

@mollfpr can you please review the above proposals?

But regardless of any option, we would require answer from design team to let us know what is the expected behaviour and what components to show.

@abdulrahuman5196, correct, thanks for pointing out. I was able to reproduce but didn't think of how we should show. I wonder if we should just minimize this area, possibly removing some/most of the text? (sorry, I have a weird issue where Github doesn't allow me to post images)
https://www.screencast.com/t/Qx38wyZu5JPs

mollfpr · 2023-02-15T01:30:19Z

Reviewing proposals now!

mollfpr · 2023-02-15T11:18:31Z

@priyeshshah11 I try your solution, but it's not working.

@abdulrahuman5196 Could you provide the screenshot for your suggestion before we ask for the design team's opinion?

priyeshshah11 · 2023-02-15T11:32:55Z

Thanks @mollfpr, my bad I don't know why it worked for me then but it's not working now.

priyeshshah11 · 2023-02-15T11:35:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The screen is covered by the the personal message view thus the user cannot see the input box where they are typing.

What is the root cause of that problem?

the root cause is that the list height shrinks which is causing the personal message view to move up along with the keyboard & cover the search & list.

What changes do you think we should make in order to solve the problem?

We should give the view around the optionsSelector a min height to fix the message box overlapping issue (Tested it properly this time, haha)

@mollfpr

mollfpr · 2023-02-15T11:36:28Z

@priyeshshah11 Could you share the screenshot of the result?

priyeshshah11 · 2023-02-15T11:38:18Z

@priyeshshah11 Could you share the screenshot of the result?

@mollfpr Screenshot for above proposal

mollfpr · 2023-02-15T11:41:03Z

Sorry @priyeshshah11 on second thought will be helpful if you can record it with focus the search input and focus on the message input 😅

priyeshshah11 · 2023-02-15T11:44:10Z

@mollfpr There you go

RPReplay_Final1676461339.mov

mallenexpensify · 2023-05-01T16:41:49Z

Possible merge conflict with PR, being worked on #15672 (comment)

melvin-bot · 2023-05-08T20:08:06Z

@mallenexpensify, @mollfpr, @thienlnam, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

abdulrahuman5196 · 2023-05-08T20:17:22Z

Not overdue. PR is pushed and in staging. Waiting for prod deployment, assuming it should happen sooner, since it has been couple of days in staging.

melvin-bot · 2023-05-09T03:35:50Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-05-09T03:35:51Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Implement Invite message page #15672

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-09T03:35:52Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr / @abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr / @abdulrahuman5196] Determine if we should create a regression test for this bug.
[@mollfpr / @abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/286287

abdulrahuman5196 · 2023-05-15T11:51:32Z

Hi team, I think it would be fair to re-evaluate the compensation for this feature request issue. Since we had to do more stretch to get this feature request into going. On high level, This involved refractor of MultipleAvatars component from hard coded values to generic implementation which made the component much scalable for future usecases, minor refractors on Form component as well, and the creation of new page itself and further polishes and followups which took month's effort to get the feature rolling.
cc: @mallenexpensify @mollfpr @thienlnam @luacmartins

PR reference - #15672

luacmartins · 2023-05-15T14:30:56Z

@abdulrahuman5196 what amount do you think is fair?

abdulrahuman5196 · 2023-05-15T14:47:43Z

@luacmartins Hi, I am fine with any amount team thinks is fair for this. I don't have any specific request. I just felt we could re-evaluate based on the complexity involved.

mollfpr · 2023-05-15T16:31:23Z

[@mollfpr / @abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Since this isn't an issue rather than a feature request and improvement, no offending PR and checklist should be added.

[@mollfpr / @abdulrahuman5196] Determine if we should create a regression test for this bug.

We should update the current test case for invite members. I'll propose the regression step.

mollfpr · 2023-05-16T14:11:33Z

Update for Manage Members - Invite TC

Navigate back to Workspace editor
Click on Manage Members
Verify your account is the only one in the list
Verify there are 2 buttons to invite or remove members
Verify the remove button is disabled if no members are selected
Verify there’s a checkbox to Select all
Click on the Next button
Verify that a search is displayed
Search for a user that you have access to and has an avatar set up
Select the user
Verify a green tick is displayed on the right side
Verify the search is cleared after selecting the user
Verify that bottom docked there is a text box with a invite message you can edit
Click on the Next button
Remove the default message from the text box
Click on the Invite button
Verify that the new Workspace member is displayed on the members list
Verify the that the user avatar loads for the new member in the member list
Verify that an email invite is received in the secondary user email inbox
Verify that the email invite doesn't include the invite message since it was deleted
Invite several more members include at least 1 account you have access to, the rest can be made up emails
Include this message in the invite text box "Testing the invite message & more"
Verify that it displays the selected member avatars
Reload the page
Verify that the members selected before remains the same and the input message is back to default
Click on the Invite button
Verify that the email invite includes the invite message and that is correctly rendered

I also think we need to update Manage Members - Invite - Error test (Online/Offline) TC too, but I haven't got the time to add it.

abdulrahuman5196 · 2023-05-18T19:57:36Z

Hi team, When you are available, could you kindly check on this request?

#15083 (comment)
#15083 (comment)

cc: @mallenexpensify

mallenexpensify · 2023-05-22T18:57:12Z

refractor of MultipleAvatars component from hard coded values to generic implementation which made the component much scalable for future usecases, minor refractors on Form component as well, and the creation of new page itself and further polishes

Apologies for the delay @abdulrahuman5196. I'm not the most well-versed on the technical details. it's often best/easiest when you propose the amount then we can 👍, 👎 or propose another amount. The expected behavior was

User can see the list of his contacts without interference.

It sounds like the amount of work that went into achieving that behavior required a lot more work than just a single bug fix. Based on the $2000 job amount, what percentage of additional work, outside of the single bug fix, do you think was necessary to get the PR deployed to production? Generally we default to 25, 50 and 100% when considering payment amounts.

abdulrahuman5196 · 2023-05-22T19:17:31Z

Thank you for response @mallenexpensify. I think 50% or 100% should be good in this case(Since time bonus is also not possible on this fix).
Anyways I will be comfortable with team's decision.

🎉 for 100%
👍 for 50% (this is equal to time bonus)
👎 for current compensation (no change)

@luacmartins @thienlnam @mollfpr Kindly update your preference / thoughts

luacmartins · 2023-05-23T14:57:43Z

@mallenexpensify I think that a 50% bonus seems fair in this case.

abdulrahuman5196 · 2023-05-23T16:12:50Z

@mallenexpensify As the team is agreeing on 50% bonus as a fair update in this case.
I am fine with the team's decision as well. Kindly do the needful.

cc: @luacmartins

mallenexpensify · 2023-05-24T01:05:17Z

Thanks all. @abdulrahuman5196 @mollfpr , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01478651038f1ade96

Reminder to add the $1000, 50% when paying :)

mollfpr · 2023-05-24T01:06:39Z

@mallenexpensify Accepted, thank you!

abdulrahuman5196 · 2023-05-24T03:05:30Z

@mallenexpensify accepted the invite.

mallenexpensify · 2023-05-25T02:01:27Z

Paid @mollfpr and @abdulrahuman5196 , thanks!

TC GH created!
https://github.com/Expensify/Expensify/issues/286287

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 12, 2023

melvin-bot bot assigned mallenexpensify Feb 12, 2023

melvin-bot bot locked and limited conversation to collaborators Feb 12, 2023

mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 14, 2023

melvin-bot bot unlocked this conversation Feb 14, 2023

melvin-bot bot changed the title ~~Workspace - When adding a new member, the user and search box is overlaid with keyboard~~ [$1000] Workspace - When adding a new member, the user and search box is overlaid with keyboard Feb 14, 2023

melvin-bot bot assigned mollfpr Feb 14, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2023

melvin-bot bot assigned thienlnam Feb 14, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 9, 2023

melvin-bot bot changed the title ~~[$2000] Workspace - When adding a new member, add another screen to invite users~~ [HOLD for payment 2023-05-16] [$2000] Workspace - When adding a new member, add another screen to invite users May 9, 2023

melvin-bot bot removed the Reviewing Has a PR in review label May 9, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2023

melvin-bot bot added the Overdue label May 22, 2023

melvin-bot bot removed the Overdue label May 22, 2023

mallenexpensify closed this as completed May 25, 2023

[HOLD for payment 2023-05-16] [$2000] Workspace - When adding a new member, add another screen to invite users #15083

[HOLD for payment 2023-05-16] [$2000] Workspace - When adding a new member, add another screen to invite users #15083

Comments

kbecciv commented Feb 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Feb 12, 2023

MelvinBot commented Feb 12, 2023 • edited by mallenexpensify Loading

Bug0 Triage Checklist (Main S/O)

MelvinBot commented Feb 14, 2023

MelvinBot commented Feb 14, 2023

MelvinBot commented Feb 14, 2023

MelvinBot commented Feb 14, 2023

mallenexpensify commented Feb 14, 2023

priyeshshah11 commented Feb 14, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

hellohublot commented Feb 14, 2023

Proposal

MelvinBot commented Feb 14, 2023

abdulrahuman5196 commented Feb 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

mallenexpensify commented Feb 14, 2023

mollfpr commented Feb 15, 2023

mollfpr commented Feb 15, 2023

priyeshshah11 commented Feb 15, 2023

priyeshshah11 commented Feb 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mollfpr commented Feb 15, 2023

priyeshshah11 commented Feb 15, 2023

mollfpr commented Feb 15, 2023

priyeshshah11 commented Feb 15, 2023

mallenexpensify commented May 1, 2023

melvin-bot bot commented May 8, 2023

abdulrahuman5196 commented May 8, 2023 • edited Loading

melvin-bot bot commented May 9, 2023

melvin-bot bot commented May 9, 2023 • edited by mallenexpensify Loading

melvin-bot bot commented May 9, 2023 • edited by mallenexpensify Loading

abdulrahuman5196 commented May 15, 2023

luacmartins commented May 15, 2023

abdulrahuman5196 commented May 15, 2023 • edited Loading

mollfpr commented May 15, 2023

mollfpr commented May 16, 2023

abdulrahuman5196 commented May 18, 2023

mallenexpensify commented May 22, 2023

abdulrahuman5196 commented May 22, 2023 • edited Loading

luacmartins commented May 23, 2023

abdulrahuman5196 commented May 23, 2023

mallenexpensify commented May 24, 2023

mollfpr commented May 24, 2023

abdulrahuman5196 commented May 24, 2023

mallenexpensify commented May 25, 2023

kbecciv commented Feb 12, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Feb 12, 2023 •

edited by mallenexpensify

Loading

priyeshshah11 commented Feb 14, 2023 •

edited

Loading

priyeshshah11 commented Feb 15, 2023 •

edited

Loading

abdulrahuman5196 commented May 8, 2023 •

edited

Loading

melvin-bot bot commented May 9, 2023 •

edited by mallenexpensify

Loading

melvin-bot bot commented May 9, 2023 •

edited by mallenexpensify

Loading

abdulrahuman5196 commented May 15, 2023 •

edited

Loading

abdulrahuman5196 commented May 22, 2023 •

edited

Loading