[HOLD for payment 2023-06-02] [$4000] mWeb - Chat - Reopening Edit option highlights the Delete option in a blue frame

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Open any chat
3. Navigate a conversation in the main testing device.
4. Click/Tap on the Pencil icon to activate the edit message box
5. Click/tap the pencil icon a second time and another message

Expected Result:

Reopening Edit option doesn't highlight the Delete option in a blue frame

Actual Result:

Reopening Edit option highlights the Delete option in a blue frame

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.71.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5936239_13.02.23_mWeb.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010232701a6fcbf3be
• Upwork Job ID: 1628557608611717120
• Last Price Increase: 2023-03-21

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[hayata-suenaga]

I was able to reproduce the issue. I'll assign myself to this issue. @adelekennedy I'd appreciate if you could double check it by completing the triage checklist.

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hayata-suenaga]

I'm removing @madmax330 as I assigned myself to this issue.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010232701a6fcbf3be

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[hayata-suenaga]

I'm still working on this issue.

[MelvinBot]

@parasharrajat @adelekennedy @hayata-suenaga this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[s77rt]

Sorry I forgot I was assigned. @parasharrajat is the C+ here.

[puneetlath]

I don't think there's anything for me to do here @arielgreen so I'm going to un-assign myself and let you handle when you're back.

[ntdiary]

Hi, are we close to complete? Or what else I can do? 🙂
cc @parasharrajat @hayata-suenaga @arielgreen

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: This was an unknown bug and Logic added in #3434 unintentionally caused it. It partially depends on the Safari browser as well.

[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/3434/files#r1214939555

[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This comes down to catching Safari issues https://expensify.slack.com/archives/C049HHMV9SM/p1685747353972299

[@parasharrajat] Determine if we should create a regression test for this bug. Yes

[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #15105 (comment)

[parasharrajat]

Regression Test Steps

1. Open a chat that has multiple messages in history on mobile-web(Chrome and Safari).
2. Long press a sent message, then select the Edit option.
3. While the editor is focused on a previously edited message, the Long press another sent message.
4. Check that the highlighting blue frame doesn't appear on the Delete option or backdrop or any other option on the context menu (Popup menu on mobile).

Do you agree 👍 or 👎 ?

[hayata-suenaga]

@parasharrajat do we have to mention to test this regression specifically on Safari?

[parasharrajat]

No. But safari should be part of it.

[hayata-suenaga]

are we waiting for deployment?

[ntdiary]

are we waiting for deployment?

@hayata-suenaga, It seems that this has been deployed, what else needs to be done is to fill the checklist, then we can get the payment done and close the issue?

[ntdiary]

@arielgreen, gentle bump, it seems there is one last item left to complete on the checklist. : )

[arielgreen]

Calculating payments:
5/18 - issue assigned to @ntdiary
5/24 - PR merged

4 business days = 0% bonus/penalty

$4000 to @ntdiary
$4000 to @parasharrajat

[arielgreen]

Offers sent

[melvin-bot]

@ntdiary, @parasharrajat, @arielgreen, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ntdiary]

Accepted. : )

[ntdiary]

@hayata-suenaga , hi, it seems that @arielgreen is ooo? 😂

[arielgreen]

Payments, issued, this is complete.