[HOLD for payment 2023-03-09] Scroll position does not reset when searching for an emoji

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report.
2. Open the emoji menu.
3. Scroll to the bottom.
4. Enter something in the search bar.

Expected Result:

The scroll position should reset and the results should show from the top

Actual Result:

Even after searching, the scroll position remains somewhere in the middle

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari

Version Number: 1.2.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-21.at.5.03.15.AM.mov

Recording.1572.mp4

Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1676937817159209
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ea1211f38f9ef5c
• Upwork Job ID: 1629230103967375360
• Last Price Increase: 2023-02-24

[MelvinBot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[JmillsExpensify]

Going to take this one and add it to the tracking issue.

[JmillsExpensify]

Ok coming back to this one. It's a pretty subtle one, but I can see the argument that yes, the scroll position should reset the top – especially because take this set of reproduction steps:

1. Open the emoji menu.
2. Scroll to the bottom.
3. Enter "A" in the search bar

In this scenario 🅰️ is correctly searched, but it's out of view farther up in the scroll view.

[JmillsExpensify]

@stitesExpensify Curious for your thoughts on this one?

[stitesExpensify]

Yeah, this is a bug. It's a 1 line fix, so I'll take care of it real quick.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015ea1211f38f9ef5c

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.77-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Set offset to 0 when filtering emojis #15494

If no regressions arise, payment will be issued on 2023-03-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Propose regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

@thesahindia Upwork job is here for you to apply. Thank you!

[allroundexperts]

@JmillsExpensify Do I get the reporting bonus here?

[JmillsExpensify]

Actually, let me make sure I'm thorough. Payouts are as follows:

• External issue reporter: @allroundexperts $250
• Contributor+: @thesahindia $1,000

Please apply both, thanks!

[thesahindia]

Applied, thanks!

[allroundexperts]

Applied as well. Thanks!

[MelvinBot]

@JmillsExpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@JmillsExpensify, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

@JmillsExpensify, @thesahindia Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

@JmillsExpensify, @thesahindia 12 days overdue. Walking. Toward. The. Light...

[JmillsExpensify]

Apologies guys! More travel on my side. I've just extended contracts to both. Please let me know when you've accepted and I'll issue payment in short order.

[MelvinBot]

@JmillsExpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

Sorry for the delay. It appears that the previous offer has expired. Would you mind sending me a new one, please?

[MelvinBot]

@JmillsExpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stitesExpensify]

@JmillsExpensify looks like we need to send another upwork contract here

[Pujan92]

@stitesExpensify not sure whether this suggestion deserves any compensation or not but just pointing out. 😅

[MelvinBot]

@JmillsExpensify, @thesahindia Still overdue 6 days?! Let's take care of this!

[JmillsExpensify]

I've issued payment to @allroundexperts and sent a new offer to @thesahindia.

@Pujan92 Thanks for being a part of the community, though at this point we're going to continue with the payments as stipulated here.

[MelvinBot]

@JmillsExpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

@JmillsExpensify, I have accepted the offer.

[JmillsExpensify]

All paid out and settled up. We're done here, thank you!