[HOLD for payment 2023-03-23] [$1000] Inconsistency while selecting dropdown in mWeb and Android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app in Android
2. Navigate to Settings > Workspaces > Select any workspace
3. Reimburse expenses
4. Click on Unit Input
5. Do the exact same steps for mWeb
6. Notice that the dropdown input's border gets green when focused in mWeb but in Android this only happens when we click on the input

Expected Result:

Behavior should be consistent.

Actual Result:

The behavior of the field isn't consistent

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.76-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

dropdown-test.mp4

az_recorder_20230227_083804.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677253047142869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c6b32476cf961bc
• Upwork Job ID: 1631088899411161088
• Last Price Increase: 2023-03-02

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[arielgreen]

Reproducible.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010c6b32476cf961bc

[MelvinBot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

Same issue here.

[redstar504]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Picker component on mobile web and mobile native shows inconsistent behavior in displaying the green bottom border indicator.

What is the root cause of that problem?

The isOpen state of the Picker component changes the border color, but the events that trigger the state change are different for mobile web and mobile native. The onClose event only supports mobile native, whereas the implemented events that apply to mobile web are onFocus and onBlur. Since picking an item does not blur the Picker element, the border does not change back to its original color.

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to add additional events to the Picker component to achieve the intended behavior on mobile web. We can disable the green border when a picker item is selected by adding additional logic for changing the isOpen state through onValueChange and onClick events. After manipulating the state using these events, the indicator functions as expected on mobile web:

android_chrome.mp4

As demonstrated above:

onClick -> setState({isOpen: true})
onValueChange -> setState({isOpen: false})

What alternative solutions did you explore? (Optional)

Another option might be to blur the picker in onValueChange. To achieve this we would have to use a ref since onValueChange does not emit an event. The implementation of the Picker is different on each platform (ie. Android uses a TextInput and Web uses a <select> element, so we would have to be sure to blur the right target.

[thesahindia]

The solution sounds good to me!

C+ reviewed 🎀👀🎀

cc: @marcaaron

[marcaaron]

Ah, is it me or is it debatable which behavior is correct? The proposal sounds good though I am unsure which is the preferred direction to go here.

Would making a selection not return the focus to the field itself? Can native match the behavior that mobile web has?

Curious to get @shawnborton's take here. I think we can hire @redstar504 for this one. Though - I would like to get some consensus on the correct behavior first if we can.

[MelvinBot]

📣 @redstar504 You have been assigned to this job by @marcaaron!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[redstar504]

@marcaaron Thank you. I debated that as well when digging into this. The existing logic seemed to lean towards changing the colour back when the picker is closed. I am not sure it provides much benefit to the user to keep the field highlighted after they have chosen an option and moved on.

[shawnborton]

Yeah, this is an interesting one. I think I agree with @redstar504's proposal though to remove the "focus" feeling after something is picked.

[marcaaron]

Ok cool sounds good to me. Let's go with the O.G. proposal. Thanks all.

[arielgreen]

@thesahindia @daraksha-dk @redstar504

offers sent in Upwork

[MelvinBot]

@redstar504, @marcaaron, @arielgreen, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcaaron]

Solution is on staging now - just waiting for it to hit production.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.85-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add additional events for controlling picker indicator on web #15673

If no regressions arise, payment will be issued on 2023-03-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @daraksha-dk
• Contributor that fixed the issue @redstar504
• Contributor+ that helped on the issue and/or PR @thesahindia

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• @arielgreen Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[arielgreen]

Calculating bonus:
2/2/23 - contributor assigned to issue
2/15/23 - PR merged - 9 business days - no bonus/no penalty

$250 to @daraksha-dk
$1000 to @redstar504
$1000 to @thesahindia

Issuing payments now

[arielgreen]

@marcaaron @thesahindia please see and complete checklist

[thesahindia]

It wasn't a regression so we can skip the first three items.

Let's just add the regression steps

Regression test proposal

1. Go to setting > Workspaces
2. Select any workspace > General settings
3. Open the currency selector > Select a different value
4. Verify the picker is not highlighted after it gets closed

[marcaaron]

It wasn't a regression so we can skip the first three items.

👍

[arielgreen]

Excellent, we are good to close then.