Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in - No welcome screen with magic code is displayed #15593

Closed
6 tasks done
kbecciv opened this issue Mar 1, 2023 · 11 comments
Closed
6 tasks done

Log in - No welcome screen with magic code is displayed #15593

kbecciv opened this issue Mar 1, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Mar 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15351

Action Performed:

  1. Sign out
  2. Sign in using an SMS number Or sign up with a new phone account

Expected Result:

Welcome screen with magic code is displayed

Actual Result:

No welcome screen with magic code is displayed

Workaround:

Unkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.77.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5957759_Recording__178.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 1, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 1, 2023
@MelvinBot
Copy link

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MelvinBot
Copy link

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@slafortune
Copy link
Contributor

@aldo-expensify @Julesssss how does this affect the payout on Fix miss-matched SMS email suffix on sign in page #15351?

Should this be an internal fix?

@Julesssss
Copy link
Contributor

how does this affect the payout on #15351?

Hey @slafortune, right now I don't believe this is a regression from that linked issue. This is probably an internal issue though

@neil-marcellini
Copy link
Contributor

I'm confirming in Slack if this is an actual issue or if we can update the test steps while the feature is in beta.

@slafortune
Copy link
Contributor

Great - thanks @Julesssss and @neil-marcellini

@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2023
@neil-marcellini
Copy link
Contributor

I asked in Slack again. I'm leaning towards closing this.

@melvin-bot melvin-bot bot removed the Overdue label Mar 6, 2023
@Julesssss
Copy link
Contributor

Oh sorry, I missed the Slack thread. I think it's probably best to ask in the #vip-passwordless channel, as they will have the most knowledge here.

@neil-marcellini
Copy link
Contributor

Ok sounds good, I asked here.

@neil-marcellini
Copy link
Contributor

Passwordless only works if the login (the phone number) is on the beta, so this is not a problem.

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants