Deploy Checklist: New Expensify 2023-02-27

[OSBotify]

Release Version: 1.2.77-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix menu item padding #14855
• Keyboard is visible for a brief moment on request/send money page after getting back from currency search page #15205
• replace onModalHide with onDismiss for the web #15298
• fix: updated dob check logic #15316
• Do not parse the markdown when editing a message if the message is too long #15320
• Make sure closed accounts don't show in workspace members #15324
• Remove in-app password requirement for passwordless users #15338
• Fix miss-matched SMS email suffix on sign in page #15351
• Disable the focus trap for report page context menu #15375
• Make bold/italic/strikethrough work with multi-line emails #15393
• allow option row to have multiple lines of alternate text #15400
• Hide room from LHN if user does not have the permission #15401
• Hide emoji category picker while searching #15402
• Create TestRail_Navigation_C+.md #15405
• close modal when opening new page using keyboard shortcut #15413
• correct the emoji list for Windows OS and categories updation #15416
• fix image attachment infinite loading #15472
• Android/IOS app does not focus on date of birth field when 'fix the errors' link is clicked #15473
• Set offset to 0 when filtering emojis #15494
• Revert "replace onModalHide with onDismiss for the web" #15495
• Revert "Revert "replace onModalHide with onDismiss for the web"" #15498
• reset drawerIsReady promise when BaseDrawerNavigator unmounts #15500
• Revert "replace onModalHide with onDismiss for the web" #15563
• Decode transaction messages because they may have HTML Entities #15578

Deploy Blockers:

• [HOLD for payment 2023-03-13] [HOLD for payment 2023-03-09] mWeb/Safari - Unable to open the Add attachment option #15559
• mWeb/Safari - Unable to upload a photo to Profile #15564
• [HOLD for payment 2023-03-13] [HOLD for payment 2023-03-09] IOU details - " " html tag is visible near currency abbreviation in IOU details #15576

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

[mvtglobally]

@yuwenmemon IOS and Desktop builds are not available. Can you pls check if there is an issue with Apple on v1.2.77-1?

[yuwenmemon]

@mvtglobally Newest version is 1.2.77-3 and it looks like it was successful when deploying.

[mvtglobally]

@yuwenmemon Yes, we just got it and proceeding with the validations

[yuwenmemon]

Thanks!

…

On Feb 28, 2023, at 1:33 PM, Maria Ajmera ***@***.***> wrote: @yuwenmemon <https://github.com/yuwenmemon> Yes, we just got it and proceeding with the validations — Reply to this email directly, view it on GitHub <#15521 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEFWC22OW4AI4CINXW24BTWZZVMFANCNFSM6AAAAAAVJ56CJQ>. You are receiving this because you were mentioned.

[mvtglobally]

@yuwenmemon Can you pls assist with the PR
#15298. I am really lost on the latest on it.
It has been reverted > #15495
then reverted revert > #15498
and then reverted again :) #15563
Can we just check off 15298, 15495, 15498 and test the 15563 only?

[yuwenmemon]

Can we just check off 15298, 15495, 15498 and test the 15563 only?

Yes 😄

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.77-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.77-4 has been deployed to staging 🎉

[yuwenmemon]

@mvtglobally What's the latest with the checklist progress?

[mvtglobally]

@yuwenmemon Regression is completed

#15338 is failing due to #12913
#15351 is failing due to #15593
#15393 is failing #15561. Repro in PROD checking of
#15500 is pass on Web and mWeb, and doesn't look to be implemented on other platforms. OK to check it off?

[yuwenmemon]

#15500 is pass on Web and mWeb, and doesn't look to be implemented on other platforms. OK to check it off?

yeah that's the only spot where it's an issue.

[yuwenmemon]

#15351 is failing due to

failing due to what? 😅

[yuwenmemon]

#15338 is failing due to #12913

@mvtglobally Forgive me but I fail to see how the linked issue is related?

[mvtglobally]

Checking off #15338 https://expensify.slack.com/archives/C9YU7BX5M/p1677711279446569?thread_ts=1677701556.478449&channel=C9YU7BX5M&message_ts=1677711279.446569

[yuwenmemon]