-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove in-app password requirement for passwordless users #15338
Conversation
@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeHaving a helluva time getting my local dev working properly. In the interest of time (bigger fish to fry) going to go ahead and skip this, but am confident based on the tests performed on other platforms. Mobile Web - SafariHaving a helluva time getting my local dev working properly. In the interest of time (bigger fish to fry) going to go ahead and skip this, but am confident based on the tests performed on other platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Don't see how that could be the case, maybe this needs the latest changes from |
Yeah agreed, this doesn't seem like it would've introduced anything like that for the search page 🤔 |
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.2.77-0 🚀
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.2.77-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.77-4 🚀
|
Details
Conditionally removes the password requirement for for in app actions when the user is on the passwordless beta.
Fixed Issues
$ (https://github.com/Expensify/Expensify/issues/261738
PROPOSAL: N/A internal
Tests
Debit Card
Expensify Password
in the debit card form4242424242424242
Default Payment
Make default payment method
in the resulting pop upSecondary Login
Enter your preferred phone number to send a validation link
(orEnter your preferred email to send a validation link
and that there is no password promptOffline tests
No change to current behavior
QA Steps
Debit Card
Expensify Password
in the debit card form4242424242424242
Default Payment
Make default payment method
in the resulting pop upSecondary Login
Enter your preferred phone number to send a validation link
(orEnter your preferred email to send a validation link
and that there is no password promptPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Debit Card
web-debit-card.mov
Default Payment
web-default-payment.mov
Secondary Login
web-secondary-login.mov
Mobile Web - Chrome
Debit Card
chrome-debit-card.mov
Default Payment Method
chrome-default-payment.mov
Secondary Login
chrome-secondary-login.mov
Mobile Web - Safari
Debit Card
safari-debit-card.mp4
Default Payment Method
safari-default-payment.mp4
Secondary Login
safari-secondary-login.mp4
Desktop
Debit Card
desktop-debit-card.mov
Default Payment Method
desktop-default-payment-option.mov
Secondary Login
desktop-secondary-login.mov
iOS
Debit Card
ios-debit-card.mp4
Default Payment Method
ios-default-payment.mp4
Secondary Login
ios-secondary-login.mp4
Android
Debit Card
android-debit-card.mov
Default Payment Method
android-default-payment.mov
Secondary Login
android-secondary-login.mov