Hide emoji category picker while searching

[bernhardoj]

Details

1. Hide the emoji category picker while searching because the filtered emojis is not categorized.
2. Put category picker below search field

Fixed Issues

$ #15132
PROPOSAL: #15132 (comment)

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Only for large screen web/desktop

1. Open any chat
2. Open emoji picker
3. Type anything in the search field
4. Verify the emoji category picker is hidden
5. Clear the search field
6. Verify the emoji category picker is visible

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-02-22.at.21.11.38.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-02-22.at.20.56.22.mov

iOS

Android

[MelvinBot]

@stitesExpensify @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[bernhardoj]

There is no search field on mWeb/native, so I just provide a screenshot to make sure it stays the same.

[stitesExpensify]

@shawnborton do we need more padding at the top of the search input here? Or are we good to go?

2023-02-24_08-00-23.mp4

[shawnborton]

Could you show it to me with an extra 4px on top and an extra 8px on top so we can compare?

Thanks!

[stitesExpensify]

Current:

4px:

8px:

[shawnborton]

Awesome, thank you! I think 8px is the winner for me, what do you think?

[bernhardoj]

That looks better. I have added the padding.

[stitesExpensify]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-02-24_08-00-23.mp4

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

2023-02-24_08-05-48.mp4

iOS

N/A

Android

N/A

[stitesExpensify]

LGTM!

[stitesExpensify]

Can't merge this because Jest Unit Tests job 3 isn't finishing currently. Once we get it fixed, I'll merge

[mananjadhav]

@stitesExpensify Quick question, if I press the down arrow key from Search it directly jumps to the Frequently Used Emojis set (or the first category of the emojis), instead of the Emojis Category. But I also see we don't have any navigation enabled on CategoryShortcutBar. Do we want to add that to this scope?

[mananjadhav]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-emoji-hide-category-bar.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop-emoji-hide-category-bar.mov

iOS

Android

---

I've approved the PR because the arrow navigation isn't a part of the scope we decided earlier and that @stitesExpensify has approved it already. But I would still wait to get it clarified before merging. I am left with iOS screenshot but having some issues with my build.

[bernhardoj]

We already have the arrow navigation reported here https://expensify.slack.com/archives/C049HHMV9SM/p1676484613354519?thread_ts=1676484613.354519&cid=C049HHMV9SM, but looks like it is on hold.

[stitesExpensify]

I don't think that we need to account for navigation at this time.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
Open Search Page TTI	602.708 ms → 663.903 ms (+61.195 ms, +10.2%) 🔴

Show details

Name

Duration

Open Search Page TTI

Baseline Mean: 602.708 ms Stdev: 16.124 ms (2.7%) Runs: 569.8566490039229 571.2626959979534 572.7418619990349 578.0585540011525 583.3645019978285 586.3632410019636 591.8474529981613 593.8544520065188 595.8925790041685 596.4617109969258 596.8373619988561 599.15625 600.1795249953866 601.1696369946003 601.6746830046177 602.0603029951453 602.8688969984651 604.041544996202 606.9158130064607 607.2123619988561 610.1569420024753 611.6625159978867 612.3681240007281 612.5891119986773 613.9708660021424 616.7363289967179 618.1986079961061 619.8702389970422 621.7076420038939 622.4773359969258 630.5573729947209 634.5370690003037 Current Mean: 663.903 ms Stdev: 24.214 ms (3.6%) Runs: 613.0941570028663 614.8471689969301 620.1545820012689 632.3264570012689 641.3863929957151 644.3673919960856 645.0202639997005 648.9526769965887 651.0489509999752 651.4778250008821 651.735555998981 652.9499510005116 657.0646570026875 658.3827719986439 659.2680259943008 661.2923579961061 663.7571620047092 666.5957439988852 667.9235850051045 669.3931890055537 669.5183520019054 672.3942879959941 676.9669599980116 677.7165120020509 678.3893229961395 681.3911550045013 687.1675620004535 690.4475920051336 690.8216149955988 698.4296469986439 700.7461749985814 702.5051269978285 711.2583419978619

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	703.526 ms → 713.404 ms (+9.878 ms, +1.4%)
App start regularAppStart	0.013 ms → 0.016 ms (+0.003 ms, +21.0%) 🟡
App start nativeLaunch	20.344 ms → 19.469 ms (-0.875 ms, -4.3%)
App start runJsBundle	198.469 ms → 197.125 ms (-1.344 ms, -0.7%)

Show details

Name	Duration
App start TTI	Baseline Mean: 703.526 ms Stdev: 29.997 ms (4.3%) Runs: 639.4492549970746 661.9246940016747 664.2100810036063 670.7921940013766 671.8802959993482 672.3896619975567 676.2786640003324 678.8449790030718 684.6982010006905 689.1158479973674 689.2582850009203 690.3867160007358 691.4958639964461 692.0983109995723 694.4739110022783 696.3859250023961 697.5862839967012 706.2759110033512 711.0293539986014 713.1957459971309 713.950300000608 714.0618589967489 720.8936650007963 722.3411099985242 723.0726189985871 727.3212860003114 733.5307229980826 737.7338069975376 747.2176970019937 759.2970739975572 759.938670001924 761.6970620006323 Current Mean: 713.404 ms Stdev: 26.544 ms (3.7%) Runs: 665.78625100106 669.3879650011659 680.846955999732 683.7710359990597 685.1647320017219 685.5508520007133 686.625662997365 688.3153560012579 690.2011340036988 691.9361750036478 698.4204540029168 698.9023249968886 701.8235780000687 706.1272450014949 707.6470519974828 707.7151559963822 713.4976079985499 718.4492750018835 718.5818419978023 720.2430870011449 720.6532400026917 728.4887119978666 733.802360996604 734.4651279971004 741.006508000195 742.0943809971213 743.8267050012946 746.0376399978995 748.3100240007043 751.7457740008831 759.3108669966459 760.1774780005217
App start regularAppStart	Baseline Mean: 0.013 ms Stdev: 0.001 ms (5.1%) Runs: 0.011758998036384583 0.012166999280452728 0.01269499957561493 0.012736000120639801 0.012777000665664673 0.012777000665664673 0.012858003377914429 0.012897998094558716 0.012939006090164185 0.012981005012989044 0.013020999729633331 0.01310199499130249 0.01310199499130249 0.013102002441883087 0.013183996081352234 0.013305999338626862 0.013467997312545776 0.013550005853176117 0.013590000569820404 0.013590998947620392 0.013590998947620392 0.013631001114845276 0.013672001659870148 0.013711996376514435 0.013753004372119904 0.013916000723838806 0.013957001268863678 0.014078997075557709 0.014322996139526367 0.014485999941825867 0.014566995203495026 0.015014998614788055 Current Mean: 0.016 ms Stdev: 0.001 ms (4.9%) Runs: 0.01452600210905075 0.014566995203495026 0.01505500078201294 0.015381000936031342 0.015542998909950256 0.015666000545024872 0.015706993639469147 0.015747003257274628 0.015787996351718903 0.015949994325637817 0.015951000154018402 0.016030997037887573 0.016112998127937317 0.01615399867296219 0.01619499921798706 0.01619499921798706 0.016357995569705963 0.01635800302028656 0.016398005187511444 0.016683004796504974 0.01672399789094925 0.016764000058174133 0.016805000603199005 0.016967996954917908 0.017048999667167664 0.017292998731136322 0.017741002142429352 0.017861999571323395
App start nativeLaunch	Baseline Mean: 20.344 ms Stdev: 2.557 ms (12.6%) Runs: 17 17 18 18 18 18 18 18 18 18 19 19 19 19 20 20 20 20 21 21 21 21 21 22 22 22 22 22 23 25 26 28 Current Mean: 19.469 ms Stdev: 1.561 ms (8.0%) Runs: 17 17 17 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 20 20 20 20 21 21 21 21 21 22 22 22 23
App start runJsBundle	Baseline Mean: 198.469 ms Stdev: 18.217 ms (9.2%) Runs: 167 167 168 171 172 178 178 184 184 190 192 193 194 199 199 199 199 203 204 205 207 210 211 214 214 215 216 217 222 222 223 234 Current Mean: 197.125 ms Stdev: 17.566 ms (8.9%) Runs: 172 173 176 176 177 180 180 181 181 183 184 186 192 195 196 197 198 200 200 201 201 204 206 207 210 210 211 215 219 224 224 249

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.2.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.2.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.77-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅