Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Connect Bank Account - Console error appears when proceed with Onfido flow #15638

Closed
1 of 6 tasks
kbecciv opened this issue Mar 3, 2023 · 32 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #14802

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with gmail account
  3. Go Setting - Workspace - Connect Bank Account
  4. Select Connect via Plaid
  5. Select Fidelity and use: user_good/pass_good
  6. Use any data for Company Information Page and for Personal
  7. Proceed with Onfido flow

Expected Result:

NO console error appears when proceed with Onfido flow

Actual Result:

NO console error appears when proceed with Onfido flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1,2,78,0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (9)

14802.Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0101c916e70f761cbe
  • Upwork Job ID: 1632689831582904320
  • Last Price Increase: 2023-03-06
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 3, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 3, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@yuwenmemon
Copy link
Contributor

cc @nkuoch

@nkuoch nkuoch self-assigned this Mar 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2023
@adelekennedy
Copy link

@nkuoch should this be internal?

@melvin-bot melvin-bot bot removed the Overdue label Mar 6, 2023
@nkuoch
Copy link
Contributor

nkuoch commented Mar 6, 2023

Yes! Working on it now!

@nkuoch nkuoch added the Internal Requires API changes or must be handled by Expensify staff label Mar 6, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 6, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0101c916e70f761cbe

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@nkuoch nkuoch added the Reviewing Has a PR in review label Mar 6, 2023
@roryabraham
Copy link
Contributor

This won't be locally testable unfortunately. Removing @thesahindia from this issue

@nkuoch nkuoch added Weekly KSv2 and removed Daily KSv2 labels Mar 9, 2023
@nkuoch
Copy link
Contributor

nkuoch commented Mar 10, 2023

@kbecciv A fix has been deployed. Can you try again?

@kbecciv
Copy link
Author

kbecciv commented Mar 13, 2023

@nkuoch Checking, will update you shortly

@kbecciv
Copy link
Author

kbecciv commented Mar 13, 2023

Able to reproduce some error with build 1.2.83.2

Recording.2305.mp4

@nkuoch
Copy link
Contributor

nkuoch commented Mar 14, 2023

@kbecciv A new fix has been deployed. Can you try again?

@harshad2711
Copy link

@nkuoch I have reported the same bug in slack, can you please confirm if I am eligible for reporting bonus here?
note: I've checked and yes now the console error is gone

@MelvinBot
Copy link

📣 @harshad2711! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@harshad2711
Copy link

Contributor details
Your Expensify account email: harshadmangani19260@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01faa60b2512b34d78

@MelvinBot
Copy link

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@adelekennedy
Copy link

@harshad2711 will you apply here for the reporting bonus?

@harshad2711
Copy link

@adelekennedy I am not able to apply, getting this error on Upwork
Screenshot 2023-03-30 at 1 43 33 PM

@harshad2711
Copy link

@adelekennedy I am not able to apply, getting this error on Upwork Screenshot 2023-03-30 at 1 43 33 PM

@adelekennedy can you please help here

@nkuoch nkuoch removed their assignment Mar 31, 2023
@harshad2711
Copy link

@adelekennedy I am not able to apply, getting this error on Upwork Screenshot 2023-03-30 at 1 43 33 PM

@adelekennedy can you please help here

@adelekennedy above link is now working for me

@harshad2711
Copy link

@adelekennedy I am not able to apply, getting this error on Upwork Screenshot 2023-03-30 at 1 43 33 PM

bump @adelekennedy

@harshad2711
Copy link

sorry to ping you again @adelekennedy , but can you please check the above Upwork link, it is not working for me

@adelekennedy
Copy link

@harshad2711 try again? Link

@harshad2711
Copy link

image

@harshad2711
Copy link

@adelekennedy see

@adelekennedy
Copy link

ugh - I made it public before. Now I've logged out - in again and edited it (if this link doesn't work I'll create.a new job)
https://www.upwork.com/jobs/~0101c916e70f761cbe

@harshad2711
Copy link

image @adelekennedy

@harshad2711
Copy link

@adelekennedy Hey I am still facing the same issue, you can invite me too if you want, here's my profile https://www.upwork.com/freelancers/~01faa60b2512b34d78

@adelekennedy
Copy link

re-hired! sorry for this!

@harshad2711
Copy link

@adelekennedy Sorry to bother you, but please confirm if you have approved my payment, as the milestone is showing In the work in progress to me

@harshad2711
Copy link

@adelekennedy when did you relese my payment its been a month

@adelekennedy
Copy link

Hey! I'm so sorry about that - yes, I released payment for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants