Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-03-02 #15618

Closed
35 tasks done
OSBotify opened this issue Mar 2, 2023 · 11 comments
Closed
35 tasks done

Deploy Checklist: New Expensify 2023-03-02 #15618

OSBotify opened this issue Mar 2, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2023

Release Version: 1.2.78-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 2, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 2, 2023
@mvtglobally
Copy link

mvtglobally commented Mar 3, 2023

@yuwenmemon Regression is almost completed.

PR #14802 Is failing #15638 and blocked on Native aps due to old KI #11796
PR #15311 is failing #15642
PR #15317 is failing #15647. repro in PROD checking off
We are blocked here #15464 (comment)
PR #15501 is failing #15648. repro in PROD. ok to checkoff?
PR #15509 is failing #15644. NOT repro in PROD, but its a new feature, so we didnt add blocker label. Pls double check
#15601 is PROD QA
We are still working on a few other PRs.

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Mar 3, 2023

PR #15501 is failing #15648. repro in PROD. ok to checkoff?

Yeah, looks like quite the edge case as well.

@yuwenmemon
Copy link
Contributor

PR #15509 is failing #15644. NOT repro in PROD, but its a new feature, so we didnt add blocker label. Pls double check

Yeah I think we're good to just check it off.

@mvtglobally
Copy link

mvtglobally commented Mar 3, 2023

We are done with PRs. About 15% left of regression.

Summary so far for outstanding items
PR #14802 Is failing #15638 and blocked on Native aps due to old KI #11796. Ok to check off?
PR #15311 is failing #15642
We are blocked here #15464 (comment)
#15601 is PROD QA
#15262 is failing #15651. repro in PROD. Checking off

@mvtglobally
Copy link

Regression is completed

@grgia
Copy link
Contributor

grgia commented Mar 6, 2023

Checking off #15464

@roryabraham
Copy link
Contributor

Checking off #15311 for the reasoning that @cristipaval closed #15642

@roryabraham
Copy link
Contributor

Now we're waiting on:

@mountiny
Copy link
Contributor

mountiny commented Mar 6, 2023

Checking off #15474 since the workspace chat creation is broken most likely due to Auth deploy https://github.com/Expensify/Auth/pull/7576 so we cannot really test that.

@mountiny
Copy link
Contributor

mountiny commented Mar 6, 2023

Checking #15546 off as the testing has similar issues as my comment above.

Timings and errors look fine so I am going to deploy this before Rory will get online

@mountiny
Copy link
Contributor

mountiny commented Mar 6, 2023

:shipit:

@mountiny mountiny closed this as completed Mar 6, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants