Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Bank Account - User can't add Fidelity bank because of connectivity error message #11796

Closed
kavimuru opened this issue Oct 13, 2022 · 42 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Oct 13, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the New expensify app
  2. Sign into a valid account
  3. Tap on Profile > Workspace > Connect to bank
  4. Select "Plaid" and select Fidelity Bank

Expected Result:

User expects to be able to continue with the VBA flow

Actual Result:

User receives an error message and can not proceed

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.12.13-3
Reproducible in staging?: y
Reproducible in production?: can't check
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: https://user-images.githubusercontent.com/43996225/195569592-2f097a1f-51f2-402f-b663-9adeb59d5951.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2022

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@PauloGasparSv
Copy link
Contributor

Taking a look at this in the afternoon since right now Fidelity connection is unavailable:

image

@kbecciv
Copy link

kbecciv commented Oct 14, 2022

@PauloGasparSv There is another error message in Web when using "Plaid" option, please let me know if we need to create a new GH issue for that.

Bug5775553_User_receives_error_message_in_Plaid_flow.1.mp4

@PauloGasparSv
Copy link
Contributor

No need @kbecciv, this new error replaced the old right?
Sorry for taking so long to work on this, it's the very next item on my todo list : )

@kavimuru
Copy link
Author

kavimuru commented Oct 14, 2022

@PauloGasparSv We are still seeing the same error message in iOS though. But in the web, we are seeing the above error in step 4 of 5 as in the video.

@PauloGasparSv
Copy link
Contributor

No way, there is another window of time where the service is unavailable! 🤦🤦🤦
I'll only have time to look at it on Monday because of that, sorry!

So from 9AM to 11AM ET and from 3PM to 5PM ET the service is down.
Which means I have 11AM to 3PM ET (12PM to 16PM BRT) to debug this on Monday

image

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@PauloGasparSv
Copy link
Contributor

Taking a look at this today during the timeframe the service is up (right after lunch)

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Oct 17, 2022

@kavimuru @kbecciv I just tried again on desktop following this comment+video!

I got the same error message.
Then tried again with the SSN as 3333 as specified in this S.O. and it worked!

image

@kavimuru @kbecciv Can you test this again with that test user but with the 3333 SSN and see if works for you too?

@kbecciv
Copy link

kbecciv commented Oct 17, 2022

@PauloGasparSv
Re-testing, update you shortly.

@kbecciv
Copy link

kbecciv commented Oct 17, 2022

@PauloGasparSv I was able to add the VBA, but faced the error message #11796 (comment) - only worked around using back button and click continue again.
Please attached the video, tested on Windows/Chrome

Recording.1463.mp4

@PauloGasparSv
Copy link
Contributor

Oh! Maybe it only worked for me because of that too but I thought the SSN fixed it!
Testing it again here

@PauloGasparSv
Copy link
Contributor

Replicated here, the SSN was not the issue.
For some reason the first attempt to save the Fidelity connection fails but if you go back and try again it works.

Investigating the issue here!

@PauloGasparSv
Copy link
Contributor

Will take some more time to work on this. Can't debug web-secure to understand the error due to the Php8.1 upgrade that is happening right now, Web-Secure is still not working with the updated version.

Will debug this again tomorrow since the timeframe of the Fidelity API's is closing by anyway!

@PauloGasparSv
Copy link
Contributor

Getting a blank screen now instead of the error, debugging it locally (just finished setting web-scure up with php 8.1)! Not sure what the cause is yet.

image

@PauloGasparSv
Copy link
Contributor

I'm changing this to weekly since I'm taking little longer than expected to solve this and it isn't affecting a prod customer yet!

@PauloGasparSv PauloGasparSv added Weekly KSv2 and removed Daily KSv2 labels Oct 19, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Oct 26, 2022

Tested once again but the connection worked at first try this time and did not give me that unvailable timeframe error:
image

Then I removed the bankAccount from my user and tried connecting it to the workspace again and got this error I'm investigating:
image

That error's UUID is 6893fbdb-755b-4c72-85fc-3fa5dab0e705 but sadly there are three different places that return the same uuid. Not sure if that's correct.

@PauloGasparSv
Copy link
Contributor

@kbecciv Do you mind testing this again? Other than staging iOS and Android the Fidelity connection should be working on all the other platforms.

I got the errors above when the service went down like it does daily but it to work locally on Web, locally on mobile and on staging Web!

This got super confusing so I'd appreciate another round of tests : p

@kbecciv
Copy link

kbecciv commented Oct 26, 2022

@PauloGasparSv I will test the Web and mWeb shortly, will update you with videos.

@kbecciv
Copy link

kbecciv commented Oct 27, 2022

@PauloGasparSv Just checked with recent build 1.2.20 and got crashed on both environments.

Screen_Recording_20221026-210902_Chrome.mp4
Recording.1527.mp4

@PauloGasparSv
Copy link
Contributor

What!!!!! Thks @kbecciv, I got that error once from all the 10 or attempts I did yesterday.
I'll try digging into this some more and reach for help if I can't find anything

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

@davidcardoza, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@techievivek
Copy link
Contributor

I did test this couple of times on staging but I wasn't able to reproduce this even once.
Screenshot 2022-11-14 at 1 08 07 PM

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 14, 2022
@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@techievivek
Copy link
Contributor

techievivek commented Nov 14, 2022

The error is shown for 3 commands. ConnectBankAccountWithPlaid, UpdateCompanyInformationForBankAccount, UpdatePersonalInformationForBankAccount. And it has to do with the bankAccountID param passed. From newDot when we add a new VBBA for the first two commands it doesn't expect us to pass the bank account but in the instances where errors are thrown it's mostly a bankAccountID is passed and I would assume that bankAccountID doesn't belong to the user and it throws an error when it doesn't find it in the list of bank accounts that user has. In the case of UpdatePersonalInformationForBankAccount it throws an error when bankAccountID = 0 so in this case I would guess the pusher hasn't sent the newly created bankAccountID to the user. I will dig into some more during the later part of the day.

@melvin-bot melvin-bot bot added the Overdue label Nov 16, 2022
@techievivek
Copy link
Contributor

I wasn't able to look into it because my xdebug was broken, just fixed it by rebuilding the VM.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

@davidcardoza, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@davidcardoza
Copy link
Contributor

@techievivek any update here?

@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2022
@techievivek
Copy link
Contributor

Sorry, I was ooo. I will look into it today and give an update.

@techievivek
Copy link
Contributor

@kbecciv I did have another look into it and tested it again on staging, but I can't seem to reproduce it. Can you try reproducing this one more time because even logs are no longer available? Thanks

@kbecciv
Copy link

kbecciv commented Nov 25, 2022

Issue is reproduced in build 1.2.31.8

Screen_Recording_20221125-151731_New.Expensify.mp4

@techievivek
Copy link
Contributor

techievivek commented Nov 28, 2022

@kbecciv That seems like standard connectivity down info and doesn't look like an error from our end. I tested this myself on staging seems to work fine now.

Screen.Recording.2022-11-28.at.10.19.45.AM.mov

@techievivek
Copy link
Contributor

techievivek commented Nov 28, 2022

I tried this with a new account, and I was able to add the account without any issues. @kbecciv, what you have shared is not something we can fix from our end. If you can reproduce some error while adding the bank account, that is something concerning for us. If there are no issues while adding the bank account(unrelated to Plaid showing something from their end), things seem to work fine.

@davidcardoza Any thoughts here?

@davidcardoza
Copy link
Contributor

I tried reproducing myself and couldn't come up with an error. I am going to close this out. Please reopen if the issue is reproducible Expensify error and not one stemming from Plaid.

@mvtglobally
Copy link

Guys This issue is a pain. We are really blocked on Native aps.
@techievivek @davidcardoza Did you use real IOS/Android devices to validate this?

@mvtglobally
Copy link

@davidcardoza
Copy link
Contributor

Tested on iOS. I am still not reproducing

RPReplay_Final1670278015.MP4

@kbecciv kbecciv changed the title iOS - User can't add Fidelity bank because of connectivity error message Connect Bank Account - User can't add Fidelity bank because of connectivity error message Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants