[NoQA] Update K2 link to publicly accessible location

[amyevans]

cc @marcochavezf @rushatgabhane

Details

The Expensify repo is only accessible by internal employees. This updates the K2 dashboard link to one that is publicly accessible

Fixed Issues

N/A, related to this Slack convo

Tests

N/A, documentation change

Offline tests

N/A, documentation change

QA Steps

None

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A, documentation change

Mobile Web - Chrome

N/A, documentation change

Mobile Web - Safari

N/A, documentation change

Desktop

N/A, documentation change

iOS

N/A, documentation change

Android

N/A, documentation change

[MelvinBot]

@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[robertjchen]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[robertjchen]

👍

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
Open Search Page TTI	611.886 ms → 669.481 ms (+57.595 ms, +9.4%) 🔴

Show details

Name

Duration

Open Search Page TTI

Baseline Mean: 611.886 ms Stdev: 21.208 ms (3.5%) Runs: 568.1902259998024 581.8355310000479 582.5554609997198 584.8946529999375 585.0929370000958 585.9921469995752 587.8927009999752 599.4415289992467 599.8464359994978 602.4436040008441 603.6863200003281 604.0275880005211 604.8309740005061 607.5795089993626 608.0368250003085 610.3221439998597 612.9540200000629 614.6741949999705 614.8475750004873 616.2256669998169 618.5739339999855 618.8366700001061 622.0482179997489 623.0496829999611 628.5798750007525 629.7792560001835 635.8331710007042 637.6216640006751 638.9099939996377 648.0850020004436 651.8164060004056 651.8542889999226 Current Mean: 669.481 ms Stdev: 20.278 ms (3.0%) Runs: 622.084066000767 622.2863370003179 638.7919519999996 649.0876469993964 650.2522390000522 650.6246750000864 650.9111739993095 652.0559080000967 654.5706789996475 660.3368739997968 660.910116000101 662.4440520005301 667.0332040004432 667.7891849996522 668.2692459998652 669.7726650005206 670.3544519999996 671.2435710001737 673.6859540008008 674.7890219995752 676.1145020006225 677.7688809996471 678.494141000323 681.878824999556 683.6711839996278 685.6646729996428 690.2831220002845 693.4303389992565 693.7088630003855 695.1064050002024 696.5148930000141 697.225424000062 705.7346189999953

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	709.759 ms → 726.186 ms (+16.427 ms, +2.3%)
App start runJsBundle	190.438 ms → 197.903 ms (+7.466 ms, +3.9%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.000 ms, +1.1%)
App start nativeLaunch	20.531 ms → 20.333 ms (-0.198 ms, -1.0%)

Show details

Name	Duration
App start TTI	Baseline Mean: 709.759 ms Stdev: 33.890 ms (4.8%) Runs: 645.7209809999913 663.0734999999404 663.6152839995921 667.4373819995672 675.134874000214 681.2281149998307 681.7211079997942 684.3078410001472 684.903107999824 686.4745580004528 688.1246309997514 694.2989790001884 695.3534289998934 701.9862799998373 706.2263989998028 708.5660359999165 711.6517909998074 714.7651720000431 715.967752000317 716.5764279998839 717.2091720001772 717.5750550003722 721.4458729997277 722.1718420004472 724.819513999857 737.6923380000517 741.2009709998965 752.9021009998396 755.0642729997635 768.5122060002759 771.8031519996002 794.7587900003418 Current Mean: 726.186 ms Stdev: 33.584 ms (4.6%) Runs: 673.5920029999688 684.6464560003951 693.630189999938 694.5206899996847 694.5235580001026 696.0457290001214 697.0372360004112 697.6892090002075 698.4586159996688 701.8912089997903 703.489457000047 704.2795649999753 709.9263479998335 710.0239209998399 713.0692619998008 714.1333860000595 719.5553949996829 726.7553110001609 727.6222799997777 728.8328320002183 730.8945230003446 730.9509159997106 737.720013000071 739.6423519998789 745.4703479995951 758.6595860002562 766.5076179997995 774.9345610002056 782.441979999654 787.5941629996523 791.9199480004609 801.4951179996133
App start runJsBundle	Baseline Mean: 190.438 ms Stdev: 16.492 ms (8.7%) Runs: 161 165 165 166 170 174 174 175 177 182 183 187 190 191 193 193 194 194 194 194 195 195 197 199 200 201 202 205 206 221 222 229 Current Mean: 197.903 ms Stdev: 20.658 ms (10.4%) Runs: 162 170 172 173 177 178 179 183 185 188 188 188 189 189 193 195 197 203 204 204 205 206 206 207 209 216 222 223 235 239 250
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (5.0%) Runs: 0.012776000425219536 0.013143000192940235 0.013305999338626862 0.013426999561488628 0.013590000569820404 0.013631000183522701 0.013875999487936497 0.013875999487936497 0.013915999792516232 0.013915999792516232 0.013996999710798264 0.014078999869525433 0.014282000251114368 0.014322999864816666 0.01444500032812357 0.014567000791430473 0.014607000164687634 0.01464799977838993 0.014689000323414803 0.0147299999371171 0.014810999855399132 0.014810999855399132 0.014810999855399132 0.014933000318706036 0.014933000318706036 0.014973999932408333 0.015095999464392662 0.015096000395715237 0.0152580002322793 0.01550300046801567 0.015910000540316105 Current Mean: 0.015 ms Stdev: 0.001 ms (6.2%) Runs: 0.012736000120639801 0.013265000656247139 0.013306000269949436 0.013387000188231468 0.013427999801933765 0.013427999801933765 0.013590999878942966 0.0138349998742342 0.01403799932450056 0.014078999869525433 0.014119000174105167 0.014241999946534634 0.014403999783098698 0.01444500032812357 0.01448499970138073 0.014525999315083027 0.014649000018835068 0.014728999696671963 0.0147299999371171 0.014851999469101429 0.014973999932408333 0.014973999932408333 0.015015000477433205 0.015015000477433205 0.015177000313997269 0.015502999536693096 0.015542999841272831 0.01582799945026636 0.016030999831855297 0.01623500045388937 0.016276000067591667
App start nativeLaunch	Baseline Mean: 20.531 ms Stdev: 3.021 ms (14.7%) Runs: 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 20 23 23 23 24 24 24 27 28 28 Current Mean: 20.333 ms Stdev: 2.071 ms (10.2%) Runs: 18 18 18 18 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 21 22 22 22 23 23 25 25 25

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅