Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-03-09 #15767

Closed
19 tasks done
OSBotify opened this issue Mar 9, 2023 · 6 comments
Closed
19 tasks done

Deploy Checklist: New Expensify 2023-03-09 #15767

OSBotify opened this issue Mar 9, 2023 · 6 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 9, 2023 •
edited by roryabraham
Loading

Release Version: 1.2.81-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 9, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 9, 2023
@Julesssss
Copy link
Contributor

Checking off the deploy blocker, as I have reverted the PR.

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 9, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.81-1 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 9, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.81-1 has been deployed to staging 🎉

@mvtglobally
Copy link

mvtglobally commented Mar 9, 2023 •
edited
Loading

@roryabraham Regression is completed

PR #15210 is failing #15790. Not repro in Prod
PR #15507 is failing #15633. Repro in prod checking off

@roryabraham
Copy link
Contributor

Not treating #15786 as a deploy blocker, checking off #15210

@roryabraham
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Julesssss @applausebot @mvtglobally @roryabraham @OSBotify