Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-03-24] [$1000] Clicking on the users profile icon on the group chat doesn’t display the avatar instead displays some weird attachment #15809

Closed
6 tasks done
kavimuru opened this issue Mar 10, 2023 · 45 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Mar 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open chrome web and go to any group chat that has at least one user without a profile picture (should have default avatar).
  2. Click on the default avatar of the user that has no profile picture
  3. You’ll see that the avatar doesn’t show up , instead some weird attachment displays. But following the same process with a user that has profile picture set, doesn't cause problems

Expected Result:

Default avatar should be shown on clicking the avatar of the user in a group chat

Actual Result:

A weird attachment shows up while clicking on the avatar picture in a group chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.81-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

avatar-2023-03-09_16.04.34.mp4
Recording.1667.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678357372651409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cf19e2357822eff9
  • Upwork Job ID: 1635271536327073792
  • Last Price Increase: 2023-03-13
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@MelvinBot
Copy link

MelvinBot commented Mar 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@maddylewis

This comment was marked as resolved.

@maddylewis maddylewis added Needs Reproduction Reproducible steps needed and removed Needs Reproduction Reproducible steps needed labels Mar 10, 2023
@maddylewis
Copy link
Contributor

i can reproduce:

2023-03-10_15-21-05.mp4

@MelvinBot
Copy link

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@maddylewis
Copy link
Contributor

i think this could be external but just want to confirm before adding the label.

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@danieldoglas
Copy link
Contributor

Agreed it can be external

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2023
@danieldoglas danieldoglas added Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Mar 13, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 13, 2023
@melvin-bot melvin-bot bot changed the title Clicking on the users profile icon on the group chat doesn’t display the avatar instead displays some weird attachment [$1000] Clicking on the users profile icon on the group chat doesn’t display the avatar instead displays some weird attachment Mar 13, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01cf19e2357822eff9

@MelvinBot
Copy link

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2023
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 13, 2023
@MelvinBot
Copy link

Current assignee @danieldoglas is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 Overdue labels Mar 23, 2023
@maddylewis
Copy link
Contributor

@sobitneupane - can you confirm where you would suggest putting the regression test in TestRail? ty!

@melvin-bot melvin-bot bot removed the Overdue label Mar 27, 2023
@sobitneupane
Copy link
Contributor

@maddylewis I am not very familiar with TestRail. According to https://expensify.slack.com/archives/C02NK2DQWUX/p1679598304150889?thread_ts=1679597927.757039&cid=C02NK2DQWUX, we were not trained about TestRail because we no longer need to propose the location.

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2023
@maddylewis
Copy link
Contributor

Notes for myself: Test Rail > New Expensify (test suites) > New Expensify

Regression test update here - https://github.com/Expensify/Expensify/issues/272667

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2023
@sobitneupane
Copy link
Contributor

@maddylewis
Could not accept the offer. "The offer is not available anymore."

Screenshot 2023-04-01 at 07 54 42

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@maddylewis
Copy link
Contributor

@sobitneupane sorry about that. i believe that's bc i set a specific end date. let me re-create the job and send you the offer.

@bernhardoj should be paid for this one 👍

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@maddylewis
Copy link
Contributor

Upwork is erroring out when re-creating the job but i will get this complete asap. sorry for the delay @sobitneupane !!

@maddylewis
Copy link
Contributor

invited you to the new job posting @sobitneupane

@sobitneupane
Copy link
Contributor

Thanks @maddylewis. Accepted the offer

@bernhardoj
Copy link
Contributor

@maddylewis Yes, I have received the initial payment, but I think you miss the merge bonus payment 😄. I think we are eligible for the bonus.

@avi-shek-jha
Copy link

@maddylewis I am an external reporter. I haven't received the invitation yet. Thank you

@maddylewis
Copy link
Contributor

@danieldoglas - could confirm the merge bonus that @sobitneupane and @bernhardoj should be receiving for this one?

@danieldoglas
Copy link
Contributor

@maddylewis yes, they are eligible for the bonus since the PR was created and merged in < 3 business days.

@maddylewis
Copy link
Contributor

@avi-shek-jha - how does your name show in Upwork?

@avi-shek-jha
Copy link

avi-shek-jha commented Apr 4, 2023

@maddylewis It shows as: abhishek jha

Also here is the upwork link: https://www.upwork.com/freelancers/~01a90e548bf808418c

@maddylewis
Copy link
Contributor

okay looks like everyone is paid! again, apologies for the delay, everyone. thank you for your patience <3

@sobitneupane
Copy link
Contributor

@maddylewis I have not received the bonus yet. I could not accept the new offer. Same issue as #15809 (comment)

@maddylewis
Copy link
Contributor

resent another offer @sobitneupane

@sobitneupane
Copy link
Contributor

resent another offer @sobitneupane

Thanks @maddylewis.Accepted the offer.

@maddylewis
Copy link
Contributor

paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants