Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] [Navigation Reboot] Implement the navigation UP function #15849

Closed
mountiny opened this issue Mar 10, 2023 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 10, 2023

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Implement the navigation UP function.

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01734c8f8ee1693f28
  • Upwork Job ID: 1634919281369825280
  • Last Price Increase: 2023-03-12
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. Bug Something is broken. Auto assigns a BugZero manager. labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@Expensify Expensify deleted a comment from MelvinBot Mar 10, 2023
@Expensify Expensify deleted a comment from MelvinBot Mar 10, 2023
@adamgrzybowski
Copy link
Contributor

Going to implement this

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01734c8f8ee1693f28

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@mountiny
Copy link
Contributor Author

Not overdue, gonna be implementing this week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 13, 2023
@mountiny
Copy link
Contributor Author

@adamgrzybowski can you please leave a comment daily on each of the daily issues with an update (so they dont go overdue)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 16, 2023
@mountiny
Copy link
Contributor Author

Work will resume now once ECX is done

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Mar 21, 2023
@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Apr 24, 2023
@mountiny
Copy link
Contributor Author

Making this Daily as we are unblocked after removing the drawer navigation

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@adamgrzybowski
Copy link
Contributor

Work in progress

@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2023
@mountiny
Copy link
Contributor Author

@staszekscp works on this, any update?

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2023
@staszekscp
Copy link
Contributor

Hey, hopefully on Tuesday we'll post a PR with our implementation (on Monday there's a bank holiday in Poland), so we're close, :)

@mountiny
Copy link
Contributor Author

Thanks for the update, bank holiday in UK and Czechia too 🎉

@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@mountiny
Copy link
Contributor Author

mountiny commented May 2, 2023

Any updates here @staszekscp?

@mountiny
Copy link
Contributor Author

mountiny commented May 3, 2023

Bank holiday in 🇵🇱

@mountiny mountiny added the Reviewing Has a PR in review label May 4, 2023
@mountiny
Copy link
Contributor Author

mountiny commented May 4, 2023

PR is up in a review

@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

@mountiny, @adamgrzybowski, @staszekscp Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor Author

PR hopefully gonna be merged this week

@mountiny
Copy link
Contributor Author

PR done, nothing to pay here

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Reboot] Implement the navigation UP function [HOLD for payment 2023-06-15] [Navigation Reboot] Implement the navigation UP function Jun 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants