-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-15] [Navigation Reboot] Implement the navigation UP function #15849
Comments
Going to implement this |
Job added to Upwork: https://www.upwork.com/jobs/~01734c8f8ee1693f28 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav ( |
Not overdue, gonna be implementing this week. |
@adamgrzybowski can you please leave a comment daily on each of the daily issues with an update (so they dont go overdue) |
Work will resume now once ECX is done |
Making this Daily as we are unblocked after removing the drawer navigation |
Looks like something related to As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our Feel free to drop a note in #expensify-open-source with any questions. |
Work in progress |
@staszekscp works on this, any update? |
Hey, hopefully on Tuesday we'll post a PR with our implementation (on Monday there's a bank holiday in Poland), so we're close, :) |
Thanks for the update, bank holiday in UK and Czechia too 🎉 |
Any updates here @staszekscp? |
Bank holiday in 🇵🇱 |
PR is up in a review |
@mountiny, @adamgrzybowski, @staszekscp Whoops! This issue is 2 days overdue. Let's get this updated quick! |
PR hopefully gonna be merged this week |
PR done, nothing to pay here |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-15. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Tracking issue #11768
Created a new branch
navigation-refactor
to which we will merge all the PRs of this refactor.Implement the navigation UP function.
Bookmark in the doc
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: