[Navigation Reboot] Implement UP press #18402

staszekscp · 2023-05-04T13:16:20Z

Details

This PR is a part of Navigation Reboot. It introduces implementation of UP functionality mentioned in this design doc.

Also deprecating the close X button

CC: @mountiny

Fixed Issues

$ #15849
$ #15850
$ #18092
$ #14125

Tests

The tests are mentioned in design doc

IMPORTANT: Please, use https://staging.new.expensify.com/settings/about link for testing in the AdHoc build (https://new.expensify.com/settings/about will open the web browser)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as the tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

* test flatlist for android * fix linter * fix name * fix not working features * limit rerenders

MelvinBot · 2023-05-04T13:40:40Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

staszekscp · 2023-05-16T08:21:47Z

Hey! I noticed that there was a bug with offline status - if it was fixed could we align the navigation-refactor with main so I would pull changes and see if everything works fine? Thanks!

0xmiros · 2023-05-16T12:46:43Z

yes there was offline indicator issue yesterday and fixed.
@mountiny we need to sync navigation-refactor again with main

mountiny · 2023-05-16T14:51:39Z

Ok, I am travelling to Scotland today so slower to respond sorry, could we also check if this issue will be fixed after this refactor #14125

staszekscp · 2023-05-17T10:34:56Z

@mountiny The issue is fixed, so I added it to the PR's description

mountiny · 2023-05-17T12:08:12Z

Running the build now

melvin-bot · 2023-05-17T15:46:13Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

mountiny · 2023-05-17T15:51:44Z

Asked in Slack here for help with testing from contributors https://expensify.slack.com/archives/C01GTK53T8Q/p1684335996442389

OSBotify · 2023-05-18T13:30:50Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/18402/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/18402/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/18402/NewExpensify.dmg	https://18402.pr-testing.expensify.com

mountiny

@0xmiroslav I would be happy to merge this to the navigation-refactor branch now as it seems quite reliable and we can do all the proper testing on that last branch PR as now it seems good already

Can you please give this a review and confrim if there is anything you thing we need to fix in this PR?

0xmiros · 2023-05-18T16:15:29Z

@mountiny sure!

job 3 is failing. not sure if it also happens on navigation-refactor

MariaHCD

LGTM!

mountiny · 2023-05-19T10:34:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

We have tested extensively using the internal builds, and we will test the last branch a lot too

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-06-06T22:04:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.25-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-08T17:39:35Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.25-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-06-09T21:07:37Z

src/pages/YearPickerPage.js

@@ -64,7 +64,7 @@ class YearPickerPage extends React.Component {
     */
    updateSelectedYear(selectedYear) {
        // We have to navigate using concatenation here as it is not possible to pass a function as a route param
-        Navigation.navigate(`${this.props.route.params.backTo}?year=${selectedYear}`);
+        Navigation.goBack(`${ROUTES.SETTINGS_PERSONAL_DETAILS_DATE_OF_BIRTH}?year=${selectedYear}`, true);


Ah so we hard coded the route, but was the original intention for this to be more generic? This change would break the re-usability of this component I think...

sobitneupane · 2023-07-24T14:44:44Z

src/components/BlockingViews/FullPageNotFoundView.js

 };

 // eslint-disable-next-line rulesdir/no-negated-variables
 const FullPageNotFoundView = (props) => {
    if (props.shouldShow) {
        return (
            <>
-                <HeaderWithCloseButton
-                    shouldShowBackButton={props.shouldShowBackButton}


Removal of shouldShowBackButton in this PR caused this issue.

Issue: Back Button is shown on desktop in Report Screen

staszekscp and others added 18 commits April 24, 2023 10:57

Fix flatlist glitch for android (#9)

dcd9711

* test flatlist for android * fix linter * fix name * fix not working features * limit rerenders

remove close button

3b5e279

Merge branch 'navigation-refactor' into remove-close-button

f200f22

fix linter

19a9513

rename storybook file

a86fdc6

Merge branch 'navigation-refactor' into remove-close-button

9aaa242

simplify code

0a5008e

fixes

ab605b0

fixes and improvements

ad65cec

remove ModalHeader

9b82116

feat: some work done

8ee7d09

move to goback

1e456f6

add workspaces

71d6fed

fixes

00f1f82

fixes for yearpicker

7e0365d

fix animation

9748448

remove some code

619cce2

fixes

d6da21d

staszekscp marked this pull request as ready for review May 4, 2023 13:40

staszekscp requested a review from a team as a code owner May 4, 2023 13:40

staszekscp changed the title ~~[Draft] Implement up press~~ Implement UP press May 4, 2023

staszekscp changed the title ~~Implement UP press~~ [Navigation Reboot] Implement UP press May 4, 2023

melvin-bot bot requested review from MariaHCD and removed request for a team May 4, 2023 13:40

chore: merge current navigation-refactor

281a25f

mountiny self-requested a review May 4, 2023 14:12

mountiny assigned staszekscp May 4, 2023

WoLewicki added 2 commits May 4, 2023 16:36

feat: some changes

b143205

Merge branch 'navigation-refactor' into implement-up-press

588b401

staszekscp added 3 commits May 17, 2023 11:35

fix

bd07f59

Merge branch 'navigation-refactor' into implement-up-press

2162b81

podfile.lock update

b49cc6d

mountiny mentioned this pull request May 18, 2023

[HOLD for payment 2023-10-02] [HOLD] [Performance] ReportScreen unnecessary re-renders #15163

Closed

6 tasks

staszekscp added 2 commits May 18, 2023 09:23

fix not working back button after resize

a9585be

performance test

8a8ebbf

mountiny approved these changes May 18, 2023

View reviewed changes

staszekscp and others added 3 commits May 19, 2023 11:01

fix test

e96e7d6

fix: test from main

450136b

add last line to package.json

e5d8bdc

MariaHCD approved these changes May 19, 2023

View reviewed changes

mountiny merged commit 19a3b1a into Expensify:navigation-refactor May 19, 2023

OSBotify mentioned this pull request Jun 6, 2023

Deploy Checklist: New Expensify 2023-06-06 #20312

Closed

31 tasks

marcaaron reviewed Jun 9, 2023

View reviewed changes

sobitneupane reviewed Jul 24, 2023

View reviewed changes

sobitneupane mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-07-17] [$1000] Back Button is shown on desktop in Report Screen #21596

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Navigation Reboot] Implement UP press #18402

[Navigation Reboot] Implement UP press #18402

staszekscp commented May 4, 2023 •

edited by mountiny

Loading

MelvinBot commented May 4, 2023

staszekscp commented May 16, 2023

0xmiros commented May 16, 2023

mountiny commented May 16, 2023

staszekscp commented May 17, 2023

mountiny commented May 17, 2023

melvin-bot bot commented May 17, 2023

mountiny commented May 17, 2023

OSBotify commented May 18, 2023

mountiny left a comment

0xmiros commented May 18, 2023

MariaHCD left a comment

mountiny commented May 19, 2023 •

edited

Loading

OSBotify commented Jun 6, 2023

OSBotify commented Jun 8, 2023

marcaaron Jun 9, 2023

sobitneupane Jul 24, 2023

[Navigation Reboot] Implement UP press #18402

[Navigation Reboot] Implement UP press #18402

Conversation

staszekscp commented May 4, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented May 4, 2023

staszekscp commented May 16, 2023

0xmiros commented May 16, 2023

mountiny commented May 16, 2023

staszekscp commented May 17, 2023

mountiny commented May 17, 2023

melvin-bot bot commented May 17, 2023

mountiny commented May 17, 2023

OSBotify commented May 18, 2023

mountiny left a comment

Choose a reason for hiding this comment

0xmiros commented May 18, 2023

MariaHCD left a comment

Choose a reason for hiding this comment

mountiny commented May 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jun 6, 2023

OSBotify commented Jun 8, 2023

marcaaron Jun 9, 2023

Choose a reason for hiding this comment

sobitneupane Jul 24, 2023

Choose a reason for hiding this comment

staszekscp commented May 4, 2023 •

edited by mountiny

Loading

mountiny commented May 19, 2023 •

edited

Loading