Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-06 #20312

Closed
31 tasks done
OSBotify opened this issue Jun 6, 2023 · 27 comments
Closed
31 tasks done

Deploy Checklist: New Expensify 2023-06-06 #20312

OSBotify opened this issue Jun 6, 2023 · 27 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2023

Release Version: 1.3.25-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 6, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 6, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.25-3 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 6, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.25-3 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 6, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.25-1 🚀

@mountiny
Copy link
Contributor

mountiny commented Jun 6, 2023

Checking:

The changes are all included in this PR #19263 and we should aim to do a thorough regression testing on all platforms to see if there are any issues stemming from the new architecture

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 6, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.25-4 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 6, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.25-4 has been deployed to staging 🎉

@dangrous
Copy link
Contributor

dangrous commented Jun 7, 2023

I think I found a regression, following the SO and posting here.

https://expensify.slack.com/archives/C049HHMV9SM/p1686161807163249

@roryabraham
Copy link
Contributor

Demoting #20370 to a regular bug and checking it off for now

@roryabraham
Copy link
Contributor

#20398 is NAB, checking it off.

@mvtglobally
Copy link

Current PR update

#18402 is failing #20370
#19263 is failing #20391
#20235 is failing #20393 repro in prod

@roryabraham
Copy link
Contributor

Demoted #20404, checking it off.

@roryabraham
Copy link
Contributor

Noooot sure what #8 is doing here ... checking it off 😵‍💫

@roryabraham
Copy link
Contributor

#20412 demoted, checking it off

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 7, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.25-6 🚀

@roryabraham
Copy link
Contributor

Reproduced #20410 on production, demoting and checking it off.

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.25-6 has been deployed to staging 🎉

@roryabraham
Copy link
Contributor

1.3.25-7 is deploying here

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.25-7 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.25-7 has been deployed to staging 🎉

@mvtglobally
Copy link

Working on retests

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.25-8 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.25-8 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

mountiny commented Jun 8, 2023

Only one last blocker left to check 🎉

@mvtglobally
Copy link

Regression is completed.
CPs passed and checked off

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants