[HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] [$1000] Chat - Context menu (long tap on message) does not open when the keyboard is open

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open iOS App or iPad app and login with any account
2. Go to any chat
3. Focus to input field to open keyboard
4. Scroll chat and long tap to any message

Expected Result:

Сontext menu opens.
Keyboard closed.

Actual Result:

Context menu does not open when keyboard open.
Keyboard does not close.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6084188_iOS-context-menu-not-open.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team & syedsaroshfarrukhdot

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197a7315599dfaf41
• Upwork Job ID: 1666596829203070976
• Last Price Increase: 2023-06-08

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197a7315599dfaf41

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @amyevans (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @amyevans is eligible for the Engineering assigner, not assigning anyone new.

[roryabraham]

I'm taking this over because @amyevans is OOO

[roryabraham]

Removing the Help Wanted label for now because this is a deploy blocker, needs to be resolved ASAP

[roryabraham]

I believe this is out problem line

[roryabraham]

Ok, so there's something causing the LHN to re-render when the popover modal opens, even if it's not visible.

[situchan]

I noticed performance issue in latest main.
OptionRowLHN component is mounted every time report action context menu is opened on mobile.

[syedsaroshfarrukhdot]

@roryabraham @mountiny am I eligible for reporting bonus here ?

[mountiny]

I bealive you should be

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Dont hide the context menu from the LHN if Sidebar not in focus #20442

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Christinadobrzyn]

Hired in Upwork
Internal job: https://www.upwork.com/ab/applicants/1666596829203070976/job-details
External job: https://www.upwork.com/jobs/~0197a7315599dfaf41

Reporter @syedsaroshfarrukhdot
C+ @parasharrajat

Is there anyone else to hire for this? Looks like the PR was created by @roryabraham and not an external contributor

[Christinadobrzyn]

Looks like we're now paying this on [HOLD for payment 2023-06-19] - got a few days

[Christinadobrzyn]

Ready for payment -

Is there a speed bonus for this? I can't tell in the PR @parasharrajat

Also, do we need a regression test?

[parasharrajat]

@Christinadobrzyn It was done by an internal Engineer? Does that apply here? I am not sure.

[Christinadobrzyn]

Ah okay, thanks! Speed bonus doesn't apply to internal jobs. I'll pay this out!

@parasharrajat would you be able to write up a regression test for this (correct me if that's not for you to do)?

[Christinadobrzyn]

Paid in Upwork based on:

#20422 (comment)

[Christinadobrzyn]

I think we still need a regression on this, @parasharrajat or @roryabraham?

[roryabraham]

Proposed regression test steps:

1. Go to any chat
2. Focus the message input field to open keyboard
3. Scroll chat and long tap to any message
4. Verify that the keyboard closes and the context menu opens.

I believe this can go in the Message Action menu - Other scenarios (multiline, emojis and markdown) test suite.

[Christinadobrzyn]

Awesome thanks Rory! Submitted the regression test - https://github.com/Expensify/Expensify/issues/296227