[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] IOS - Log in- New user is not navigating to Concierge chat after tap on link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of NewDot
2. Navigate to https://staging.new.expensify.com/concierge
3. Sign-up with a new account

Expected Result:

New user is navigating to Concierge chat after tap on link

Actual Result:

New user is not navigating to Concierge chat after tap on link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3490982

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6084105_the_concierge_chat.mp4

Expensify/Expensify Issue URL:

**Issue reported by:**Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0158ff64059880717e
• Upwork Job ID: 1666582636407345152
• Last Price Increase: 2023-06-07

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0158ff64059880717e

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Current assignee @aldo-expensify is eligible for the External assigner, not assigning anyone new.

[mountiny]

While this is a bug most likely related to the navigation refactor I dont think its a deploy blocker as it only happens with a specific deeplink and on a specific platform. I will ask @koko57 to look at this one since she has experience in this area

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New user is not navigating to Concierge chat after tap on link

What is the root cause of that problem?

It's here

App/src/libs/actions/Report.js

Line 1632 in 4dc58e7

Navigation.isReportScreenReady().then(() => {

, we can see that it will only navigate to Concierge/Report after the isSidebarLoadedAlready() is resolved, which is called when the ReportScreen mounted (see here).

With the recent navigation revamp, the ReportScreen won't be mounted unless it's visible, so when we login/sign up and see the Report List, ReportScreen is not mounted at that time so it won't navigate the deep link earlier.

This not only happens on iOS but Android as well, it doesn't happen on Web/Desktop since the ReportScreen is always mounted upon entering the app on large screen.

What changes do you think we should make in order to solve the problem?

We need to replace this by waiting for the Sidebar mounting instead, the Sidebar is always mounted when entering the app on all platforms.

We already set the sidebar loaded condition here

App/src/pages/home/sidebar/SidebarLinks.js

Line 112 in 4dc58e7

App.setSidebarLoaded();

, but in order for this to work we need to add additional logic like in the existing isReportScreenReady that is currently used here https://github.com/Expensify/App/blob/main/src/libs/Navigation/Navigation.js#L222-L234.

We can introduce a similar isSidebarLoadedAlready function that returns a promise, we need to reset the promise when the Sidebar unmounted as well.

The logic is basically similar to the report screen ready check that is used now, just that we uses it for the sidebar.

What alternative solutions did you explore? (Optional)

We can make ReportScreen always mounted upon entering the app on small device as well, but this is less performant.

If we want other trigger to open the report, other than isSidebarLoaded, we can also do that by applying similar logic for that trigger.

[thesahindia]

@tienifr's proposal looks good to me!

C+ reviewed 🎀👀🎀

cc: @mountiny

[mountiny]

Thanks for raising

[MitchExpensify]

Yes, thanks @tienifr !

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 20412 new user is not navigating to concierge chat after tab on link #20740

If no regressions arise, payment will be issued on 2023-06-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MitchExpensify]

Set a reminder to pay in my calendar!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 20412 new user is not navigating to concierge chat after tab on link #20740

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MitchExpensify]

Not overdue - Payment coming tomorrow

[melvin-bot]

@mountiny, @MitchExpensify, @thesahindia, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Paid @tienifr with bonus 🎉

Once you accept @thesahindia I'll pay out and close this up 👍

[thesahindia]

Accepted! Sorry for the delay.

[MitchExpensify]

Thanks @thesahindia, Upwork is acting strangely and I don't see the acceptance reflecting there. I've invited you here instead! Sorry about that. https://www.upwork.com/ab/applicants/1676296241268867072/suggested

[thesahindia]

Accepted, thanks!

[MitchExpensify]

Wooh, that worked! Paid