fix: 20412 new user is not navigating to concierge chat after tab on link #20740

tienifr · 2023-06-14T04:33:15Z

Details

Fixed Issues

$ #20412
PROPOSAL: #20412 (comment)

Tests

Log out of NewDot
Navigate to https://staging.new.expensify.com/concierge
Sign-up with a new account
Verify that new user is navigating to Concierge chat after tap on link

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Log out of NewDot
Navigate to https://staging.new.expensify.com/concierge
Sign-up with a new account
Verify that new user is navigating to Concierge chat after tap on link

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.14-06-2023.14.51.56.webm

Mobile Web - Chrome

video_2023-06-14_15-05-15.mp4

Mobile Web - Safari

original-1457f195-000c-4f0a-8d2d-090145692411_2eB5efDg.mp4

Desktop

Screen.Recording.2023-06-14.at.14.33.08.mov

iOS

Screen.Recording.2023-06-14.at.11.16.11.mp4

Android

Screencast.from.14-06-2023.15.27.44.webm

…link

melvin-bot · 2023-06-14T08:30:41Z

@mountiny @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Changes look good to me, also asking @WoLewicki to have a look!

WoLewicki

Should we leave Navigation.isReportScreenReady() and other methods related to it? They don't seem to be used anywhere else. Other than that, it seems good, thanks!

mountiny · 2023-06-14T16:21:26Z

src/libs/actions/Report.js

@@ -1638,7 +1639,7 @@ function openReportFromDeepLink(url, isAuthenticated) {

    // Navigate to the report after sign-in/sign-up.
    InteractionManager.runAfterInteractions(() => {
-        Navigation.isReportScreenReady().then(() => {


good point this is not used naywhere else so we can remove it

tienifr · 2023-06-14T16:33:59Z

@mountiny @WoLewicki Thanks for pointing that out, I've updated my PR.

mountiny

LGTM
@thesahindia can you run through the checklist please? Thanks!

thesahindia · 2023-06-14T19:38:05Z

@tienifr, the app is crashing. We forgot about this instance

App/src/pages/home/ReportScreen.js

Line 152 in f467085

Navigation.setIsReportScreenIsReady();

mountiny · 2023-06-14T20:25:42Z

@tienifr @thesahindia Can you please prioritize this fix as it seems to influnce multiple deeplinks

marcochavezf · 2023-06-14T23:31:14Z

@tienifr, the app is crashing. We forgot about this instance

App/src/pages/home/ReportScreen.js

Line 152 in f467085

Navigation.setIsReportScreenIsReady();

I tested by removing that missing instance, and the deeplink looks good for both concierge and public rooms:

Screen.Recording.2023-06-14.at.17.27.36.mov

Screen.Recording.2023-06-14.at.17.28.25.mov

I could push that change to this branch, but I don't have permission to write to tienifr:fix/20412 branch. We can either wait for @tienifr to do that change or I can create another PR with their changes.

tienifr · 2023-06-15T02:38:01Z

@thesahindia I just removed the Navigation.setIsReportScreenIsReady(); and I tested well with the deeplink. Can you help test again? Thanks

thesahindia · 2023-06-15T06:59:43Z

Testing it right now.

mountiny · 2023-06-15T07:01:14Z

Thanks @thesahindia! Ping me in slack once you done please

thesahindia · 2023-06-15T07:40:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-15.at.1.14.39.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-15.at.12.32.35.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-15.at.12.41.11.PM.mov

Desktop

desktop.mp4

iOS

Android

Screen.Recording.2023-06-15.at.12.35.40.PM.mov

thesahindia

LGTM!

I wasn't able to attach a video for ios. For some reason the button keeps loading after adding the magic code. It's not related to this PR so we can move forward.

mountiny

Thanks everyone!

github-actions · 2023-06-15T08:07:58Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

mountiny · 2023-06-15T08:14:18Z

Tested the public room deeplink and it worked in iOS

fix: 20412 new user is not navigating to concierge chat after tab on link (cherry picked from commit 9ed4a16)

…-20740 🍒 Cherry pick PR #20740 to staging 🍒

fix: 20412 new user is not navigating to concierge chat after tab on link (cherry picked from commit 9ed4a16)

OSBotify · 2023-06-15T09:07:46Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.28-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:39:34Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T22:18:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-26T20:48:44Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: 20412 new user is not navigating to concierge chat after tab on …

b03c285

…link

tienifr marked this pull request as ready for review June 14, 2023 08:30

tienifr requested a review from a team as a code owner June 14, 2023 08:30

melvin-bot bot requested review from mountiny and thesahindia and removed request for a team June 14, 2023 08:30

tienifr mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] IOS - Log in- New user is not navigating to Concierge chat after tap on link #20412

Closed

6 tasks

mountiny assigned tienifr Jun 14, 2023

mountiny reviewed Jun 14, 2023

View reviewed changes

WoLewicki reviewed Jun 14, 2023

View reviewed changes

mountiny reviewed Jun 14, 2023

View reviewed changes

remove unused code

ae34f8a

mountiny previously approved these changes Jun 14, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

marcochavezf mentioned this pull request Jun 14, 2023

Fix App does not navigate to last opened public room in small screen devices after Sign in from a public room link #20654

Merged

57 tasks

fix: remove setIsReportScreenIsReady

5e7a8e9

tienifr dismissed mountiny’s stale review via 5e7a8e9 June 15, 2023 02:36

thesahindia approved these changes Jun 15, 2023

View reviewed changes

mountiny approved these changes Jun 15, 2023

View reviewed changes

mountiny added the CP Staging label Jun 15, 2023

mountiny merged commit 9ed4a16 into Expensify:main Jun 15, 2023

OSBotify pushed a commit that referenced this pull request Jun 15, 2023

Merge pull request #20740 from tienifr/fix/20412

650dd03

fix: 20412 new user is not navigating to concierge chat after tab on link (cherry picked from commit 9ed4a16)

OSBotify mentioned this pull request Jun 15, 2023

🍒 Cherry pick PR #20740 to staging 🍒 #20795

Merged

OSBotify added a commit that referenced this pull request Jun 15, 2023

Merge pull request #20795 from Expensify/OSBotify-cherry-pick-staging…

7ddf35b

…-20740 🍒 Cherry pick PR #20740 to staging 🍒

OSBotify pushed a commit that referenced this pull request Jun 15, 2023

Merge pull request #20740 from tienifr/fix/20412

46a2d92

fix: 20412 new user is not navigating to concierge chat after tab on link (cherry picked from commit 9ed4a16)

This was referenced Jun 15, 2023

🍒 Cherry pick PR #20740 to staging 🍒 #20796

Closed

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

hoangzinh mentioned this pull request Jun 19, 2023

[HOLD for payment 2023-07-26] [$1000] Web - User is not navigated to the concierge chat after login #20885

Closed

6 tasks

OSBotify mentioned this pull request Jun 24, 2023

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed

45 tasks

mollfpr mentioned this pull request Aug 29, 2023

Fix/deeplinks when app in background #26073

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 20412 new user is not navigating to concierge chat after tab on link #20740

fix: 20412 new user is not navigating to concierge chat after tab on link #20740

tienifr commented Jun 14, 2023 •

edited

Loading

melvin-bot bot commented Jun 14, 2023

mountiny left a comment

WoLewicki left a comment

mountiny Jun 14, 2023

tienifr commented Jun 14, 2023

mountiny left a comment

thesahindia commented Jun 14, 2023

This comment was marked as resolved.

mountiny commented Jun 14, 2023

marcochavezf commented Jun 14, 2023

tienifr commented Jun 15, 2023

thesahindia commented Jun 15, 2023

mountiny commented Jun 15, 2023

thesahindia commented Jun 15, 2023

thesahindia left a comment

mountiny left a comment

github-actions bot commented Jun 15, 2023

mountiny commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

fix: 20412 new user is not navigating to concierge chat after tab on link #20740

fix: 20412 new user is not navigating to concierge chat after tab on link #20740

Conversation

tienifr commented Jun 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 14, 2023

mountiny left a comment

Choose a reason for hiding this comment

WoLewicki left a comment

Choose a reason for hiding this comment

mountiny Jun 14, 2023

Choose a reason for hiding this comment

tienifr commented Jun 14, 2023

mountiny left a comment

Choose a reason for hiding this comment

thesahindia commented Jun 14, 2023

This comment was marked as resolved.

mountiny commented Jun 14, 2023

marcochavezf commented Jun 14, 2023

tienifr commented Jun 15, 2023

thesahindia commented Jun 15, 2023

mountiny commented Jun 15, 2023

thesahindia commented Jun 15, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 15, 2023

mountiny commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

tienifr commented Jun 14, 2023 •

edited

Loading