[HOLD for payment 2023-07-26] [$1000] Web - User is not navigated to the concierge chat after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of NewDot
2. Go to https://staging.new.expensify.com/concierge
3. Verify that you are taken to the login screen
4. Log in to NewDot
5. Verify you're navigated to the concierge chat after login

Expected Result:

User should be navigated to the concierge chat after login

Actual Result:

After login, user is navigated to the last chat of his/her last session

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094809_Bug_1_-_Staging_-_2023-06-15_18-10-46.mp4

2023-06-15.23-34-01.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0195b3719c902bfe8a
• Upwork Job ID: 1669733106684628992
• Last Price Increase: 2023-07-07

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This seems to be a real blocker.

[mountiny]

Asked @WoLewicki to have a look

[mountiny]

And @koko57 too 😄 lets get this fixed

[WoLewicki]

The problem comes from how ReportScreenWrapper works right now. It sets the reportID to the last visited id. The solution would be to set the last visited report to Concierge when user signs in. I'm looking for the best place to add it. Do you have an idea where should it be?

[koko57]

@mountiny @WoLewicki My finding so far:
I've tested the app on a revision before this PR was merged and after merging these changes.

First I've noticed that we don't have a proper id for the concierge chat when calling navigateToConciergeChat here.

After comparing with the changes before the PR it looks like the Onyx is populated with data before the navigateToConciergeChat - looks like the SidebarUtils.isSidebarLoadedReady() is resolved quicker than Navigation.isReportScreenReady()

here are the logs:

before changes

after changes

So the flow basically looks like this:

• after logging in the Concierge page mounts and the navigateToConciergeChat() is called here
• we don't have the id for the concierge chat -> we're navigated to the Report page here
• as the ReportScreen mounts Navigation.isReportScreenReady() (in the old revision) and SidebarUtils.isSidebarLoadedReady() (in the revision after the PR) are resolved - but it looks like the SidebarUtils.isSidebarLoadedReady() is resolved earlier
• navigateToConciergeChat() is called here and as we already have the concierge report Id in the case with Navigation.isReportScreenReady() we're navigated to the Concierge chat, while in the SidebarUtils.isSidebarLoadedReady() we're not

A lot happens here and I hope I explained it as clear as possible 😅 , but if you still have any questions just let me know 🙂

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[AndrewGable]

Demoting to bug per: https://expensify.slack.com/archives/C01GTK53T8Q/p1686927085343139?thread_ts=1686924049.839489&cid=C01GTK53T8Q

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0195b3719c902bfe8a

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - User is not navigated to the concierge chat after login

What is the root cause of that problem?

I think our deep link logic work fine. It waits until the isSidebarLoadedReady and the OpenApp api to be finished before navigate to Concierge chat. But the issue is this line

App/src/libs/actions/Report.js

Line 481 in 469596a

Navigation.dismissModal(reportID);

Previously, we used to call Navigation.navigate(ROUTES.getReportRoute(reportID)) directly, but after this commit we changed to Navigation.dismissModal(reportID). I think it works well when we are in Search Page/Task page (RHN) then want navigate to chatReport but when we just sign in, there is no modal stack yet, so it does nothing after Sign in

App/src/libs/Navigation/Navigation.js

Line 142 in 469596a

Log.hmmm('[Navigation] dismissModal failed because there is no modal stack to dismiss');

What changes do you think we should make in order to solve the problem?

I think we can update current Navigation.dismissModal so that it works as it described here. That means if there is no modal stack to dismiss, and targetReportID is passed to this function, we need to navigate to the targetReportID, don't just log.

What alternative solutions did you explore? (Optional)

We can add a param option to Report.navigateToAndOpenReport so that we can have option to dismissModal or navigate directly to chatReport here

[parasharrajat]

Started reviewing the issue...

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[stephanieelliott]

PR is on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix User is not navigated to the concierge chat after login on Web #22623

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Checklist is not relevant here, this was part of the bigger navigation refactor

@stephanieelliott Are you able to run through the payments? Thanks!

[stephanieelliott]

Summarizing payments for this issue:

• Issue reporter: N/A
• Contributor: @hoangzinh $1000 (paid via Upwork)
• Contributor+: @parasharrajat $1000 (please request on newdot)

[parasharrajat]

Payment requested.

[JmillsExpensify]

@stephanieelliott I believe you're missing an extra zero in that summary for @parasharrajat. Is that right?

[stephanieelliott]

Oops! Sorry, yeah I was missing a 0. Updated the payment summary!

Summarizing payments for this issue:

• Issue reporter: N/A
• Contributor: @hoangzinh $1000 (paid via Upwork)
• Contributor+: @parasharrajat $1000 (please request on newdot)

[JmillsExpensify]

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.