Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Group - Message with the IOU details isn't displayed in the conversation history #20413

Closed
6 tasks done
lanitochka17 opened this issue Jun 7, 2023 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App
  2. Click the + icon in a Group conversation
  3. Open the DM create menu again and select Split Bill
  4. Enter an amount into the BNP and select the Next confirmation button
  5. Select all the participants and hit "Split Bill"

Expected Result:

Verify a message with the IOU details is displayed in the conversation history listing all the participants selected

Actual Result:

Message with the IOU details isn't displayed in the conversation history

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.25.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6084098_split_mac_chrome.mp4
Bug6084098_split_mac_chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 7, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

mountiny commented Jun 7, 2023

Its coming from here

if (_.isEmpty(props.iouReport)) {
return null;
}

@mountiny mountiny assigned mountiny and unassigned luacmartins Jun 8, 2023
@mountiny mountiny added the Reviewing Has a PR in review label Jun 8, 2023
@mountiny
Copy link
Contributor

mountiny commented Jun 8, 2023

This is in staging and no payment required

@mountiny mountiny closed this as completed Jun 8, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title Group - Message with the IOU details isn't displayed in the conversation history [HOLD for payment 2023-06-15] Group - Message with the IOU details isn't displayed in the conversation history Jun 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-15] Group - Message with the IOU details isn't displayed in the conversation history [HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Group - Message with the IOU details isn't displayed in the conversation history Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants