[$1000] Web- Contact methods - Settings page appears for a moment when clicking Esc button twice

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Profile -> Contact methods -> Open verified contact method -> Remove
4. Click the Esc button twice

Expected Result:

App redirected to LHN

Actual Result:

The settings page appears for a moment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6083792_Recording__4856.mp4

Recording.4858.mp4

Expensify/Expensify Issue URL:

Issue reported by: Aplause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f44c655a73ebc60
• Upwork Job ID: 1666574571521617920
• Last Price Increase: 2023-06-14

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Interesting. I think that ESC should only close one "level" of modals. i.e: pressing escape with the confirm delete modal open should bring the user to the page they were in before the confirm delete modal was opened. Pressing it again should close the RHP and bring them back home.

I think this is a legitimate bug but imo not a deploy blocker because it's an edge case. Going to make this a regular bug.

[mountiny]

This is related to navigation refactor and i dont think this is a blocker but a polish bug we should handle as a follow up, removing rhe label

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f44c655a73ebc60

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MrJithil]

All set @MrJithil - the issue has been assigned over. Thank you @narefyev91 for the reviews here.

Thank You so much. Happy to look forward with this.

[MrJithil]

I have submitted an application on Upwork with the accepted GH proposal. The code modification required for this task is minimal, and I can prepare the pull request within a short timeframe.

However, as this is going to be my first contribution to Expensify/App, I need to train myself with all the necessary steps involved in our contribution process, including testing on various platforms, linting, and CLA signing.

Therefore, I aim to have the pull request ready for review on or before Monday, June 12th, 2023. This deadline will provide me with ample time to familiarize myself with the required steps and ensure their accurate completion.

[MrJithil]

PR raised. Please check: #20534

CC: @narefyev91

[mountiny]

@adamgrzybowski @WoLewicki noted this might not be a good solution as it will most likely remove the navigation browser history in the stack

[adamgrzybowski]

Here is an example of different behavior caused by using popToTop().

expected: The request action pops modal and the user is redirected to the chat

actual: The request action pops all the screens on the stack and the user is redirected to the chat list.

Screen.Recording.2023-06-12.at.15.48.12.mov

[mountiny]

@MrJithil sorry for the confusion here, even if you wont fix this, I think we should pay you 25% of the reward so $250 for your efforts.

Looking for new proposals

[MrJithil]

No problem. I will also, investigate some possible ways to handle and submit proposals again.

Thank you all.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

Not overdue, we are still taking proposals.

[alexpensify]

Not overdue, this one is open and taking proposals.

[bernhardoj]

I think this issue is fixed by #20815?

[alexpensify]

Thanks for flagging - @mountiny and @narefyev91 do you agree that we should close this one?

[narefyev91]

Thanks for flagging - @mountiny and @narefyev91 do you agree that we should close this one?

Seems so - we should close this one

[mountiny]

The PR is in staging, can we confirm it has been fixed?

[narefyev91]

The PR is in staging, can we confirm it has been fixed?

I already checked in the morning - issue is not reproduced

[mountiny]

Nice, this has been internally raised so we can close this issue.

[alexpensify]

Thank you!