[navigation-refactor] fix: currency and date picker selection #20355

adamgrzybowski · 2023-06-07T12:18:00Z

Details

When we are selection currency or year in the date picker the value is lost after selection

Simplify getActiveRoute and make it always work.

Aslo safely access the report

Fixed Issues

https://expensify.slack.com/archives/C049HHMV9SM/p1686118076977069

$ #20357
$ #20358
$ #20361

Tests

Click on Fab icon
Send/request money
Click on the currency icon
Choose a different currency
Verify the currency was correctly selected

Sign in with an account without a date of birth
Go to Settings > Profile > Personal Details
Go to Date of birth
Click on Year picker
Select any year
Click on any date on the calendar
Verify the data is correctly selected without any error

Go to staging dot on web chrome
Create a new workspace and create a room with public mode
Click on room header and click on share code and copy the URL
Now open a new window and first make sure that on that window, you're are logged out of all the staging and new Expensify accounts
Paste the link on a new tab and notice that the screen freezes on that point. I remember, it used to show the chat room and used to ask users to sign in previously. But now, it is stuck at the same point. Since it's a public room, it should have shown the chat room or anything.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Datepicker videos

iOS

datepicker20355-ios.mp4

Web

datepicker20355.mp4

Web

Screen.Recording.2023-06-07.at.14.10.53.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-07T12:18:34Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-06-07T12:39:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web20355.mp4

Mobile Web - Chrome

mwebAndroid20355.mp4

Mobile Web - Safari

mwebiOS20355.mp4

Desktop

desktop20355.mov

iOS

ios20355.mp4

Android

android.mp4

mountiny

Changes look good to me, but still need to figure out the datepicker issue

mountiny

Changes look good to me, but still need to figure out the datepicker issue

github-actions · 2023-06-07T13:24:42Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

mountiny

Tests well

srikarparsi

changes look good to me

…r-currency-selection [navigation-refactor] fix: currency and date picker selection (cherry picked from commit 8415bb2)

…-20355 🍒 Cherry pick PR #20355 to staging 🍒

OSBotify · 2023-06-07T23:35:10Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.25-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-08T17:39:00Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.25-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:25:03Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:42:51Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: currency selection

f912a0d

adamgrzybowski requested a review from a team as a code owner June 7, 2023 12:18

melvin-bot bot removed the request for review from a team June 7, 2023 12:18

melvin-bot bot requested a review from srikarparsi June 7, 2023 12:18

mountiny self-requested a review June 7, 2023 12:26

mountiny assigned adamgrzybowski Jun 7, 2023

mountiny approved these changes Jun 7, 2023

View reviewed changes

mountiny previously approved these changes Jun 7, 2023

View reviewed changes

fix: use lodash in getReport

30ccbaf

mountiny changed the title ~~[navigation-refactor] fix: currency selection~~ [navigation-refactor] fix: currency and date picker selection Jun 7, 2023

mountiny added the CP Staging label Jun 7, 2023

adamgrzybowski dismissed mountiny’s stale review via 30ccbaf June 7, 2023 13:26

adamgrzybowski and others added 2 commits June 7, 2023 16:39

fix: update year in date picker

e188a4f

fix: just goBack in task title and description

0dce436

s77rt mentioned this pull request Jun 7, 2023

Refactor iou page by separating each step as individual screen #17964

Merged

56 tasks

WoLewicki added 2 commits June 7, 2023 19:34

fix: calendar year picker

951547b

fix: indent

ca56fc8

mountiny approved these changes Jun 7, 2023

View reviewed changes

srikarparsi approved these changes Jun 7, 2023

View reviewed changes

srikarparsi merged commit 8415bb2 into Expensify:main Jun 7, 2023

OSBotify pushed a commit that referenced this pull request Jun 7, 2023

Merge pull request #20355 from adamgrzybowski/@swm/navigation-refacto…

d0256cd

…r-currency-selection [navigation-refactor] fix: currency and date picker selection (cherry picked from commit 8415bb2)

OSBotify mentioned this pull request Jun 7, 2023

🍒 Cherry pick PR #20355 to staging 🍒 #20419

Merged

OSBotify added a commit that referenced this pull request Jun 7, 2023

Merge pull request #20419 from Expensify/mountiny-cherry-pick-staging…

fd7c883

…-20355 🍒 Cherry pick PR #20355 to staging 🍒

OSBotify mentioned this pull request Jun 7, 2023

Deploy Checklist: New Expensify 2023-06-06 #20312

Closed

31 tasks

lanitochka17 mentioned this pull request Jun 8, 2023

[$1000] mWeb/Chrome - Sign in button is cropped when pasting the URL of a new room with public mode #20456

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 8, 2023

[HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Currency doesn't change in the first try #20357

Closed

6 tasks

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[navigation-refactor] fix: currency and date picker selection #20355

[navigation-refactor] fix: currency and date picker selection #20355

adamgrzybowski commented Jun 7, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Jun 7, 2023

mountiny commented Jun 7, 2023 •

edited

Loading

mountiny left a comment

mountiny left a comment

github-actions bot commented Jun 7, 2023

mountiny left a comment

srikarparsi left a comment

OSBotify commented Jun 7, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

[navigation-refactor] fix: currency and date picker selection #20355

[navigation-refactor] fix: currency and date picker selection #20355

Conversation

adamgrzybowski commented Jun 7, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 7, 2023

mountiny commented Jun 7, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 7, 2023

mountiny left a comment

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 7, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

adamgrzybowski commented Jun 7, 2023 •

edited by mountiny

Loading

mountiny commented Jun 7, 2023 •

edited

Loading