Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Creating a new room with public mode freezes on the screen when pasted the URL #20361

Closed
6 tasks done
mountiny opened this issue Jun 7, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@mountiny
Copy link
Contributor

mountiny commented Jun 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Go to staging dot on web chrome
  2. Create a new workspace and create a room with public mode
  3. Click on room header and click on share code and copy the URL
  4. Now open a new window and first make sure that on that window, you're are logged out of all the staging and new Expensify accounts
  5. Paste the link on a new tab and notice that the screen freezes on that point. I remember, it used to show the chat room and used to ask users to sign in previously. But now, it is stuck at the same point. Since it's a public room, it should have shown the chat room or anything.

Expected Result:

Creating a new room with public mode should either show the chat room on the screen when pasting the URL or if not, then it should show an error

Actual Result:

Creating a new room with public mode freezes on the screen when pasted the URL
Platforms: web chrome

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.25-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686141356348729

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018b6fd77a212706c7
  • Upwork Job ID: 1666432124500230144
  • Last Price Increase: 2023-06-07
@mountiny mountiny added Reviewing Has a PR in review Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Jun 7, 2023
@mountiny mountiny self-assigned this Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018b6fd77a212706c7

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title Creating a new room with public mode freezes on the screen when pasted the URL [HOLD for payment 2023-06-15] Creating a new room with public mode freezes on the screen when pasted the URL Jun 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
  • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mountiny] Determine if we should create a regression test for this bug.
  • [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jliexpensify
Copy link
Contributor

@mountiny no payment or regression test needed here?

@mountiny
Copy link
Contributor Author

Lets handle payments for the other 2 issues fixed in this PR here, all are only for bug reports so:

No regression checklist required here, this is coming from major refactor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 12, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-15] Creating a new room with public mode freezes on the screen when pasted the URL [HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Creating a new room with public mode freezes on the screen when pasted the URL Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
  • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mountiny] Determine if we should create a regression test for this bug.
  • [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jliexpensify
Copy link
Contributor

Invites sent @Puneet-here , @priya-zha and @adeel0202

@mountiny
Copy link
Contributor Author

No checklist required here, new feature essentially

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 14, 2023
@Puneet-here
Copy link
Contributor

Invites sent @Puneet-here , @priya-zha and @adeel0202

I have applied to the job @jliexpensify

@melvin-bot melvin-bot bot added the Overdue label Jun 16, 2023
@jliexpensify
Copy link
Contributor

Everyone hired, once accepted I'll pay and close this!

@melvin-bot melvin-bot bot removed the Overdue label Jun 16, 2023
@jliexpensify
Copy link
Contributor

jliexpensify commented Jun 19, 2023

Paid Priya and Muhammad Adeel, waiting on @Puneet-here !

@Puneet-here
Copy link
Contributor

@jliexpensify, I have accepted the offer now.

@jliexpensify
Copy link
Contributor

Paid, and job removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

4 participants