[HOLD for payment 2023-03-31] [$1000] Inconsistency in the tooltip texts between 'Edit comment/ Delete comment' & 'Add Reaction'

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chrome web > Go to any chat > Send a text
2. Hover over the message > hover over the add reaction icon. Notice that the tooltip displays 'Add Reaction' where R is in capital form.
3. Next, hover over the edit comment and delete comment icon. Notice that 'C' in comment is in small letter. Thus, there's no consistency between the texts in the tooltip.

Expected Result:

Edit comment and Delete comment should be changed to Edit Comment & Delete Comment ('C' in capital form) to maintain consistency with Add Reaction text, since all these icons are present in the same menu

Actual Result:

Edit comment and delete comment are not consistent with Add Reaction text

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.82-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1680.mp4

letters-2023-03-10_20.37.22.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678460555350449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01317e9c8ba89234e9
• Upwork Job ID: 1635692457285844992
• Last Price Increase: 2023-03-14

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tjferriss]

Checking on whether we should handle this internally or externally.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01317e9c8ba89234e9

[MelvinBot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in the tooltip texts between 'Edit comment/ Delete comment' & 'Add Reaction'

What is the root cause of that problem?

We can see throughout the app we use first letter of the first word in upper case and rest in lower case So here real problem is with Add Reaction grammar because R is capital in it.

What changes do you think we should make in order to solve the problem?

To make grammar consistence we have to change Add Reaction to Add reaction i.e. we have to make r small in reaction.

Within src/languages/en.js we have to do correction as shown below:

reportActionContextMenu: {
  ...
  addReactionTooltip: 'Add reaction', // *** Make r small in reaction ***
}

NOTE: Within expected results of this issue it is mentioned below things.

Edit comment and Delete comment should be changed to Edit Comment & Delete Comment ('C' in capital form) to maintain consistency with Add Reaction text, since all these icons are present in the same menu

But as per my observation, throughout the app we capitalise first char of first word in upper case, and rest in lower case. We can see that all entries have first char capital and remaining in small case below and everywhere.

App/src/languages/en.js

Lines 220 to 231 in b69b5f3

	reportActionContextMenu: {
	copyToClipboard: 'Copy to clipboard',
	copied: 'Copied!',
	copyLink: 'Copy link',
	copyURLToClipboard: 'Copy URL to clipboard',
	copyEmailToClipboard: 'Copy email to clipboard',
	markAsUnread: 'Mark as unread',
	editComment: 'Edit comment',
	deleteComment: 'Delete comment',
	deleteConfirmation: 'Are you sure you want to delete this comment?',
	addReactionTooltip: 'Add Reaction',
	},

This is my observation but we can ask suggestion from design team and do correction as they suggest.

What alternative solutions did you explore? (Optional)

None

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency in the tooltip texts between 'Edit comment/ Delete comment' & 'Add Reaction' in the report context menu.

What is the root cause of that problem?

The texts used to display tooltip texts in English are inconsistent.

App/src/languages/en.js

Lines 223 to 230 in 47e5dfb

	copyLink: 'Copy link',
	copyURLToClipboard: 'Copy URL to clipboard',
	copyEmailToClipboard: 'Copy email to clipboard',
	markAsUnread: 'Mark as unread',
	editComment: 'Edit comment',
	deleteComment: 'Delete comment',
	deleteConfirmation: 'Are you sure you want to delete this comment?',
	addReactionTooltip: 'Add Reaction',

Our pattern is to use a lowercase letter for the first letter of the second word. So addReactionTooltip: 'Add Reaction' is an exception.

What changes do you think we should make in order to solve the problem?

Solution 1:
We can change

App/src/languages/en.js

Lines 227 to 228 in f45ebd7

	editComment: 'Edit comment',
	deleteComment: 'Delete comment',

to editComment: 'Edit Comment' and deleteComment: 'Delete Comment' to achieve the expected result.

Solution 2 (preferable):
We can change

App/src/languages/en.js

Line 230 in 47e5dfb

addReactionTooltip: 'Add Reaction',

to addReactionTooltip: 'Add reaction' to follow the majority of cases.

Additionally, other texts in https://github.com/Expensify/App/blob/main/src/languages/en.js and https://github.com/Expensify/App/blob/main/src/languages/es.js (which are not mentioned in the issue) also need fixing. We should confirm the rule of using lowercase and uppercase letters before we can replace all remaining inconsistent texts.

What alternative solutions did you explore? (Optional)

NA

Result

Working well after the fix:

[ayazhussain79]

Please consider my Proposal I have fixed it yesterday

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistency in the tooltip texts between 'Edit comment/ Delete comment' & 'Add Reaction' R is capital as compare to other tooltip

What is the root cause of that problem?

on en.js file addReactionTooltip: 'Add Reaction' R is capital

What changes do you think we should make in order to solve the problem?

On en.js we need to update addReactionTooltip: 'Add Reaction' 'R' into lower case like that addReactionTooltip: 'Add reaction'

Result:

[MelvinBot]

📣 @ayazhussain79! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ayazhussain79]

Contributor details
Your Expensify account email: hussainayaz79@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~018a62c1e70a3fab40

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mananjadhav]

@ayazhussain79 Please check the Contributing Guidelines. We first put out a proposal and once accepted only then you start the work on the PR.

This is a very straightforward issue and proposals from @PrashantMangukiya @tienifr, both will work and are same.

@Expensify/design @shawnborton @puneetlath @tjferriss Can you confirm if we follow any specific case for the tooltips/content? Do nothing is also an option here right?

[shawnborton]

I think we generally follow Sentence case for everything, so it would be "Like this" and NOT "Like This"

[puneetlath]

Agreed, let's update the Add reaction button to follow the way others are done (in both languages).

[mananjadhav]

Okay thanks for the update. Based on the comments above I think we're good with @PrashantMangukiya's proposal here

[mananjadhav]

@puneetlath Forgot to tag you in the above comment.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make r small within Add reaction tooltip #16047

If no regressions arise, payment will be issued on 2023-03-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @avi-shek-jha
• Contributor that fixed the issue @PrashantMangukiya
• Contributor+ that helped on the issue and/or PR @mananjadhav

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @puneetlath] The PR that introduced the bug has been identified. Link to the PR: feat: add/remove reaction #15210
• [@mananjadhav / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: feat: add/remove reaction #15210 (comment)
• [@mananjadhav / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @tjferriss] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath / @tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

@mananjadhav and @avi-shek-jha can you both please apply for the job on the Upworks so I can process payments: https://www.upwork.com/jobs/~01317e9c8ba89234e9

[mananjadhav]

@tjferriss do you mind sending in an invite to proposal? I don't have the connects to apply for the job.

[tjferriss]

Done. @avi-shek-jha I can't find you in Upworks, can you please apply?

[PrashantMangukiya]

@tjferriss It looks like you send me offer again on upwork for this project, please cancel it. I already accepted one offer on 17th March. So now it shows two offer for same project.

[PrashantMangukiya]

@tjferriss I can see another offer is cancelled. Or you can keep another offer and use it to pay for timeline bonus for the pr. So now only one offer is active. Thank you.

[avi-shek-jha]

@tjferriss I've submitted the proposal and applied for the job. Thank you

[puneetlath]

@mananjadhav can you help with the checklist?

[mananjadhav]

PR that introduce this bug is #15210 where we added Emoji Reactions.

I think we don't need a regression test here, what do you think @puneetlath @tjferriss ? and do you think it warrants for a discussion on #expensify-open-source channel?

[PrashantMangukiya]

@tjferriss Ping for Upwork

[tjferriss]

Payments have been sent. I agree with not needing a regression test.

[PrashantMangukiya]

@tjferriss Should I also eligible for timeline bonus as pr merged within three busines.

[tjferriss]

Yes, my mistake. I should have flagged this when initially reviewing the payments. I've sent both you and @mananjadhav the speed bonus.

[mananjadhav]

Thanks @tjferriss

[PrashantMangukiya]

@tjferriss Received Payments + Timeline bonus. Thanks you for your time.

[PrashantMangukiya]

@tjferriss Please close the contract on Upwork, so I can submit good rating. Thank you.

[puneetlath]

I think we're good to go here, so closing out. @tjferriss please reopen if there's something outstanding.