-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAID] [$1000] Tooltip is missing on rotate image button on avatar crop modal #15941
Comments
Triggered auto assignment to @anmurali ( |
Bug0 Triage Checklist (Main S/O)
|
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I am not sure this is a bug. Discussing here |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tooltip is missing on rotate image button on avatar crop modal What is the root cause of that problem?The root cause of this problem is that the tooltip has not been implemented on the button. What changes do you think we should make in order to solve the problem?We just need to wrap rotate button with Tooltip component in AvatarCropModal.js What alternative solutions did you explore? (Optional)Additionally, we can add another tooltip for the zoom icon |
📣 @aman-atg! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Format:
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@anmurali Still overdue 6 days?! Let's take care of this! |
@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
1 similar comment
@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Job added to Upwork: https://www.upwork.com/jobs/~01040e37fe8a2e89a8 |
Current assignee @anmurali is eligible for the External assigner, not assigning anyone new. |
Added the fact that the Zoom icon has no tooltip either and set this as an external job |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
📣 @PrashantMangukiya You have been assigned to this job by @arosiclair! |
Thanks @arosiclair Applied to job on Upwork. Will submit PR within two hours. |
@eVoloshchak @arosiclair PR is ready for review. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.96-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-04-14. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Partially filled BZ checklist |
Not overdue, this is waiting for BugZero Checklist to be finished and payments to be settled |
Ping for Upwork. |
@anmurali Offer accepted on Upwork. Just a reminder. I am also eligible for Timeline and Reporting bonus for this issue. |
@PrashantMangukiya - paid |
Regression Test Proposal
Do we agree 👍 or 👎 |
https://github.com/Expensify/Expensify/issues/277058 Paid and regression test proposal added |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
It should show tooltip with text "Rotate" and "Zoom" respectively
Actual Result:
No tooltip is shown
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
NoTooltipCropView.mov
Expensify/Expensify Issue URL:
Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678727788153259
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: