Add tooltip to rotate image button and zoom slider #16920

PrashantMangukiya · 2023-04-04T16:03:32Z

@eVoloshchak @arosiclair PR is ready for review.

Details

Tooltip is missing on Rotate image button and Slider knob on avatar crop modal. So in this PR we added tooltip for both.

Note: Tooltip is applicable for Web and Desktop only. I added screenshot for all platform to make sure there is not any side effect.

Fixed Issues

$ #15941
PROPOSAL: #15941 (comment)

Tests

Go to Settings > Profile > Upload Photo
It will show image crop modal
Hover over Rotate Image button
Hover over Zoom slider knob.
Verify that it will show tooltip for Rotate Image Button and Zoom Slider knob.
For English tooltip will be "Rotate" and "Zoom" respectively.
For Spanish tooltip will be "Rotar" and "Zoom" respectively.

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Upload Photo
It will show image crop modal
Hover over Rotate Image button
Hover over Zoom slider knob.
Verify that it will show tooltip for Rotate Image Button and Zoom Slider knob.
For English tooltip will be "Rotate" and "Zoom" respectively.
For Spanish tooltip will be "Rotar" and "Zoom" respectively.

QA Steps

Go to Settings > Profile > Upload Photo
It will show image crop modal
Hover over Rotate Image button
Hover over Zoom slider knob.
Verify that it will show tooltip for Rotate Image Button and Zoom Slider knob.
For English tooltip will be "Rotate" and "Zoom" respectively.
For Spanish tooltip will be "Rotar" and "Zoom" respectively.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome En

Web-Chrome-En.mp4

Chrome Es

Web-Chrome-ES.mov

Android

En

Android-En.mp4

Es

Android-Es.mp4

MelvinBot · 2023-04-04T16:03:40Z

@arosiclair @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-04-05T12:23:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-05.at.15.24.18.mov

Mobile Web - Chrome

Screen_Recording_20230405-152818_Chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-04-05.at.15.26.02.mov

Desktop

Screen.Recording.2023-04-05.at.15.28.46.mov

iOS

Screen.Recording.2023-04-05.at.16.08.44.mov

Android

Screen_Recording_20230405-153027_New.Expensify.mp4

eVoloshchak · 2023-04-05T13:23:14Z

src/components/AvatarCropModal/Slider.js

@@ -22,6 +26,8 @@ const defaultProps = {

 // This component can't be written using class since reanimated API uses hooks.
 const Slider = (props) => {
+    const [enableTooltipView, setEnableTooltipView] = useState(true);


Suggested change

const [enableTooltipView, setEnableTooltipView] = useState(true);

const [tooltipIsVisible, setTooltipIsVisible] = useState(true);

Other than this small change, everything looks good and tests well

@eVoloshchak Updated state variable name as per request. Thank you.

eVoloshchak

Looks good and tests well!
cc: @arosiclair

arosiclair

Looks good just a translation update

arosiclair · 2023-04-05T14:25:02Z

src/languages/en.js

@@ -149,6 +149,8 @@ export default {
    avatarCropModal: {
        title: 'Edit photo',
        description: 'Drag, zoom, and rotate your image to your preferred specifications',
+        rotateImage: 'Rotate',
+        zoomImage: 'Zoom',


Since these two are just the generic words "rotate" and "zoom", can we move these to the common object? (common.rotate and common.zoom).

arosiclair · 2023-04-05T14:25:47Z

src/languages/es.js

@@ -148,6 +148,8 @@ export default {
    avatarCropModal: {
        title: 'Editar foto',
        description: 'Arrastra, haz zoom y rota tu imagen para que quede como te gusta.',
+        rotateImage: 'Girar',


Suggested change

rotateImage: 'Girar',

rotateImage: 'Rotar',

Heard back from our people on this translation. Let's use "Rotar".

eVoloshchak · 2023-04-05T14:40:45Z

src/languages/es.js

@@ -18,6 +18,8 @@ export default {
        resend: 'Reenviar',
        save: 'Guardar',
        saveChanges: 'Guardar cambios',
+        rotateImage: 'Rotar',


Suggested change

rotateImage: 'Rotar',

rotate: 'Rotar',

eVoloshchak · 2023-04-05T14:40:56Z

src/languages/es.js

@@ -18,6 +18,8 @@ export default {
        resend: 'Reenviar',
        save: 'Guardar',
        saveChanges: 'Guardar cambios',
+        rotateImage: 'Rotar',
+        zoomImage: 'Zoom',


Suggested change

zoomImage: 'Zoom',

zoom: 'Zoom',

PrashantMangukiya · 2023-04-05T14:47:42Z

@arosiclair @eVoloshchak Correction done as per your request. Also updated screenshot and pr description accordingly. Thank you.

arosiclair

Looks good! Thanks for the changes

OSBotify · 2023-04-05T16:21:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-06T01:33:46Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.2.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-07T22:13:21Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.96-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add tooltip to rotate image button and zoom slider

d534eca

PrashantMangukiya requested a review from a team as a code owner April 4, 2023 16:03

melvin-bot bot requested review from arosiclair and eVoloshchak and removed request for a team April 4, 2023 16:03

eVoloshchak suggested changes Apr 5, 2023

View reviewed changes

Change state variable name

fd02234

eVoloshchak previously approved these changes Apr 5, 2023

View reviewed changes

arosiclair requested changes Apr 5, 2023

View reviewed changes

Change spanish translation and move key to common

7f2977d

PrashantMangukiya dismissed eVoloshchak’s stale review via 7f2977d April 5, 2023 14:37

eVoloshchak suggested changes Apr 5, 2023

View reviewed changes

Change key name for rotate and zoom

dcf3533

eVoloshchak approved these changes Apr 5, 2023

View reviewed changes

arosiclair approved these changes Apr 5, 2023

View reviewed changes

arosiclair merged commit ef6977e into Expensify:main Apr 5, 2023

OSBotify mentioned this pull request Apr 6, 2023

Deploy Checklist: New Expensify 2023-04-06 #16996

Closed

16 tasks

MelvinBot mentioned this pull request Apr 7, 2023

[PAID] [$1000] Tooltip is missing on rotate image button on avatar crop modal #15941

Closed

6 tasks

truph01 mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-08-07] [$250] Web - Profile - Hovering over the zoom tool does not display a tooltip #44029

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tooltip to rotate image button and zoom slider #16920

Add tooltip to rotate image button and zoom slider #16920

PrashantMangukiya commented Apr 4, 2023 •

edited

Loading

MelvinBot commented Apr 4, 2023

eVoloshchak commented Apr 5, 2023 •

edited

Loading

eVoloshchak Apr 5, 2023

eVoloshchak Apr 5, 2023

PrashantMangukiya Apr 5, 2023

eVoloshchak left a comment

arosiclair left a comment

arosiclair Apr 5, 2023

PrashantMangukiya Apr 5, 2023

arosiclair Apr 5, 2023

PrashantMangukiya Apr 5, 2023

eVoloshchak Apr 5, 2023

PrashantMangukiya Apr 5, 2023

eVoloshchak Apr 5, 2023

PrashantMangukiya Apr 5, 2023

PrashantMangukiya commented Apr 5, 2023

arosiclair left a comment

OSBotify commented Apr 5, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

	const [enableTooltipView, setEnableTooltipView] = useState(true);
	const [tooltipIsVisible, setTooltipIsVisible] = useState(true);

Add tooltip to rotate image button and zoom slider #16920

Add tooltip to rotate image button and zoom slider #16920

Conversation

PrashantMangukiya commented Apr 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Chrome En

Chrome Es

Safari En

Safari Es

En

Es

En

Es

En

Es

En

Es

En

Es

MelvinBot commented Apr 4, 2023

eVoloshchak commented Apr 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eVoloshchak left a comment

Choose a reason for hiding this comment

arosiclair left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PrashantMangukiya commented Apr 5, 2023

arosiclair left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 5, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

PrashantMangukiya commented Apr 4, 2023 •

edited

Loading

eVoloshchak commented Apr 5, 2023 •

edited

Loading