[HOLD for payment 2023-10-24] [$250] Migrate index.ios.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/DatePicker/index.ios.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f16eb77fe7da0a3d
• Upwork Job ID: 1689728545595305984
• Last Price Increase: 2023-08-10

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[muxriddinmuqimov77]

I'd like to work on this issue

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this issue?

[mkhutornyi]

I'd like to work on this.

[ghost]

Dibs?

[aditygrg2]

Hello, I would like to work on this issue.

[pasyukevich]

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

[alexxxwork]

dibs

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate index.ios.js to function component

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

we need to migrate the class component to the functional component

• useEffect
• useState
• useRef

[ghost]

Dibs?

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[marcaaron]

Thanks but there's already an assignee @mananjadhav

[mananjadhav]

@marcaaron Noted.

[pasyukevich]

PR is ready for review

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @pasyukevich, @marcaaron, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MitchExpensify]

Heads up @mananjadhav, there is a PR here waiting for your review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor DatePicker component for ios #24528

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @pasyukevich does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mananjadhav]

@MitchExpensify Can you please post the payment summary here?

[MitchExpensify]

Payment summary:

$250 - @mananjadhav (Eligible for Manual Requests)

[JmillsExpensify]

$250 approved for @mananjadhav based on comment above.

[mananjadhav]

@MitchExpensify I think it is safe to close this. It was a migration so no checklist needed.

[MitchExpensify]

Thanks!