Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-07-10] [$250] Migrate EmojiPicker.js to function component #16144

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 32 comments
Closed
1 task

[HOLD for payment 2023-07-10] [$250] Migrate EmojiPicker.js to function component #16144

marcaaron opened this issue Mar 20, 2023 · 32 comments
Assignees
@yuwenmemon @slafortune @parasharrajat
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01274ca81cada83261
  • Upwork Job ID: 1665737553579581440
  • Last Price Increase: 2023-06-05
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate EmojiPicker.js to function component [HOLD][$250] Migrate EmojiPicker.js to function component Apr 13, 2023
@yuwenmemon yuwenmemon self-assigned this Apr 27, 2023
@kuluruvineeth

This comment was marked as spam.

Sign in to view
@marcaaron marcaaron changed the title [HOLD][$250] Migrate EmojiPicker.js to function component [$250] Migrate EmojiPicker.js to function component Jun 2, 2023
@marcaaron
Copy link
Contributor Author

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

@marcaaron marcaaron added the Daily KSv2 label Jun 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@multijump
Copy link
Contributor

I can work on this issue if it goes to external.

@yuwenmemon yuwenmemon removed their assignment Jun 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor Overdue labels Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01274ca81cada83261

@yuwenmemon yuwenmemon added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Vishrut19
Copy link
Contributor

I want to work on this @yuwenmemon

@kuluruvineeth
Copy link

@yuwenmemon @arosiclair @s77rt can I work on this issue, if so could you please assign it to me.

@yuwenmemon
Copy link
Contributor

Oops sorry fellas I put External on the wrong one I'm working on this one 😅

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

@yuwenmemon, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

@parasharrajat
Copy link
Member

Running the final tests today.

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

@yuwenmemon, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

@yuwenmemon, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@yuwenmemon
Copy link
Contributor

Still holding on feature freeze

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 3, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate EmojiPicker.js to function component [HOLD for payment 2023-07-10] [$250] Migrate EmojiPicker.js to function component Jul 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023 •
edited by yuwenmemon
Loading

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 9, 2023
@yuwenmemon
Copy link
Contributor

Just need to pay @parasharrajat

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@slafortune
Copy link
Contributor

Offer sent @parasharrajat

@slafortune
Copy link
Contributor

Actually @parasharrajat do you want to request money on new dot instead of paying you on Upwork?

@parasharrajat
Copy link
Member

I haven't received any payments for this so far. I also waiting for a few things to check before I can request payments.

Can we please reopen this so it is easy for me to track and put this to weekly to keep melvin out for a few days?
@slafortune @yuwenmemon

@slafortune
Copy link
Contributor

@parasharrajat I did send you an offer here - https://www.upwork.com/nx/wm/offer/25482923. Once you accept this we'll be all good 👍

@slafortune slafortune reopened this Jul 12, 2023
@parasharrajat
Copy link
Member

I saw that but I am waiting on trying the new method if that works for me.

@slafortune slafortune added Weekly KSv2 and removed Daily KSv2 labels Jul 13, 2023
@parasharrajat
Copy link
Member

Payment requested.

@anmurali
Copy link

Approved $250 based on #16144 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuwenmemon yuwenmemon

@slafortune slafortune

@parasharrajat parasharrajat

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests