Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Migrate index.js to function component #16157

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 18 comments
Closed
1 task

[$250] Migrate index.js to function component #16157

marcaaron opened this issue Mar 20, 2023 · 18 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bc94d4c41a7b0d23
  • Upwork Job ID: 1698680756238737408
  • Last Price Increase: 2023-09-04
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@s-alves10
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@ghost
Copy link

ghost commented Jul 13, 2023

Dibs?

@aditygrg2
Copy link

Hello, I would like to work on this issue.

@teneeto
Copy link
Contributor

teneeto commented Aug 30, 2023

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

📣 @teneeto! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Sep 4, 2023
@mountiny mountiny changed the title [HOLD][$250] Migrate index.js to function component [$250] Migrate index.js to function component Sep 4, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01bc94d4c41a7b0d23

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@rushatgabhane
Copy link
Member

rushatgabhane commented Sep 5, 2023

@muxriddinmuqimov77 all yours! #16157 (comment)

🎀 👀 🎀

@gedu
Copy link
Contributor

gedu commented Sep 11, 2023

@rushatgabhane I think @teneeto has being assigned

@mountiny mountiny changed the title [HOLD][$250] Migrate index.js to function component [$250] Migrate index.js to function component Sep 22, 2023
@marcochavezf
Copy link
Contributor

Reasigning @situchan as C+ reviewer, also assigning myself to track the GH issue

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

This issue has not been updated in over 15 days. @marcochavezf, @teneeto, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@marcaaron
Copy link
Contributor Author

Looks like this one has been migrated so gonna close it out. Feel free to leave a comment or reopen if there is something left to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests