[HOLD for payment 2023-08-10] [$250] Migrate ScrollViewWithContext.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/ScrollViewWithContext.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5685c1928bbd220
• Upwork Job ID: 1685091994929782784
• Last Price Increase: 2023-07-29
• Automatic offers:
• s77rt | Reviewer | 25883214
• Parshvi16 | Contributor | 25883217

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[s-alves10]

I'd love to work on this.

[vdem0115]

I can work on this issue.

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[mejed-alkoutaini]

I'm able to work on this if needed!

[mkhutornyi]

I'd like to work on this.

[KrAbhas]

I can work on this

[melvin-bot]

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5685c1928bbd220

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[Parshvi16]

@madmax330 gently bump here

[jayeshmangwani]

@Parshvi16 is a new contributor, and they are assigned to one issue already, so we should assign this issue to another contributor

cc: @s77rt

[Parshvi16]

sorry @jayeshmangwani but I've already created the PR and it is almost ready to be merged.
also, the other issue you are talking about is even completed from C+ side, just waiting to be merged from internal engineer.

[jayeshmangwani]

I've already created the PR and it is almost ready to be merged. also, the other issue you are talking about is even completed from C+ side, just waiting to be merged from internal engineer.

I am commenting here because you are not yet assigned by the internal engineer to this issue and, as a new contributor limited to working on one job at a time

[Parshvi16]

was unaware, i think that rule is probably to allow new contributors to learn slowly and get some time.
but as you can see in my case, both the PRs are ready from my side and are just pending on reviewers.
anyways, the PR is ready so I don't think it should be assigned to someone else, i'm available here and free from the other PR as it is C+ reviewed and ready to be merged.

[s77rt]

@jayeshmangwani I think we can still move forward with @Parshvi16 for this case. cc @madmax330

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Parshvi16 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Parshvi16]

accepted the offer on upwork.
@madmax330 we can go ahead with the merge!

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @Parshvi16, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Parshvi16 got assigned: 2023-08-01 15:39:17 Z
• when the PR got merged: 2023-08-01 16:17:56 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrated ScrollViewWithContext to a functional component #23879

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @Parshvi16 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Parshvi16]

@madmax330 My Upwork account is getting on hold due to name problem so I had to make a new one.
Please end the contract on current one and re-hire through this new account.
https://www.upwork.com/freelancers/~01c5aafb1ea741db18

[twisterdotcom]

@Parshvi16 I cancelled to contract issued from here: #16200 (comment)

I sent a new one to your new account here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/25992855

[twisterdotcom]

@isabelastisser this was just from my monitoring the contributors@ inbox.

[isabelastisser]

I will get to this soon.

[isabelastisser]

Payment summary:

@s77rt: $250 C+ review,
@Parshvi16: $250 approved proposal

The payments were processed in Upwork, all set!

[s77rt]

@isabelastisser Functional migration issues are not eligible for the bonus.