[HOLD for payment 2023-07-14] [$250] Migrate BaseTextInput.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/TextInput/BaseTextInput.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[dummy-1111]

I'd love to work on this.

[mountiny]

Margelo is working on this one as its a handy pre-requisite to one performance bug they want to resolve.

[mountiny]

Margelo is an expert agency and they will handle this migration as part of fixing a gnarly old bug in the app.

[hannojg]

👋

[mountiny]

Assigning also Rajat as they have helped with the review too!

[mountiny]

Merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix #16696] Rewrite BaseTextInput to function component #20186

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[mountiny]

Or actually sorry for the ping, I think the payment will be handled in this issue #16696 which was the main reason for this PR and the bounty is way higher there and can be incorporated I think